Re: [maintainer-tools PATCH 5/6] dim: add dim sparse subcommand to run sparse on a commit range

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Oct 11, 2016 at 11:47:31AM +0300, Jani Nikula wrote:
> Run sparse only on files that have changed in the range.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  dim     |  9 +++++++++
>  dim.rst | 22 +++++++++++++++-------
>  2 files changed, 24 insertions(+), 7 deletions(-)
> 
> diff --git a/dim b/dim
> index e3ef4365e85f..bef7bb6c401b 100755
> --- a/dim
> +++ b/dim
> @@ -731,6 +731,15 @@ function dim_checkpatch
>  	done
>  }
>  
> +function dim_sparse
> +{
> +	local range=$(rangeish "$1")
> +
> +	make $DIM_MAKE_OPTIONS
> +	touch --no-create `git diff --name-only $range` `git diff --name-only`
> +	make C=1
> +}
> +
>  function dim_checker
>  {
>  	rm -f drivers/gpu/drm/i915/*.o drivers/gpu/drm/i915/*.ko
> diff --git a/dim.rst b/dim.rst
> index 58e222a7d590..7244052dea03 100644
> --- a/dim.rst
> +++ b/dim.rst
> @@ -186,12 +186,6 @@ fixes *commit-ish*
>  Print the Fixes: and Cc: lines for the supplied *commit-ish* in the linux kernel
>  CodingStyle approved format.
>  
> -check-patch|cp [*commit-ish* [.. *commit-ish*]]
> ------------------------------------------------
> -Runs the given commit range commit-ish..commit-ish through the check tools. If
> -no commit-ish is passed, defaults to HEAD^..HEAD. If one commit-ish is passed
> -instead of a range, the range commit-ish..HEAD is used.
> -
>  cherry-pick *commit-ish* [*git cherry-pick arguments*]
>  ------------------------------------------------------
>  
> @@ -259,9 +253,23 @@ remote is up-to-date. Useful if drm-intel-next has been changed since the last
>  run of the update-next command (e.g. to apply a hotfix before sending out the
>  pull request).
>  
> +checkpatch|check-patch|cp [*commit-ish* [.. *commit-ish*]]
> +----------------------------------------------------------
> +Runs the given commit range commit-ish..commit-ish through the check tools.
> +
> +If no commit-ish is passed, defaults to HEAD^..HEAD. If one commit-ish is passed
> +instead of a range, the range commit-ish..HEAD is used.
> +
> +sparse [*commit-ish* [.. *commit-ish*]]
> +---------------------------------------

Since we have this nice rangeish helper, should we change the synopsis to
[rangeish], with a separate section explaining what a dim rangeish is?
Just a drive-by bikeshed really, ok as-is.
-Daniel

> +Run sparse on the files changed by the given commit range.
> +
> +If no commit-ish is passed, defaults to HEAD^..HEAD. If one commit-ish is passed
> +instead of a range, the range commit-ish..HEAD is used.
> +
>  checker
>  -------
> -Run sparse on the kernel.
> +Run sparse on drm/i915.
>  
>  create-branch *branch* [*commit-ish*]
>  -------------------------------------
> -- 
> 2.1.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx