From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Weinehall Subject: Re: [PATCH 18/19] drm/i915: Make INTEL_GEN only take dev_priv Date: Wed, 12 Oct 2016 14:44:07 +0300 Message-ID: <20161012114407.k7emdvfm4nnmcyor@boom> References: <1476192112-25336-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1476192112-25336-19-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8D406E826 for ; Wed, 12 Oct 2016 11:44:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1476192112-25336-19-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMTEsIDIwMTYgYXQgMDI6MjE6NTFQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBTYXZlcyA5NjggYnl0ZXMgb2YgLnJvZGF0YSBzdHJpbmdzLgo+IAo+IHYyOiBBZGQgcGFy YW50aGVzZXMgYXJvdW5kIGRldl9wcml2LiAoVmlsbGUgU3lyamFsYSkKPiAKPiBTaWduZWQtb2Zm LWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmV2aWV3ZWQt Ynk6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNvbT4KCj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgICAgIHwgMiAr LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZW5kZXJfc3RhdGUuYyB8IDYgKysr LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyAgICAgICAgIHwgMiAr LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyAgICAgICAgICB8IDggKysr Ky0tLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggZjlmOWEyMThkNWZlLi4zZjM4Yjk3 NTU3NjMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjYwNCw4ICsyNjA0LDgg QEAgc3RydWN0IGRybV9pOTE1X2NtZF90YWJsZSB7Cj4gIAlfX3A7IFwKPiAgfSkKPiAgI2RlZmlu ZSBJTlRFTF9JTkZPKHApCSgmX19JOTE1X18ocCktPmluZm8pCj4gLSNkZWZpbmUgSU5URUxfR0VO KHApCShJTlRFTF9JTkZPKHApLT5nZW4pCj4gIAo+ICsjZGVmaW5lIElOVEVMX0dFTihkZXZfcHJp dikJKChkZXZfcHJpdiktPmluZm8uZ2VuKQo+ICAjZGVmaW5lIElOVEVMX0RFVklEKGRldl9wcml2 KQkoKGRldl9wcml2KS0+aW5mby5kZXZpY2VfaWQpCj4gIAo+ICAjZGVmaW5lIFJFVklEX0ZPUkVW RVIJCTB4ZmYKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVu ZGVyX3N0YXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZW5kZXJfc3RhdGUu Ywo+IGluZGV4IDk1YjdlOWFmZDVmOC4uYTk4YzBmNDJiYWRkIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlbmRlcl9zdGF0ZS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVuZGVyX3N0YXRlLmMKPiBAQCAtNzIsOSArNzIsOSBAQCBy ZW5kZXJfc3RhdGVfZ2V0X3JvZGF0YShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3Qg KnJlcSkKPiAgCj4gIHN0YXRpYyBpbnQgcmVuZGVyX3N0YXRlX3NldHVwKHN0cnVjdCByZW5kZXJf c3RhdGUgKnNvKQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gc28tPnZtYS0+dm0t PmRldjsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoc28t PnZtYS0+dm0tPmRldik7Cj4gIAljb25zdCBzdHJ1Y3QgaW50ZWxfcmVuZGVyc3RhdGVfcm9kYXRh ICpyb2RhdGEgPSBzby0+cm9kYXRhOwo+IC0JY29uc3QgYm9vbCBoYXNfNjRiaXRfcmVsb2MgPSBJ TlRFTF9HRU4oZGV2KSA+PSA4Owo+ICsJY29uc3QgYm9vbCBoYXNfNjRiaXRfcmVsb2MgPSBJTlRF TF9HRU4oZGV2X3ByaXYpID49IDg7Cj4gIAl1bnNpZ25lZCBpbnQgaSA9IDAsIHJlbG9jX2luZGV4 ID0gMDsKPiAgCXN0cnVjdCBwYWdlICpwYWdlOwo+ICAJdTMyICpkOwo+IEBAIC0xMTUsNyArMTE1 LDcgQEAgc3RhdGljIGludCByZW5kZXJfc3RhdGVfc2V0dXAoc3RydWN0IHJlbmRlcl9zdGF0ZSAq c28pCj4gIAo+ICAJc28tPmF1eF9iYXRjaF9vZmZzZXQgPSBpICogc2l6ZW9mKHUzMik7Cj4gIAo+ IC0JaWYgKEhBU19QT09MRURfRVUoZGV2KSkgewo+ICsJaWYgKEhBU19QT09MRURfRVUoZGV2X3By aXYpKSB7Cj4gIAkJLyoKPiAgCQkgKiBXZSBhbHdheXMgcHJvZ3JhbSAzeDYgcG9vbCBjb25maWcg YnV0IGRlcGVuZGluZyB1cG9uIHdoaWNoCj4gIAkJICogc3Vic2xpY2UgaXMgZGlzYWJsZWQgSFcg ZHJvcHMgZG93biB0byBhcHByb3ByaWF0ZSBjb25maWcKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gaW5kZXggYzNmYjlmNzAwYzdhLi5lZGEzOGU1M2Y2OGEgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEyNDUyLDcgKzEyNDUyLDcgQEAgaW50 IGludGVsX3BsYW5lX2F0b21pY19jYWxjX2NoYW5nZXMoc3RydWN0IGRybV9jcnRjX3N0YXRlICpj cnRjX3N0YXRlLAo+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwbGFuZV9zdGF0ZS0+ ZmI7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCWlmIChJTlRFTF9HRU4oZGV2KSA+PSA5ICYmIHBsYW5l LT50eXBlICE9IERSTV9QTEFORV9UWVBFX0NVUlNPUikgewo+ICsJaWYgKElOVEVMX0dFTihkZXZf cHJpdikgPj0gOSAmJiBwbGFuZS0+dHlwZSAhPSBEUk1fUExBTkVfVFlQRV9DVVJTT1IpIHsKPiAg CQlyZXQgPSBza2xfdXBkYXRlX3NjYWxlcl9wbGFuZSgKPiAgCQkJdG9faW50ZWxfY3J0Y19zdGF0 ZShjcnRjX3N0YXRlKSwKPiAgCQkJdG9faW50ZWxfcGxhbmVfc3RhdGUocGxhbmVfc3RhdGUpKTsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IGY3NjBkNWZjYmU0OC4uOGI0 NzQ4ODM5YzA3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0 ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBAQCAtNzUz LDcgKzc1Myw3IEBAIGludGVsX2NoZWNrX3Nwcml0ZV9wbGFuZShzdHJ1Y3QgZHJtX3BsYW5lICpw bGFuZSwKPiAgCQkJIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkg c3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiAgewo+IC0Jc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IHBsYW5lLT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSB0b19pOTE1KHBsYW5lLT5kZXYpOwo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0gc3Rh dGUtPmJhc2UuY3J0YzsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50 ZWxfY3J0YyhjcnRjKTsKPiAgCXN0cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmUgPSB0b19p bnRlbF9wbGFuZShwbGFuZSk7Cj4gQEAgLTc5Nyw3ICs3OTcsNyBAQCBpbnRlbF9jaGVja19zcHJp dGVfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAl9Cj4gIAo+ICAJLyogc2V0dXAg Y2FuX3NjYWxlLCBtaW5fc2NhbGUsIG1heF9zY2FsZSAqLwo+IC0JaWYgKElOVEVMX0lORk8oZGV2 KS0+Z2VuID49IDkpIHsKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpIHsKPiAgCQkv KiB1c2Ugc2NhbGVyIHdoZW4gY29sb3JrZXkgaXMgbm90IHJlcXVpcmVkICovCj4gIAkJaWYgKHN0 YXRlLT5ja2V5LmZsYWdzID09IEk5MTVfU0VUX0NPTE9SS0VZX05PTkUpIHsKPiAgCQkJY2FuX3Nj YWxlID0gMTsKPiBAQCAtOTEzLDcgKzkxMyw3IEBAIGludGVsX2NoZWNrX3Nwcml0ZV9wbGFuZShz dHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCj4gIAkJd2lkdGhfYnl0ZXMgPSAoKHNyY194ICog Y3BwKSAmIDYzKSArIHNyY193ICogY3BwOwo+ICAKPiAtCQlpZiAoSU5URUxfSU5GTyhkZXYpLT5n ZW4gPCA5ICYmIChzcmNfdyA+IDIwNDggfHwgc3JjX2ggPiAyMDQ4IHx8Cj4gKwkJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPCA5ICYmIChzcmNfdyA+IDIwNDggfHwgc3JjX2ggPiAyMDQ4IHx8Cj4g IAkJICAgIHdpZHRoX2J5dGVzID4gNDA5NiB8fCBmYi0+cGl0Y2hlc1swXSA+IDQwOTYpKSB7Cj4g IAkJCURSTV9ERUJVR19LTVMoIlNvdXJjZSBkaW1lbnNpb25zIGV4Y2VlZCBoYXJkd2FyZSBsaW1p dHNcbiIpOwo+ICAJCQlyZXR1cm4gLUVJTlZBTDsKPiBAQCAtOTMyLDcgKzkzMiw3IEBAIGludGVs X2NoZWNrX3Nwcml0ZV9wbGFuZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCWRzdC0+eTEg PSBjcnRjX3k7Cj4gIAlkc3QtPnkyID0gY3J0Y195ICsgY3J0Y19oOwo+ICAKPiAtCWlmIChJTlRF TF9HRU4oZGV2KSA+PSA5KSB7Cj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KSB7Cj4g IAkJcmV0ID0gc2tsX2NoZWNrX3BsYW5lX3N1cmZhY2Uoc3RhdGUpOwo+ICAJCWlmIChyZXQpCj4g IAkJCXJldHVybiByZXQ7Cj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==