From: Jim Bride <jim.bride@linux.intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: Fix whitespace issues
Date: Thu, 13 Oct 2016 11:18:50 -0700 [thread overview]
Message-ID: <20161013181850.GG4042@shiv> (raw)
In-Reply-To: <1476208368-5710-5-git-send-email-ville.syrjala@linux.intel.com>
On Tue, Oct 11, 2016 at 08:52:48PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fix the poorly indented port parameters to the aux ctl and data
> reg functions. This was fallout from the s/i915_mmio_reg_t/i915_reg_t/
> that happened during the review of commit f0f59a00a1c9 ("drm/i915:
> Type safe register read/write")
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jim Bride <jim.bride@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index b0753b272101..25cde7356b59 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1147,7 +1147,7 @@ static enum port intel_aux_port(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t g4x_aux_ctl_reg(struct drm_i915_private *dev_priv,
> - enum port port)
> + enum port port)
> {
> switch (port) {
> case PORT_B:
> @@ -1161,7 +1161,7 @@ static i915_reg_t g4x_aux_ctl_reg(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t g4x_aux_data_reg(struct drm_i915_private *dev_priv,
> - enum port port, int index)
> + enum port port, int index)
> {
> switch (port) {
> case PORT_B:
> @@ -1175,7 +1175,7 @@ static i915_reg_t g4x_aux_data_reg(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t ilk_aux_ctl_reg(struct drm_i915_private *dev_priv,
> - enum port port)
> + enum port port)
> {
> switch (port) {
> case PORT_A:
> @@ -1191,7 +1191,7 @@ static i915_reg_t ilk_aux_ctl_reg(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t ilk_aux_data_reg(struct drm_i915_private *dev_priv,
> - enum port port, int index)
> + enum port port, int index)
> {
> switch (port) {
> case PORT_A:
> @@ -1207,7 +1207,7 @@ static i915_reg_t ilk_aux_data_reg(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t skl_aux_ctl_reg(struct drm_i915_private *dev_priv,
> - enum port port)
> + enum port port)
> {
> switch (port) {
> case PORT_A:
> @@ -1222,7 +1222,7 @@ static i915_reg_t skl_aux_ctl_reg(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t skl_aux_data_reg(struct drm_i915_private *dev_priv,
> - enum port port, int index)
> + enum port port, int index)
> {
> switch (port) {
> case PORT_A:
> @@ -1237,7 +1237,7 @@ static i915_reg_t skl_aux_data_reg(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t intel_aux_ctl_reg(struct drm_i915_private *dev_priv,
> - enum port port)
> + enum port port)
> {
> if (INTEL_INFO(dev_priv)->gen >= 9)
> return skl_aux_ctl_reg(dev_priv, port);
> @@ -1248,7 +1248,7 @@ static i915_reg_t intel_aux_ctl_reg(struct drm_i915_private *dev_priv,
> }
>
> static i915_reg_t intel_aux_data_reg(struct drm_i915_private *dev_priv,
> - enum port port, int index)
> + enum port port, int index)
> {
> if (INTEL_INFO(dev_priv)->gen >= 9)
> return skl_aux_data_reg(dev_priv, port, index);
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-13 18:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 17:52 [PATCH 0/4] drm/i915: Trust VBT aux/ddc information ville.syrjala
2016-10-11 17:52 ` [PATCH 1/4] drm/i915: Respect alternate_aux_channel for all DDI ports ville.syrjala
2016-10-13 17:59 ` [Intel-gfx] " Jim Bride
2016-10-11 17:52 ` [PATCH 2/4] drm/i915: Respect alternate_ddc_pin " ville.syrjala
2016-10-11 20:04 ` Maarten Maathuis
2016-10-12 10:57 ` Ville Syrjälä
2016-10-12 16:56 ` Maarten Maathuis
2016-10-13 18:06 ` Jim Bride
2016-10-13 18:29 ` Ville Syrjälä
2016-10-17 6:50 ` [Intel-gfx] " Daniel Vetter
2016-10-11 17:52 ` [PATCH 3/4] drm/i915: Clean up DDI DDC/AUX CH sanitation ville.syrjala
2016-10-13 18:17 ` Jim Bride
2016-10-17 18:00 ` Ville Syrjälä
2016-10-17 18:07 ` [PATCH v3 " ville.syrjala
2016-10-20 21:53 ` Maarten Maathuis
2016-10-20 22:00 ` Maarten Maathuis
2016-10-21 13:17 ` Ville Syrjälä
2016-10-11 17:52 ` [PATCH 4/4] drm/i915: Fix whitespace issues ville.syrjala
2016-10-13 18:18 ` Jim Bride [this message]
2016-10-11 18:49 ` ✗ Fi.CI.BAT: warning for drm/i915: Trust VBT aux/ddc information Patchwork
2016-10-12 10:54 ` Ville Syrjälä
2016-10-17 18:54 ` ✗ Fi.CI.BAT: failure for drm/i915: Trust VBT aux/ddc information (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013181850.GG4042@shiv \
--to=jim.bride@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox