From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: Suppress underruns during DP link retraining Date: Fri, 14 Oct 2016 20:48:57 +0300 Message-ID: <20161014174857.GF4329@intel.com> References: <1476464574-32230-1-git-send-email-ville.syrjala@linux.intel.com> <1476464574-32230-3-git-send-email-ville.syrjala@linux.intel.com> <20161014172749.GR6646@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D5EC6E146 for ; Fri, 14 Oct 2016 17:49:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161014172749.GR6646@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMTQsIDIwMTYgYXQgMDY6Mjc6NDlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIEZyaSwgT2N0IDE0LCAyMDE2IGF0IDA4OjAyOjU0UE0gKzAzMDAsIHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gRFAgbGluayByZXRyYWluaW5n IGNhdXNlcyAoc3B1cmlvdXM/KSB1bmRlcnJ1bnMuIFdlIGNhbid0IHJlYWxseSBhdm9pZAo+ID4g dGhlbSwgZXhjZXB0IHBlcmhhcHMgYnkgZG9pbmcgYSBmdWxsIG1vZGVzZXQgKHdoaWNoIGhhcyBp dHMgb3duIHVuZGVycnVuCj4gPiBzdXBwcmVzc2lvbiBhbnl3YXkpLiBTbyBsZXQncyBqdXN0IGhp ZGUgdGhlbS4KPiA+IAo+ID4gTVNUIHN0aWxsIGhhcyBpdHMgb3duIGxvZ2ljIGZvciByZXRyYWlu aW4sIGJ1dCBhIGJpZ2dlciBocGQgaGFuZGxpbmcKPiA+IGNsZWFudXAvdW5pZmljYXRpb24gaXMg bmVlZGVkIHRoZXJlIGFueXdheSwgc28gbGV0J3MgbGVhdmUgdGhhdCBiZSBmb3Igbm93Lgo+ID4g Cj4gPiBSZWZlcmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNn aT9pZD05ODI1MQo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgfCAyOSArKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ID4gIDEgZmlsZSBj aGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMKPiA+IGluZGV4IGJjMDNmNjFkOTRmMS4uNzgwNjkxYTM0MTMzIDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gQEAgLTM5ODgsNiArMzk4OCwzMSBAQCBn b19hZ2FpbjoKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQKPiA+ICtpbnRlbF9kcF9yZXRy YWluX2xpbmsoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ICt7Cj4gPiArCXN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyID0gJmRwX3RvX2RpZ19wb3J0KGludGVsX2RwKS0+YmFzZTsK PiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVy LT5iYXNlLmRldik7Cj4gPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0 YyhlbmNvZGVyLT5iYXNlLmNydGMpOwo+ID4gKwo+ID4gKwkvKiBTdXBwcmVzcyB1bmRlcnJ1bnMg Y2F1c2VkIGJ5IHJlLXRyYWluaW5nICovCj4gPiArCWludGVsX3NldF9jcHVfZmlmb191bmRlcnJ1 bl9yZXBvcnRpbmcoZGV2X3ByaXYsIGNydGMtPnBpcGUsIGZhbHNlKTsKPiA+ICsJaWYgKGNydGMt PmNvbmZpZy0+aGFzX3BjaF9lbmNvZGVyKQo+ID4gKwkJaW50ZWxfc2V0X3BjaF9maWZvX3VuZGVy cnVuX3JlcG9ydGluZyhkZXZfcHJpdiwKPiA+ICsJCQkJCQkgICAgICBpbnRlbF9jcnRjX3BjaF90 cmFuc2NvZGVyKGNydGMpLCBmYWxzZSk7Cj4gPiArCj4gPiArCWludGVsX2RwX3N0YXJ0X2xpbmtf dHJhaW4oaW50ZWxfZHApOwo+ID4gKwlpbnRlbF9kcF9zdG9wX2xpbmtfdHJhaW4oaW50ZWxfZHAp Owo+ID4gKwo+ID4gKwkvKiBLZWVwIHVuZGVycnVuIHJlcG9ydGluZyBkaXNhYmxlZCB1bnRpbCB0 aGluZ3MgYXJlIHN0YWJsZSAqLwo+ID4gKwlpbnRlbF93YWl0X2Zvcl92YmxhbmsoJmRldl9wcml2 LT5kcm0sIGNydGMtPnBpcGUpOwo+IAo+IEkgcGFuaWNrZWQgb3ZlciB0aGUgaXJxcmV0dXJuIGZv ciBocGRfcHVsc2UuIFRoYXQncyBhIHNjYXJ5IHdheSBvZgo+IHNheWluZyB0aGUgcmV0dXJuIHR5 cGUgaXMgYm9vbGVhbi4KCkl0J3MgYmVlbiBrbm93biB0byBjYXVzZSBidWdzIHRvbyB3aGVuIHBl b3BsZSBkb24ndCByZW1lbWJlciB3aGF0IGl0Cm1lYW5zLgoKPiAKPiA+ICsJaW50ZWxfc2V0X2Nw dV9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgdHJ1ZSk7Cj4g PiArCWlmIChjcnRjLT5jb25maWctPmhhc19wY2hfZW5jb2RlcikKPiA+ICsJCWludGVsX3NldF9w Y2hfZmlmb191bmRlcnJ1bl9yZXBvcnRpbmcoZGV2X3ByaXYsCj4gPiArCQkJCQkJICAgICAgaW50 ZWxfY3J0Y19wY2hfdHJhbnNjb2RlcihjcnRjKSwgdHJ1ZSk7Cj4gCj4gVGhlc2UgYXJlIGJlY29t aW5nIHF1aXRlIHBvcHVsYXIuIElzIGhhc19wY2hfZW5jb2RlciBnZW5lcmljIGVub3VnaCBmb3IK PiBhbGwgY3J0Yz8KPiAKPiBpbnRlbF9jcnRjX3N1cHByZXNzX3VuZGVycnVucyhzdHJ1Y3QgaW50 ZWxfY3J0YyAqY3J0YywgYm9vbCBzdGF0ZSkKPiB7Cj4gCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+IAo+IAlpZiAoIXN0YXRlKQo+ IAkJaW50ZWxfd2FpdF9mb3JfdmJsYW5rKCZkZXZfcHJpdi0+ZHJtLCBjcnRjLT5waXBlKTsKPiAK PiAJaW50ZWxfc2V0X2NwdV9maWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwgY3J0Yy0+ cGlwZSwgc3RhdGUpOwo+IAlpZiAoY3J0Yy0+Y29uZmlnLT5oYXNfcGNoX2VuY29kZXIpCj4gCQlp bnRlbF9zZXRfcGNoX2ZpZm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LAo+IAkJCQkJCSAg ICAgIGludGVsX2NydGNfcGNoX3RyYW5zY29kZXIoY3J0YyksCj4gCQkJCQkJICAgICAgc3RhdGUp Owo+IH0KCkhtbS4gSSBzdXBwb3NlIHdlIGNvdWxkIHJlcGxhY2UgYSB0aGUgb25lcyBpbiBkcC9o ZG1pL3Nkdm8gY29kZQp3aXRoIHNvbWV0aGluZyBsaWtlIHRoYXQuIFdvdWxkIG5lZWQgdG8gdXNl CmludGVsX3dhaXRfZm9yX3ZibGFua19pZl9hY3RpdmUoKSB0aG91Z2guCgpUaGUgb25lcyBkaXJl Y3RseSBpbiB0aGUgY3J0YyBlbmFibGUvZGlzYWJsZSBwYXRocyBwYXRocyBhcmVuJ3QgcXVpdGUK dGhhdCBzdHJhaWdodGZvcndhcmQgdGhvdWdoLiBNYWtpbmcgdGhlbSBzaW1wbGVyIG1pZ2h0IGVh c2UgdGhlCm1haW50ZW5hbmNlIGJ1cmRlbiB0aG91Z2gsIHdpdGggdGhlIGNvc3Qgb2YgYSBzbGln aHQgbG9zcyBpbiBjb3ZlcmFnZS4KCj4gCj4gSWYgdGhpcyB3YXMgaWd0LCB3ZSB3b3VsZCBiZSB3 cml0aW5nIGFsbCBraW5kcyBvZiBzaWxseQo+IAo+ICNkZWZpbmUgaW50ZWxfY3J0Y19zdXBwcmVz c191bmRlcnJ1bnMoY3J0Yywgc3RhdGUpIFwKPiAJZm9yIChzdGF0ZSA9IHRydWU7IF9faW50ZWxf Y3J0Y19zdXBwcmVzc191bmRlcnJ1bnMoY3J0Yywgc3RhdGUpOyBzdGF0ZSA9IGZhbHNlKQo+IAo+ IAo+IGludGVsX2NydGNfc3VwcHJlc3NfdW5kZXJydW5zKGNydGMsIHN0YXRlKSB7Cj4gCWludGVs X2RwX3N0YXJ0X2xpbmtfdHJhaW4oaW50ZWxfZHApOwo+IAlpbnRlbF9kcF9zdG9wX2xpbmtfdHJh aW4oaW50ZWxfZHApOwo+IH0KPiAKPiBPdGhlciB0aGFuIGJpa2VzaGVkZGluZyB0byBzZWUgaWYg d2UgY2FuIHRyaW0gZG93biB0aGUgcHJvZmlsZXJhdGlvbiwKPiB0aGlzIGxvb2tzIGlubGluZSB3 aXRoIHRoZSBzdXBwcmVzc2lvbiBldmVyeXdoZXJlIGVsc2UsIHNvCj4gUmV2aWV3ZWQtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IAo+IE1haW4gY29uY2VybiB3 YXMgb3ZlciB0aGUgdmJsYW5rIHdhaXQgbWFraW5nIHNob3J0L2xvbmcgcHVsc2UgaGFuZGxpbmcK PiBzbG93ZXIsIGJ1dCB0aGUgY29kZSBsb29rcyBsaWtlIGl0IHdpbGwgc3Vydml2ZSAtIGFuZCB0 aGUgb25seQo+IG5vdGljZWFibGUgYXJ0aWZhY3RzIHdvdWxkIGJlIGlmIGxpbmsgdHJhaW5pbmcg ZmFpbGVkIGFueXdheSB3aXRoIHRoZQo+IHNtYWxsIGRlbGF5IGJlZm9yZSByZWNvdmVyeS4KClRo ZSBwaXBlIHNob3VsZCBiZSBydW5uaW5nIHN0aWxsIHNvIGF0IGxlYXN0IGl0IHNob3VsZG4ndCBo YXZlIHRvIHdhaXQKZm9yIGEgdGltZW91dC4KCkluIGdlbmVyYWwgdGhlIHJldHJhaW5pbmcgZG9l c24ndCBmZWVsIGVudGlyZWx5IHJvYnVzdC4gSWYgSSB0cnkgZm9yY2UgYQpyZXRyYWluaW5nIG9u IG15IElMSyBvciBJVkIgd2hlbiB0aGUgbGluayBpcyBhY3R1YWxseSBnb29kLCBpdCBnZW5lcmFs bHkKZG9lc24ndCBzdWNjZWVkLiBJZiBJIHRvZ2dsZSB0aGUgcG9ydCBzdGF0ZSBhdCB0aGUgc3Rh cnQgb2YgdGhlCnJldHJhaW5pbmcgaXQgc3RhcnRzIHRvIHdvcmsuIFRoZSBzcGVjIGV2ZW4gc2F5 cyB3ZSBzaG91bGQgZG8gdGhhdCwgc28KbWlnaHQgYmUgd2Ugc2hvdWxkIGdvIGZvciBpdC4gSSB0 aGluayBJJ2xsIG5lZWQgdG8gZGlnZXN0IHRoaXMgaWRlYSBhCmJpdCBtb3JlIHRob2doLCBhcyBJ IGhhdmVuJ3QgcG9uZGVyZWQgdGhlIHJhbWlmaWNhdGlvbnMgdGhvcm91Z2x5LgoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==