public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Shashank Sharma <shashank.sharma@intel.com>
Cc: Jose.Abreu@synopsys.com, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com,
	daniel.vetter@intel.com, jim.bride@linux.intel.com
Subject: Re: [PATCH v4 0/4]  Picture aspect ratio support in DRM layer
Date: Mon, 17 Oct 2016 14:25:16 +0200	[thread overview]
Message-ID: <20161017122516.GH20761@phenom.ffwll.local> (raw)
In-Reply-To: <1476705880-15600-1-git-send-email-shashank.sharma@intel.com>

On Mon, Oct 17, 2016 at 05:34:36PM +0530, Shashank Sharma wrote:
> This patch series adds 4 patches.
> - The first two patches add aspect ratio support in DRM layes
> - Next two patches add new aspect ratios defined in CEA-861-F
>   supported for HDMI 2.0 4k modes.
> 
> Adding aspect ratio support in DRM layer:
> - The CEA videmodes contain aspect ratio information, which we
>   parse when we read the modes from EDID. But while transforming
>   user_mode to kernel_mode or viceversa, DRM layer lose this
>   information.
> - HDMI compliance testing for CEA modes, expects the AVI info frames
>   to contain exact VIC no for the 'video mode under test'. Now CEA
>   modes have different VIC for same modes but different aspect ratio
>   for example:
>         VIC 2 = 720x480@60 4:3
>         VIC 3 = 720x480@60 16:9
>   In this way, lack of aspect ratio information, can cause wrong VIC
>   no in AVI IF, causing HDMI complaince test to fail.
> - This patch set adds code, which embeds the aspect ratio information
>   also in DRM video mode flags, and uses it while comparing two modes.
> 
> Adding new aspect ratios for HDMI 2.0
> - CEA-861-F defines two new aspect ratios, to be used for 4k HDMI 2.0
>   modes.
>         - 64:27
>         - 256:135
> Last two patches in the series, adds code to handle these new
> aspect ratios.
> 
> V2: Fixed review comments from Sean, Emil, Daniel
> V3: Fixed review comments from Jim Bride, got r-b for all patches
> V4: Added r-b from Jose for the series, and ack-by from Tomi on patch 3
> 
> Shashank Sharma (4):
>   drm: add picture aspect ratio flags
>   drm: Add aspect ratio parsing in DRM layer
>   video: Add new aspect ratios for HDMI 2.0
>   drm: Add and handle new aspect ratios in DRM layer

Applied to drm-misc, thanks. I guess you'll follow up with i915 patches to
remove the picture aspect ratio for overrides eventually?

Thanks, Daniel

> 
>  drivers/gpu/drm/drm_modes.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/video/hdmi.c        |  4 ++++
>  include/linux/hdmi.h        |  2 ++
>  include/uapi/drm/drm_mode.h | 24 +++++++++++++++++++-----
>  4 files changed, 68 insertions(+), 5 deletions(-)
> 
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-10-17 12:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 12:04 [PATCH v4 0/4] Picture aspect ratio support in DRM layer Shashank Sharma
2016-10-17 12:04 ` [PATCH v4 1/4] drm: add picture aspect ratio flags Shashank Sharma
2016-10-17 12:04 ` [PATCH v4 2/4] drm: Add aspect ratio parsing in DRM layer Shashank Sharma
2016-10-17 12:31   ` [Intel-gfx] " Ville Syrjälä
2016-10-17 13:40     ` Sharma, Shashank
2016-10-17 14:06       ` Ville Syrjälä
2016-10-17 14:51         ` [Intel-gfx] " Sharma, Shashank
2016-10-17 15:00           ` Ville Syrjälä
2016-10-17 15:07             ` [Intel-gfx] " Sharma, Shashank
2016-10-17 12:04 ` [PATCH v4 3/4] video: Add new aspect ratios for HDMI 2.0 Shashank Sharma
2016-10-17 12:39   ` Ville Syrjälä
2016-10-17 12:04 ` [PATCH v4 4/4] drm: Add and handle new aspect ratios in DRM layer Shashank Sharma
2016-10-17 12:25 ` Daniel Vetter [this message]
2016-10-17 13:17   ` [PATCH v4 0/4] Picture aspect ratio support " Sharma, Shashank
2016-10-17 12:42 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-10-17 13:24   ` Saarinen, Jani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161017122516.GH20761@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=Jose.Abreu@synopsys.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jim.bride@linux.intel.com \
    --cc=shashank.sharma@intel.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox