From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT
Date: Tue, 18 Oct 2016 09:34:49 +0200 [thread overview]
Message-ID: <20161018073449.GT20761@phenom.ffwll.local> (raw)
In-Reply-To: <1476715610.32479.26.camel@intel.com>
On Mon, Oct 17, 2016 at 05:46:50PM +0300, Imre Deak wrote:
> On ma, 2016-10-17 at 16:32 +0200, Daniel Vetter wrote:
> > On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote:
> > > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests
> > > to
> > > BAT. At the same time remove basic-s4 from the list, which is atm
> > > implicitly disabled via HIBERNATION=n in kconfig. We would need at
> > > least
> > > basic S4 coverage provided by basic-s4-devices, which requires
> > > HIBERNATION=y.
> > >
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> >
> > What's the impact on BAT runtime with this?
>
> I measured 8 sec for S3-devices and 9 sec for S4-devices on my APL.
>
> > Afaik we're already over budget ... Where do you safe the time to
> > afford this?
>
> I didn't, but we don't have any S4 coverage in CI atm and it's the
> minimum that can be added. The S3-devices subtest is not critical,
> although it would be useful for cases where we wouldn't get any logs
> for the full S3 test.
Yeah, I don't think a reduced S3 test in BAT is useful if we have the
full one already. It's a good test for debugging, but not within the very
tight constraints we have for BAT.
Re S4: If it indeed improves coverage (i.e. calls our shutdown hooks and
all these S4-only callbacks) then adding it to BAT sounds reasonable.
Still there's the issue of where to get the machine time from. I really do
think you need to first trade in some speed-up here (or throw out some
other tests) before you can add more tests.
And yes I know that's not fun, but until we have CI running a more
complete test set (after BAT has done the initial sanity checking, to
avoid wasting machine time on broken patches), that's the reality we have
:(
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-18 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 12:39 [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT Imre Deak
2016-10-17 14:32 ` Daniel Vetter
2016-10-17 14:46 ` Imre Deak
2016-10-17 14:56 ` Jani Nikula
2016-10-17 15:01 ` Saarinen, Jani
2016-10-17 15:02 ` Imre Deak
2016-10-18 7:34 ` Daniel Vetter [this message]
2016-10-18 9:03 ` Petri Latvala
2016-10-18 9:23 ` Ville Syrjälä
2016-11-25 9:50 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018073449.GT20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox