From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property
Date: Tue, 18 Oct 2016 12:16:45 +0300 [thread overview]
Message-ID: <20161018091645.GZ4329@intel.com> (raw)
In-Reply-To: <5171123.EojsEFJzJ1@avalon>
On Tue, Oct 18, 2016 at 11:13:53AM +0300, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Tuesday 18 Oct 2016 09:36:23 Daniel Vetter wrote:
> > On Tue, Oct 18, 2016 at 01:38:05AM +0300, Laurent Pinchart wrote:
> > > On Friday 22 Jul 2016 16:43:13 ville.syrjala@linux.intel.com wrote:
> > >> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >>
> > >> Now that all drivers have been converted over to the per-plane rotation
> > >> property, we can just nuke the global rotation property.
> > >>
> > >> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Stupid question, but how does this work when the hardware supports global
> > > rotation only, not per-plane rotation ?
> >
> > Does that exist? If so I guess we get to add a rotation property to CRTCS
> > (and update docs and all that).
>
> I have a hardware composer that performs rotation on the output side. At the
> moment it doesn't support rotation when used with the display, but I wouldn't
> rule that out in future SoC versions. So I'm not aware of any use case for a
> rotation property on the CRTC at the moment, I just wanted to make sure we
> have a path forward.
I even implemented that for i915 long ago by having it rotate all the
planes (+ adjust their coordinates appropriately). But people weren't
too keen on putting that in, so I dropped it.
https://lists.freedesktop.org/archives/intel-gfx/2014-February/040053.html
The only bigger snafu here is omap, which already has a rotation property
on the crtc, except it actually only rotates the primary plane. So
when/if someone adds a real crtc rotation property it has to be called
something else that "rotation". I think I settled on "crtc-rotation"
judging what I have in my last branch on that topic.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-10-18 9:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 13:43 [PATCH 00/15] drm: Per-plane rotation etc ville.syrjala
2016-07-22 13:43 ` [PATCH 01/15] drm: Add drm_rotation_90_or_270() ville.syrjala
2016-07-22 13:43 ` [PATCH 02/15] drm/atomic: Reject attempts to use multiple rotation angles at once ville.syrjala
2016-07-22 13:43 ` [PATCH v2 03/15] drm: Add support for optional per-plane rotation property ville.syrjala
2016-07-25 7:08 ` Joonas Lahtinen
2016-07-22 13:43 ` [PATCH 04/15] drm/arm: Use " ville.syrjala
2016-07-22 14:37 ` Brian Starkey
2016-07-22 13:43 ` [PATCH 05/15] drm/atmel-hlcdc: " ville.syrjala
2016-07-22 13:58 ` Boris Brezillon
2016-07-22 15:47 ` [PATCH v2 " ville.syrjala
2016-08-10 8:35 ` Boris Brezillon
2016-08-10 9:09 ` Ville Syrjälä
2016-08-10 9:25 ` Boris Brezillon
2016-08-10 11:41 ` Ville Syrjälä
2016-08-10 11:52 ` Boris Brezillon
2016-08-10 12:04 ` Boris Brezillon
2016-08-10 14:04 ` Daniel Vetter
2016-08-10 16:38 ` Boris Brezillon
2016-08-11 8:50 ` Daniel Vetter
2016-07-22 13:43 ` [PATCH 06/15] drm/omap: Set rotation property initial value to BIT(DRM_ROTATE_0) insted of 0 ville.syrjala
2016-07-22 13:43 ` [PATCH 07/15] drm/omap: Use per-plane rotation property ville.syrjala
2016-08-11 11:32 ` Tomi Valkeinen
2016-08-11 13:33 ` Ville Syrjälä
2016-08-12 16:04 ` Ville Syrjälä
2016-09-23 11:33 ` [Intel-gfx] " Tomi Valkeinen
2016-07-22 13:43 ` [PATCH 08/15] drm/msm/mdp5: Set rotation property initial value to BIT(DRM_ROTATE_0) insted of 0 ville.syrjala
2016-07-22 13:43 ` [PATCH 09/15] drm/msm/mdp5: Use per-plane rotation property ville.syrjala
2016-07-22 13:43 ` [PATCH 10/15] drm/msm/mdp5: Advertize 180 degree rotation ville.syrjala
2016-07-22 13:43 ` [PATCH v2 11/15] drm/i915: Use the per-plane rotation property ville.syrjala
2016-07-25 6:19 ` Joonas Lahtinen
2016-07-22 13:43 ` [PATCH 12/15] drm: RIP mode_config->rotation_property ville.syrjala
2016-07-25 6:08 ` Joonas Lahtinen
2016-10-17 22:38 ` Laurent Pinchart
2016-10-18 7:36 ` Daniel Vetter
2016-10-18 8:13 ` Laurent Pinchart
2016-10-18 9:16 ` Ville Syrjälä [this message]
2016-07-22 13:43 ` [PATCH 13/15] drm/i915: Use & instead if == to check for rotations ville.syrjala
2016-07-22 13:43 ` [PATCH 14/15] drm/i915: Clean up rotation DSPCNTR/DVSCNTR/etc. setup ville.syrjala
2016-07-22 13:43 ` [PATCH 15/15] drm/i915: Add horizontal mirroring support for CHV pipe B planes ville.syrjala
2016-07-22 14:24 ` ✗ Ro.CI.BAT: failure for drm: Per-plane rotation etc Patchwork
2016-07-22 16:31 ` ✗ Ro.CI.BAT: failure for drm: Per-plane rotation etc. (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018091645.GZ4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).