public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/gvt: Stop checking for impossible interrupts from a kthread
@ 2016-10-19  8:12 Chris Wilson
  2016-10-19  8:12 ` [PATCH 2/2] drm/i915/gvt: Stop waiting whilst holding struct_mutex Chris Wilson
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Chris Wilson @ 2016-10-19  8:12 UTC (permalink / raw)
  To: intel-gfx

The kthread will not be interrupted, don't even bother checking.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gvt/scheduler.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index b15cdf5978a9..4cedd3274da7 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -423,12 +423,7 @@ static int workload_thread(void *priv)
 		/*
 		 * Always take i915 big lock first
 		 */
-		ret = i915_mutex_lock_interruptible(&gvt->dev_priv->drm);
-		if (ret < 0) {
-			gvt_err("i915 submission is not available, retry\n");
-			schedule_timeout(1);
-			continue;
-		}
+		mutex_lock(&gvt->dev_priv->drm.struct_mutex);
 
 		gvt_dbg_sched("ring id %d will dispatch workload %p\n",
 				workload->ring_id, workload);
@@ -447,7 +442,7 @@ static int workload_thread(void *priv)
 				workload->ring_id, workload);
 
 		workload->status = i915_wait_request(workload->req,
-						     I915_WAIT_INTERRUPTIBLE | I915_WAIT_LOCKED,
+						     I915_WAIT_LOCKED,
 						     NULL, NULL);
 		if (workload->status != 0)
 			gvt_err("fail to wait workload, skip\n");
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-10-19 11:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19  8:12 [PATCH 1/2] drm/i915/gvt: Stop checking for impossible interrupts from a kthread Chris Wilson
2016-10-19  8:12 ` [PATCH 2/2] drm/i915/gvt: Stop waiting whilst holding struct_mutex Chris Wilson
2016-10-19  8:54   ` Zhenyu Wang
2016-10-19  9:08     ` Chris Wilson
2016-10-19  9:14     ` [PATCH v2] " Chris Wilson
2016-10-19  9:22       ` Chris Wilson
2016-10-19  9:47       ` Zhenyu Wang
2016-10-19  8:55   ` [PATCH 2/2] " Matthew Auld
2016-10-19  8:50 ` [PATCH 1/2] drm/i915/gvt: Stop checking for impossible interrupts from a kthread Zhenyu Wang
2016-10-19 11:01 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/gvt: Stop checking for impossible interrupts from a kthread (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox