Re: [PATCH i-g-t 0/3] Convert sh scripts to C variants.

Joonas Lahtinen
2016-10-21T07:38:31Z

On pe, 2016-10-21 at 00:00 +0300, Jani Nikula wrote:
> > On Thu, 20 Oct 2016, Marius Vlad <marius.c.vlad@intel.com> wrote:
> >
> > This series adds some library support to help converting sh
> > scripts to C version. Converted drv_module_reload_basic and
> > kms_sysfs_edid_timing.
>
> >
> >  18 files changed, 600 insertions(+), 180 deletions(-)
>
> Someone please justify this, plus pulling in two new dependencies. I can
> think of a thing or two, but it needs to be in the commit messages. And
> I'm not convinced by the justification I came up with.

Hmm, not sure how Daniel instructed things. Original idea was to just
execv the same commands as the scripts do. To get rid of the
interpreter differences and allow running in a minimal environment.

I'm myself fine with using the libraries too, I think the tests can
then be improved upon, just like Chris has commented on a few of them.

Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation