public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Manasi Navare <manasi.d.navare@intel.com>
To: intel-gfx@freedesktop.org
Subject: Redo a modeset on link training failure
Date: Thu, 20 Oct 2016 19:31:53 -0700	[thread overview]
Message-ID: <20161021023152.GB19529@intel.com> (raw)

Hi Ville,

I have implemented the code that we discussed where if the link training
fails, it would validate the modes on the new constraints and call
an atomic helper like drm_atomic_helper_connector_modeset() to redo
a modeset for the same mode. The two patches for this implemnetation is
are:

http://paste.ubuntu.com/23357104/
http://paste.ubuntu.com/23357105/

With this I can successfully trigger the modeset and retrain the link
at lower link rate. But I am getting a warning during intel_audio_codec_enable()
in intel_enable_ddi() during the commit phase on SKL.
Following is the dmesg log:

http://paste.ubuntu.com/23357075/

After further looking at it, I see that this calls drm_select_eld() function
that throws a warning if the mode_config mutex and modeset locks are held.
If I remove those WARN_ONs from there, I can get rid of this warning and
everything works smoothly.

Do you know if those WARN_ONs are required because these locks would be grabbed
when we are in modeset.

Regards
Manasi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2016-10-21  2:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  2:31 Manasi Navare [this message]
2016-10-21  9:35 ` Redo a modeset on link training failure Ville Syrjälä
2016-10-24  8:51   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021023152.GB19529@intel.com \
    --to=manasi.d.navare@intel.com \
    --cc=intel-gfx@freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox