From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Paneri, Praveen" <praveen.paneri@intel.com>
Subject: Re: [PATCH 1/4] igt_fb: Add Y-tiling support
Date: Wed, 26 Oct 2016 11:20:51 +0300 [thread overview]
Message-ID: <20161026082051.GW4617@intel.com> (raw)
In-Reply-To: <3ebdc890-8b52-5a90-e0e8-feffbb310920@linux.intel.com>
On Wed, Oct 26, 2016 at 09:09:26AM +0100, Tvrtko Ursulin wrote:
>
> On 26/10/2016 07:32, Daniel Vetter wrote:
> > On Tue, Oct 25, 2016 at 03:02:33PM +0000, Paneri, Praveen wrote:
> >>> So when you say that all Y tiling tests fail without this kernel hack, which tests you are referring to?
> >> If I revert this IGT patch and do not make below kernel change, kms_draw_crc (ytiled cases, last patch in this series) fail with following error.
> >>
> >> Test assertion failure function igt_assert_crc_equal, file hardware/intel/intel-gpu-tools/lib/igt_debugfs.c:266:
> >> Failed assertion: a->crc[i] == b->crc[i]
> >> error: 0x68c96b8b != 0x948e53b
> >>
> >> I think, I shall debug it further and try to fix it without making this change.
> >
> > Can't we just set the fb modifiers when creating the drm_fb in the igt
> > helpers?
>
> Thats already there, if I understand what you mean. But it only does the
> modifer and does not set the object tiling. So I suspect this test might
> be depending on object tiling being set as well? In which case we may
> be missing the capability to create the object separately from the fb
> creation, because otherwise it is too late to try to change the object
> tiling.
I'm pretty sure I had patches to split the two apart. Assuming I never
posted them, they must be on a branch... somewhere.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-26 8:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:55 [PATCH 1/4] igt_fb: Add Y-tiling support Praveen Paneri
2016-10-24 16:55 ` [PATCH 2/4] lib/igt_draw: " Praveen Paneri
2016-10-24 17:05 ` Ville Syrjälä
2016-10-25 8:08 ` Tvrtko Ursulin
2016-10-26 6:30 ` Daniel Vetter
2016-10-24 16:55 ` [PATCH 3/4] lib/igt_draw: Add Y-tiling support for IGT_DRAW_BLT method Praveen Paneri
2016-10-24 16:55 ` [PATCH 4/4] tests/kms_draw_crc: add support for Y tiling Praveen Paneri
2016-10-25 8:06 ` [PATCH 1/4] igt_fb: Add Y-tiling support Tvrtko Ursulin
2016-10-25 8:18 ` Chris Wilson
2016-10-25 8:20 ` Tvrtko Ursulin
2016-10-25 8:31 ` Chris Wilson
2016-10-25 12:06 ` Paneri, Praveen
2016-10-25 12:36 ` Tvrtko Ursulin
2016-10-25 15:02 ` Paneri, Praveen
2016-10-26 6:32 ` Daniel Vetter
2016-10-26 8:09 ` Tvrtko Ursulin
2016-10-26 8:20 ` Ville Syrjälä [this message]
2016-10-26 16:38 ` Ville Syrjälä
2016-10-27 6:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026082051.GW4617@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=praveen.paneri@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox