From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] igt/kms_flip: Calibrate timestamp errors
Date: Wed, 26 Oct 2016 12:17:25 +0300 [thread overview]
Message-ID: <20161026091725.GZ4617@intel.com> (raw)
In-Reply-To: <20161026061813.4oathxxsfzf3nuzy@phenom.ffwll.local>
On Wed, Oct 26, 2016 at 08:18:13AM +0200, Daniel Vetter wrote:
> On Mon, Oct 24, 2016 at 10:38:34AM +0100, Chris Wilson wrote:
> > On Mon, Oct 24, 2016 at 11:14:31AM +0200, Daniel Vetter wrote:
> > > On Mon, Oct 24, 2016 at 09:54:52AM +0100, Chris Wilson wrote:
> > > Also with this patch we should be able to throw out the hacks for tv-out.
> > > I only added those because the reported mode-timings are massively off
> > > (due to the magic tv scaler thing) from the real timestamps we receive.
> > > Auto-detecting this is much better.
> >
> > Not quite just yet, we need to split the timing tests into a subgroup
> > with a subtest per output so that we can skip one without skipping the
> > others. At the moment, this check makes it bail out on my ctg/ilk who
> > have a difference of about 50us between measured and expected vblank
> > interval on LVDS (which is nigh on impossible given our confidence in the
> > measurement, i.e. about 7 sigma).
>
> Hm, should we be a bit more sloppy in our acceptance? Iirc Ville has made
> changes to make it a bit more strict a while ago, and way, way back this
> stuff worked on my ctg. Haven't fired it up in a while ;-)
>
> > > And another issue: Failing to match the reported mode timings is a driver
> > > bug.
> >
> > Not quite, remember we override the user for fixed mode panels. But yes,
> > piglit also has a similar expectation that the dotclock we report (via
> > GetMscRate) in someway corresponds to actual vblank interval.
>
> Yeah, I hope that DRRS would fix that, at least on newer stuff. At least I
> proposed just using the matching dotclock for manual DRRS (mostly to
> perfectly match with the refresh rate of a video). Didn't yet happen :(
>
> But at least for the default mode we should try real hard to match.
The problem is the granularity of the PLL. For fixed mode panels we
could easily fix up what we report to userspace as the clock, which
would fix these tests. For external displays it's not quite so clear.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-26 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 8:54 [PATCH igt] igt/kms_flip: Calibrate timestamp errors Chris Wilson
2016-10-24 9:14 ` Daniel Vetter
2016-10-24 9:38 ` Chris Wilson
2016-10-26 6:18 ` Daniel Vetter
2016-10-26 9:10 ` Chris Wilson
2016-10-26 9:17 ` Ville Syrjälä [this message]
2016-10-27 6:43 ` Daniel Vetter
2016-10-27 10:13 ` Ville Syrjälä
2016-10-27 10:29 ` Chris Wilson
2016-10-27 11:41 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026091725.GZ4617@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).