From: Jeff McGee <jeff.mcgee@intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Peter Antoine <peter.antoine@intel.com>
Subject: Re: [PATCH 6/7] drm/i915/huc: Add BXT HuC Loading Support
Date: Mon, 31 Oct 2016 13:29:13 -0700 [thread overview]
Message-ID: <20161031202913.GQ18646@jeffdesk> (raw)
In-Reply-To: <1477699546-6624-7-git-send-email-anusha.srivatsa@intel.com>
On Fri, Oct 28, 2016 at 05:05:45PM -0700, Anusha Srivatsa wrote:
> From: Peter Antoine <peter.antoine@intel.com>
>
> This patch adds the HuC Loading for the BXT.
> Version 1.7 of the HuC firmware.
>
> v2: rebased.
> v3: rebased.
> changed file name to match the install package format.
> v7: rebased.
> v8: rebased.
>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Peter Antoine <peter.antoine@intel.com>
> Reviewed-by: David Gordon <david.s.gordon@intel.com>
> ---
> drivers/gpu/drm/i915/intel_huc_loader.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_huc_loader.c b/drivers/gpu/drm/i915/intel_huc_loader.c
> index dcd9970..0969bdf 100644
> --- a/drivers/gpu/drm/i915/intel_huc_loader.c
> +++ b/drivers/gpu/drm/i915/intel_huc_loader.c
> @@ -43,6 +43,9 @@
> #define I915_SKL_HUC_UCODE "i915/skl_huc_ver01_07_1398.bin"
> MODULE_FIRMWARE(I915_SKL_HUC_UCODE);
>
> +#define I915_BXT_HUC_UCODE "i915/bxt_huc_ver01_07_1398.bin"
> +MODULE_FIRMWARE(I915_BXT_HUC_UCODE);
> +
This will need updating if the newer firmware version/name macros in
intel_guc_loader.c are adopted.
-Jeff
> /**
> * huc_ucode_xfer() - DMA's the firmware
> * @dev_priv: the drm device
> @@ -150,6 +153,10 @@ void intel_huc_init(struct drm_device *dev)
> fw_path = I915_SKL_HUC_UCODE;
> huc_fw->major_ver_wanted = 1;
> huc_fw->minor_ver_wanted = 7;
> + } else if (IS_BROXTON(dev_priv)) {
> + fw_path = I915_BXT_HUC_UCODE;
> + huc_fw->major_ver_wanted = 1;
> + huc_fw->minor_ver_wanted = 7;
Use version macros here when that part is ready.
-Jeff
> }
>
> if (fw_path == NULL)
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-31 20:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 0:05 [PATCH 0/7] HuC Loading Patches Anusha Srivatsa
2016-10-29 0:05 ` [PATCH 1/7] drm/i915/guc: Make the GuC fw loading helper functions general Anusha Srivatsa
2016-10-29 0:05 ` [PATCH 2/7] drm/i915/huc: Unified css_header struct for GuC and HuC Anusha Srivatsa
2016-10-31 20:02 ` Jeff McGee
2016-10-29 0:05 ` [PATCH 3/7] drm/i915/huc: Add HuC fw loading support Anusha Srivatsa
2016-10-31 20:21 ` Jeff McGee
2016-10-29 0:05 ` [PATCH 4/7] drm/i915/huc: Add debugfs for HuC loading status check Anusha Srivatsa
2016-10-29 0:05 ` [PATCH 5/7] drm/i915/huc: Support HuC authentication Anusha Srivatsa
2016-10-31 20:26 ` Jeff McGee
2016-10-29 0:05 ` [PATCH 6/7] drm/i915/huc: Add BXT HuC Loading Support Anusha Srivatsa
2016-10-31 20:29 ` Jeff McGee [this message]
2016-10-29 0:05 ` [PATCH 7/7] drm/i915/get_params: Add HuC status to getparams Anusha Srivatsa
2016-10-31 20:31 ` Jeff McGee
2016-10-29 0:46 ` ✓ Fi.CI.BAT: success for HuC Loading Patches Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031202913.GQ18646@jeffdesk \
--to=jeff.mcgee@intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=peter.antoine@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).