intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/26] drm/i915: A game of OCD dominoes
Date: Tue, 1 Nov 2016 16:47:24 +0200	[thread overview]
Message-ID: <20161101144724.GZ4617@intel.com> (raw)
In-Reply-To: <20161031205634.GA11610@nuc-i3427.alporthouse.com>

On Mon, Oct 31, 2016 at 08:56:34PM +0000, Chris Wilson wrote:
> On Mon, Oct 31, 2016 at 10:36:59PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > I pretty much just wanted to store struct intel_crtc * instead
> > of struct drm_crtc * in pipe_to_crtc_mapping[] & co. but to
> > achieve it cleanly I ended up chasing quite few different things
> > that were accepting the wrong kind of type. And once I had
> > sorted out those mappign arrays, I had ended up in the old
> > watermark code which kept me busy for another good while.
> > Eventually I was able to claw my way back to sanity and I
> > decided to stop.
> > 
> > I'm going to blame Daniel for getting me on this track by
> > suggesting that I should pass dev_priv to the plane
> > constructos. That was enough of a trigger to get me started.
> > 
> > Entire series available here:
> > git://github.com/vsyrjala/linux.git dev_priv_intel_crtc_cleanup
> > 
> > Ville Syrjälä (26):
> >   drm/i915: Pass dev_priv to plane constructors
> >   drm/i915: Pass dev_priv to skl_init_scalers()
> >   drm/i915: Pass intel_crtc to intel_crtc_active()
> >   drm/i915: Pass intel_crtc to update_wm functions
> >   drm/i915: Use struct intel_crtc in legacy platform wm code
> >   drm/i915: Store struct intel_crtc * in {pipe,plane}_to_crtc_mapping[]
> >   drm/i915: Pass dev_priv to intel_wait_for_vblank()
> >   drm/i915: Pass dev_priv to vlv force pll functions
> >   drm/i915: Pass dev_priv to g4x wm functions
> >   drm/i915: Pass dev_priv to intel_get_crtc_for_pipe()
> >   drm/i915: Always use intel_get_crtc_for_pipe()
> >   drm/i915: Pass dev_priv to intel_crtc_init()
> >   drm/i915: Pass dev_priv to cdclk update funcs
> >   drm/i915: Pass dev_priv to .get_display_clock_speed()
> >   drm/i915: Pass dev_priv to IS_MOBILE()
> >   drm/i915: Pass dev_priv to IS_PINEVIEW()
> >   drm/i915: Pass dev_priv to i915_pineview_get_mem_freq() and
> >     i915_ironlake_get_mem_freq()
> >   drm/i915: Pass dev_priv to .get_fifo_size()
> >   drm/i915: Pass dev_priv to HAS_FW_BLC
> >   drm/i915: Pass dev_priv to IS_BROADWATER/IS_CRESTLINE
> >   drm/i915: Pass dev_priv to rest of IS_FOO() macros for the old
> >     platforms
> >   drm/i915: Pass dev_priv to single_enabled_crtc()
> >   drm/i915: Pass dev_priv to init_clock_gating
> >   drm/i915: Pass dev_priv to intel_suspend_hw()
> >   drm/i915: Pass dev_priv to ilk_setup_wm_latency() & co.
> >   drm/i915: Pass dev_priv to intel_init_pm()
> 
> All looked reasonable and beguiling in their simplicty. Nice trimming.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Entire series pushed to dinq. Thanks for the review.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-11-01 14:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 20:36 [PATCH 00/26] drm/i915: A game of OCD dominoes ville.syrjala
2016-10-31 20:37 ` [PATCH 01/26] drm/i915: Pass dev_priv to plane constructors ville.syrjala
2016-10-31 20:37 ` [PATCH 02/26] drm/i915: Pass dev_priv to skl_init_scalers() ville.syrjala
2016-10-31 20:37 ` [PATCH 03/26] drm/i915: Pass intel_crtc to intel_crtc_active() ville.syrjala
2016-10-31 20:37 ` [PATCH 04/26] drm/i915: Pass intel_crtc to update_wm functions ville.syrjala
2016-10-31 20:37 ` [PATCH 05/26] drm/i915: Use struct intel_crtc in legacy platform wm code ville.syrjala
2016-10-31 20:37 ` [PATCH 06/26] drm/i915: Store struct intel_crtc * in {pipe, plane}_to_crtc_mapping[] ville.syrjala
2016-10-31 20:37 ` [PATCH 07/26] drm/i915: Pass dev_priv to intel_wait_for_vblank() ville.syrjala
2016-10-31 20:37 ` [PATCH 08/26] drm/i915: Pass dev_priv to vlv force pll functions ville.syrjala
2016-10-31 20:37 ` [PATCH 09/26] drm/i915: Pass dev_priv to g4x wm functions ville.syrjala
2016-10-31 20:37 ` [PATCH 10/26] drm/i915: Pass dev_priv to intel_get_crtc_for_pipe() ville.syrjala
2016-10-31 20:37 ` [PATCH 11/26] drm/i915: Always use intel_get_crtc_for_pipe() ville.syrjala
2016-10-31 20:37 ` [PATCH 12/26] drm/i915: Pass dev_priv to intel_crtc_init() ville.syrjala
2016-10-31 20:37 ` [PATCH 13/26] drm/i915: Pass dev_priv to cdclk update funcs ville.syrjala
2016-10-31 20:37 ` [PATCH 14/26] drm/i915: Pass dev_priv to .get_display_clock_speed() ville.syrjala
2016-10-31 20:37 ` [PATCH 15/26] drm/i915: Pass dev_priv to IS_MOBILE() ville.syrjala
2016-10-31 20:37 ` [PATCH 16/26] drm/i915: Pass dev_priv to IS_PINEVIEW() ville.syrjala
2016-10-31 20:37 ` [PATCH 17/26] drm/i915: Pass dev_priv to i915_pineview_get_mem_freq() and i915_ironlake_get_mem_freq() ville.syrjala
2016-10-31 20:37 ` [PATCH 18/26] drm/i915: Pass dev_priv to .get_fifo_size() ville.syrjala
2016-10-31 20:37 ` [PATCH 19/26] drm/i915: Pass dev_priv to HAS_FW_BLC ville.syrjala
2016-10-31 20:37 ` [PATCH 20/26] drm/i915: Pass dev_priv to IS_BROADWATER/IS_CRESTLINE ville.syrjala
2016-10-31 20:37 ` [PATCH 21/26] drm/i915: Pass dev_priv to rest of IS_FOO() macros for the old platforms ville.syrjala
2016-10-31 20:37 ` [PATCH 22/26] drm/i915: Pass dev_priv to single_enabled_crtc() ville.syrjala
2016-10-31 20:37 ` [PATCH 23/26] drm/i915: Pass dev_priv to init_clock_gating ville.syrjala
2016-10-31 20:37 ` [PATCH 24/26] drm/i915: Pass dev_priv to intel_suspend_hw() ville.syrjala
2016-10-31 20:37 ` [PATCH 25/26] drm/i915: Pass dev_priv to ilk_setup_wm_latency() & co ville.syrjala
2016-10-31 20:37 ` [PATCH 26/26] drm/i915: Pass dev_priv to intel_init_pm() ville.syrjala
2016-10-31 20:56 ` [PATCH 00/26] drm/i915: A game of OCD dominoes Chris Wilson
2016-11-01  9:45   ` Ville Syrjälä
2016-11-01 14:47   ` Ville Syrjälä [this message]
2016-10-31 21:16 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-11-01 11:34   ` Ville Syrjälä
2016-11-01 13:46 ` Patchwork
2016-11-01 13:53   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161101144724.GZ4617@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).