From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Always flush the dirty CPU cache when pinning the scanout Date: Tue, 8 Nov 2016 13:33:41 +0200 Message-ID: <20161108113341.GE4617@intel.com> References: <20161106130001.9509-1-chris@chris-wilson.co.uk> <20161106130001.9509-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 948586E4EA for ; Tue, 8 Nov 2016 11:33:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161106130001.9509-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gU3VuLCBOb3YgMDYsIDIwMTYgYXQgMDE6MDA6MDBQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEN1cnJlbnRseSB3ZSBvbmx5IGNsZmx1c2ggdGhlIHNjYW5vdXQgaWYgaXQgaXMgaW4g dGhlIENQVSBkb21haW4uIEFsc28KPiBmbHVzaCBpZiB3ZSBoYXZlIGEgcGVuZGluZyBDUFUgY2xm bHVzaC4gV2UgYWxzbyB3YW50IHRvIHRyZWF0IHRoZQo+IGRpcnR5ZmIgcGF0aCBzaW1pbGFyLCBh bmQgZmx1c2ggYW55IHBlbmRpbmcgd3JpdGVzIHRoZXJlIGFzIHdlbGwuCj4gCj4gU2lnbmVkLW9m Zi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICB8IDkgKysrKystLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDIgKysKPiAgMiBmaWxlcyBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gaW5kZXggZDQ4NTA5NzgzZTQxLi42ODQ1Y2YwMzI4N2MgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPiBAQCAtMzM1NiwxMiArMzM1NiwxMiBAQCBpbnQgaTkxNV9nZW1fb2JqZWN0 X3NldF9jYWNoZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAJCQkJ ICAgIGVudW0gaTkxNV9jYWNoZV9sZXZlbCBjYWNoZV9sZXZlbCkKPiAgewo+ICAJc3RydWN0IGk5 MTVfdm1hICp2bWE7Cj4gLQlpbnQgcmV0ID0gMDsKPiArCWludCByZXQ7Cj4gIAo+ICAJbG9ja2Rl cF9hc3NlcnRfaGVsZCgmb2JqLT5iYXNlLmRldi0+c3RydWN0X211dGV4KTsKPiAgCj4gIAlpZiAo b2JqLT5jYWNoZV9sZXZlbCA9PSBjYWNoZV9sZXZlbCkKPiAtCQlnb3RvIG91dDsKPiArCQlyZXR1 cm4gMDsKCkkgYWRkZWQgdGhpcyBmb3IgdGhlIHBpbl9kaXNwbGF5IGNhc2UsIHdoaWNoIHlvdSBu b3cgaGFuZGxlIGV4cGxpY2l0bHkuClNvIHllYWgsIGxvb2tzIGxpa2UgdGhpcyBjYW4gZ28uIEF0 IGxlYXN0IEkgY2FuJ3QgdGhpbmsgb2YgYW5vdGhlciB2YWxpZAp1c2UgY2FzZSB0byBrZWVwIGZs dXNoaW5nIG9uIGV2ZXJ5IHNldF9jYWNoZV9sZXZlbChOT05FKS4KCj4gIAo+ICAJLyogSW5zcGVj dCB0aGUgbGlzdCBvZiBjdXJyZW50bHkgYm91bmQgVk1BIGFuZCB1bmJpbmQgYW55IHRoYXQgd291 bGQKPiAgCSAqIGJlIGludmFsaWQgZ2l2ZW4gdGhlIG5ldyBjYWNoZS1sZXZlbC4gVGhpcyBpcyBw cmluY2lwYWxseSB0bwo+IEBAIC0zNDU5LDcgKzM0NTksNiBAQCBpbnQgaTkxNV9nZW1fb2JqZWN0 X3NldF9jYWNoZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAJCXZt YS0+bm9kZS5jb2xvciA9IGNhY2hlX2xldmVsOwo+ICAJb2JqLT5jYWNoZV9sZXZlbCA9IGNhY2hl X2xldmVsOwo+ICAKPiAtb3V0Ogo+ICAJLyogRmx1c2ggdGhlIGRpcnR5IENQVSBjYWNoZXMgdG8g dGhlIGJhY2tpbmcgc3RvcmFnZSBzbyB0aGF0IHRoZQo+ICAJICogb2JqZWN0IGlzIG5vdyBjb2hl cmVudCBhdCBpdHMgbmV3IGNhY2hlIGxldmVsICh3aXRoIHJlc3BlY3QKPiAgCSAqIHRvIHRoZSBh Y2Nlc3MgZG9tYWluKS4KPiBAQCAtMzYwOCw3ICszNjA3LDkgQEAgaTkxNV9nZW1fb2JqZWN0X3Bp bl90b19kaXNwbGF5X3BsYW5lKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAo+ ICAJdm1hLT5kaXNwbGF5X2FsaWdubWVudCA9IG1heF90KHU2NCwgdm1hLT5kaXNwbGF5X2FsaWdu bWVudCwgYWxpZ25tZW50KTsKPiAgCj4gLQlpOTE1X2dlbV9vYmplY3RfZmx1c2hfY3B1X3dyaXRl X2RvbWFpbihvYmopOwo+ICsJaWYgKG9iai0+Y2FjaGVfZGlydHkgfHwgb2JqLT5iYXNlLndyaXRl X2RvbWFpbiA9PSBJOTE1X0dFTV9ET01BSU5fQ1BVKQo+ICsJCWk5MTVfZ2VtX2NsZmx1c2hfb2Jq ZWN0KG9iaiwgdHJ1ZSk7Cj4gKwlpbnRlbF9mYl9vYmpfZmx1c2gob2JqLCBmYWxzZSwgT1JJR0lO X0NQVSk7CgpTbyBvbmUgc2xpZ2h0IGNoYW5nZSBpbiBiZWhhdmlvdXIgaXMgdGhhdCB3ZSB3b24n dCBjbGVhciB0aGUgd3JpdGUgZG9tYWluCmhlcmUsIGJ1dCB0aGF0J3MgZmluZSBzaW5jZSB3ZSds bCBjbGVhciBpdCBiZWxvdyBhbnl3YXkuCgpUaGUgb3RoZXIgaXMgdGhhdCB3ZSBub3cgY2FsbCBp bnRlbF9mYl9vYmpfZmx1c2goKSB1bmNvbmRpdGlvbmFsbHksCndoZXJlYXMgYmVmb3JlIHdlIG9u bHkgY2FsbGVkIGlmIHdoZW4gdGhlIGJvIHdhcyBpbiB0aGUgQ1BVIHdyaXRlCmRvbWFpbi4gSG1t LiBTaG91bGQgd2Uga2VlcCBpdCBjb25kaXRpb25hbD8KCj4gIAo+ICAJb2xkX3dyaXRlX2RvbWFp biA9IG9iai0+YmFzZS53cml0ZV9kb21haW47Cj4gIAlvbGRfcmVhZF9kb21haW5zID0gb2JqLT5i YXNlLnJlYWRfZG9tYWluczsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5k ZXggOTJhYjAxZjMzMjA4Li40NzIzM2IyNDJjOTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gQEAgLTE1Njk4LDYgKzE1Njk4LDggQEAgc3RhdGljIGludCBpbnRlbF91 c2VyX2ZyYW1lYnVmZmVyX2RpcnR5KHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICAJc3Ry dWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiA9IGludGVsX2ZiLT5vYmo7Cj4gIAo+ICAJbXV0 ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJaWYgKG9iai0+cGluX2Rpc3BsYXkgJiYg b2JqLT5jYWNoZV9kaXJ0eSkKPiArCQlpOTE1X2dlbV9jbGZsdXNoX29iamVjdChvYmosIHRydWUp Owo+ICAJaW50ZWxfZmJfb2JqX2ZsdXNoKG9iaiwgZmFsc2UsIE9SSUdJTl9ESVJUWUZCKTsKPiAg CW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAKPiAtLSAKPiAyLjEwLjIKPiAK PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=