From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH] drm/i915: remove duplicated memsets in skl_allocate_pipe_ddb() Date: Wed, 9 Nov 2016 09:38:25 -0800 Message-ID: <20161109173825.GL6536@intel.com> References: <1478625682-8955-1-git-send-email-paulo.r.zanoni@intel.com> <20161109011315.GF6536@intel.com> <87eg2lgfzq.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id B953C6E708 for ; Wed, 9 Nov 2016 17:38:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87eg2lgfzq.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: "Vetter, Daniel" , intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDksIDIwMTYgYXQgMTE6Mjc6MzdBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gV2VkLCAwOSBOb3YgMjAxNiwgTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGlu dGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBUdWUsIE5vdiAwOCwgMjAxNiBhdCAwMzoyMToyMlBNIC0w MjAwLCBQYXVsbyBaYW5vbmkgd3JvdGU6Cj4gPj4gT25lIG9mIHRoZSBtZW1zZXRzIHdhcyBhZGRl ZCBieSA1YTkyMGI4NWYyYzYgKCJkcm0vaTkxNS9nZW45OiBmaXggRERCCj4gPj4gcGFydGl0aW9u aW5nIGZvciBtdWx0aS1zY3JlZW4gY2FzZXMiKSwgYW5kIHRoZSBvdGhlciB3YXMgYWRkZWQgYnkK PiA+PiAwMWM3MmQ2YzE3ICgiZHJtL2k5MTUvZ2VuOTogZml4IEREQiBwYXJ0aXRpb25pbmcgZm9y IG11bHRpLXNjcmVlbgo+ID4+IGNhc2VzIikuIEknbSBjb25mdXNlZCBhbmQgSSdsbCBsZXQgdGhl IG1haW50YWluZXJzIGZpbmQgb3V0IHdoYXQgd2VudAo+ID4+IHdyb25nIGhlcmUuCj4gPj4gCj4g Pj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPj4gU2lnbmVkLW9m Zi1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPgo+ID4gSSB0 aGluayB0aGlzIGlzIGp1c3QgYW4gYXJ0aWZhY3Qgb2YgaGF2aW5nIHRoZSBwYXRjaCBpbiBib3Ro IC1uZXh0IGFuZAo+ID4gLWZpeGVzLiAgVGhlIGNvbnRleHQgcHJvYmFibHkgY2hhbmdlZCBsYXRl ciBpbiAtbmV4dCBjYXVzaW5nIGEgY29uZmxpY3QKPiA+IHdoZW4gdGhlIHR3byB3ZXJlIG1lcmdl ZCwgYW5kIHRoZW4gdGhlIG1lcmdlIHJlc29sdXRpb24gYWNjaWRlbnRhbGx5Cj4gPiBkdXBsaWNh dGVkIHRoaXMgaHVuay4gIFRoZSBtZXJnZSBjb21taXQgYWM0MTM5ZWQ3IGlzIHdoZXJlIHdlIHdv dW5kIHVwCj4gPiB3aXRoIHRoZSB0d28gY29waWVzOgo+IAo+IEkgZG9uJ3QgaGF2ZSB0aGF0IG1l cmdlIGNvbW1pdC4gSXMgdGhhdCBhIG5pZ2h0bHkgcmVidWlsZD8KClllYWgsIGl0J3MgcGFydCBv ZiBhIG5pZ2h0bHkgcmVidWlsZC4gIExvb2tzIGxpa2UKODIyODI1Nzc1NDUgaXMgdGhlIGVxdWl2 YWxlbnQgbm93LgoKPiBJIGRvbid0IHRoaW5rIHdlIGV2ZW4gaGF2ZSB0aGlzIGlzc3VlIGluIGFu eXdoZXJlIG90aGVyIHRoYW4KPiBuaWdodGx5LiBUaGVyZSBpc24ndCBhIGJyYW5jaCB3ZSBjb3Vs ZCBhcHBseSB0aGlzIGZpeCB0by4KClllYWgsIHRoZSBwYXRjaCBjYW4ndCBhcHBseSBhbnl3aGVy ZSBkaXJlY3RseSwgYnV0IEkgdGhvdWdodCB3ZSBjb3VsZAptYWtlIHJlcmVyZSBmb3JnZXQgaXRz IHJlc29sdXRpb24gb2YgaW50ZWxfcG0uYyBmb3IgdGhhdCBtZXJnZSBhbmQgdGhlbgpmaXggaXQg YnkgaGFuZCBzbyB0aGF0IGZ1dHVyZSBtZXJnZXMgYmVoYXZlIGNvcnJlY3RseT8KCgpNYXR0CgoK PiAKPiBCUiwKPiBKYW5pLgo+IAo+IAo+ID4KPiA+ICAgICAgICAgZGlmZiAtLWNjIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ICAgICAgICAgaW5kZXggZGIyNGY4OSxjYzllMGMw Li44OGUyOGM5Cj4gPiAgICAgICAgIC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmMKPiA+ICAgICAgICAgKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4g ICAgICAgICBAQEAgLTMzNjEsMTEgLTM0MDQsMTMgKzM0MDQsMTcgQEBAIHNrbF9hbGxvY2F0ZV9w aXBlX2RkYihzdHJ1Y3QgaW50ZWxfY3J0Ywo+ID4gICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCB0b3RhbF9kYXRhX3JhdGU7Cj4gPiAgICAgICAgICAgICAgICAgaW50IG51bV9hY3RpdmU7Cj4g PiAgICAgICAgICAgICAgICAgaW50IGlkLCBpOwo+ID4gICAgICAgICArICAgICAgIHVuc2lnbmVk IHBsYW5lX2RhdGFfcmF0ZVtJOTE1X01BWF9QTEFORVNdID0ge307Cj4gPiAgICAgICAgICsgICAg ICAgdW5zaWduZWQgcGxhbmVfeV9kYXRhX3JhdGVbSTkxNV9NQVhfUExBTkVTXSA9IHt9Owo+ID4g ICAgICAgICArIAo+ID4gICAgICAgICArICAgICAgIC8qIENsZWFyIHRoZSBwYXJ0aXRpb25pbmcg Zm9yIGRpc2FibGVkIHBsYW5lcy4gKi8KPiA+ICAgICAgICAgKyAgICAgICBtZW1zZXQoZGRiLT5w bGFuZVtwaXBlXSwgMCwgc2l6ZW9mKGRkYi0+cGxhbmVbcGlwZV0pKTsKPiA+ICAgICAgICAgKyAg ICAgICBtZW1zZXQoZGRiLT55X3BsYW5lW3BpcGVdLCAwLCBzaXplb2YoZGRiLT55X3BsYW5lW3Bp cGVdKSk7Cj4gPiAgICAgICAgICAgCj4gPiAgICAgICAgICArICAgICAgLyogQ2xlYXIgdGhlIHBh cnRpdGlvbmluZyBmb3IgZGlzYWJsZWQgcGxhbmVzLiAqLwo+ID4gICAgICAgICAgKyAgICAgIG1l bXNldChkZGItPnBsYW5lW3BpcGVdLCAwLCBzaXplb2YoZGRiLT5wbGFuZVtwaXBlXSkpOwo+ID4g ICAgICAgICAgKyAgICAgIG1lbXNldChkZGItPnlfcGxhbmVbcGlwZV0sIDAsIHNpemVvZihkZGIt PnlfcGxhbmVbcGlwZV0pKTsKPiA+ICAgICAgICAgICsKPiA+ICAgICAgICAgICAgICAgICBpZiAo V0FSTl9PTighc3RhdGUpKQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4g PiAgICAgICAgICAgCj4gPiBEcm9wcGluZyBvbmUgbG9va3MgZ29vZCB0byBtZS4KPiA+Cj4gPiBS ZXZpZXdlZC1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+Cj4g Pj4gLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCA0IC0tLS0KPiA+ PiAgMSBmaWxlIGNoYW5nZWQsIDQgZGVsZXRpb25zKC0pCj4gPj4gCj4gPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9wbS5jCj4gPj4gaW5kZXggODhlMjhjOS4uY2M5ZTBjMCAxMDA2NDQKPiA+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcG0uYwo+ID4+IEBAIC0zNDExLDEwICszNDExLDYgQEAgc2tsX2FsbG9jYXRl X3BpcGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gPj4gIAltZW1zZXQo ZGRiLT5wbGFuZVtwaXBlXSwgMCwgc2l6ZW9mKGRkYi0+cGxhbmVbcGlwZV0pKTsKPiA+PiAgCW1l bXNldChkZGItPnlfcGxhbmVbcGlwZV0sIDAsIHNpemVvZihkZGItPnlfcGxhbmVbcGlwZV0pKTsK PiA+PiAgCj4gPj4gLQkvKiBDbGVhciB0aGUgcGFydGl0aW9uaW5nIGZvciBkaXNhYmxlZCBwbGFu ZXMuICovCj4gPj4gLQltZW1zZXQoZGRiLT5wbGFuZVtwaXBlXSwgMCwgc2l6ZW9mKGRkYi0+cGxh bmVbcGlwZV0pKTsKPiA+PiAtCW1lbXNldChkZGItPnlfcGxhbmVbcGlwZV0sIDAsIHNpemVvZihk ZGItPnlfcGxhbmVbcGlwZV0pKTsKPiA+PiAtCj4gPj4gIAlpZiAoV0FSTl9PTighc3RhdGUpKQo+ ID4+ICAJCXJldHVybiAwOwo+ID4+ICAKPiA+PiAtLSAKPiA+PiAyLjcuNAo+ID4+IAo+ID4+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENl bnRlcgoKLS0gCk1hdHQgUm9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9URyBQbGF0 Zm9ybSBFbmFibGluZyAmIERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0y Nzk1Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=