From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/7] drm/i915/fbc: replace a loop with drm_atomic_get_existing_crtc_state() Date: Fri, 11 Nov 2016 20:01:17 +0200 Message-ID: <20161111180117.GR31595@intel.com> References: <1478883461-20201-1-git-send-email-paulo.r.zanoni@intel.com> <1478883461-20201-3-git-send-email-paulo.r.zanoni@intel.com> <20161111174616.GC9300@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4B6E6E954 for ; Fri, 11 Nov 2016 18:01:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161111174616.GC9300@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Paulo Zanoni , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMTEsIDIwMTYgYXQgMDU6NDY6MTZQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIEZyaSwgTm92IDExLCAyMDE2IGF0IDAyOjU3OjM2UE0gLTAyMDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IE11Y2ggc2ltcGxlci4gVGhhbmtzIHRvIFZpbGxlIGZvciBwb2ludGlu ZyB0aGlzLgo+ID4gCj4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IFJlcG9ydGVkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVs by5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9mYmMuYyB8IDE3ICsrKysrKystLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDcg aW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2ZiYy5jCj4gPiBpbmRleCBkZWQ3N2JkLi5iNTNiODg0IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2ZiYy5jCj4gPiBAQCAtMTA3MSw3ICsxMDcxLDcgQEAgdm9pZCBpbnRlbF9mYmNfY2hv b3NlX2NydGMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAlzdHJ1Y3Qg ZHJtX3BsYW5lICpwbGFuZTsKPiA+ICAJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3Rh dGU7Cj4gPiAgCWJvb2wgZmJjX2NydGNfcHJlc2VudCA9IGZhbHNlOwo+ID4gLQlpbnQgaSwgajsK PiA+ICsJaW50IGk7Cj4gPiAgCj4gPiAgCW11dGV4X2xvY2soJmZiYy0+bG9jayk7Cj4gPiAgCj4g PiBAQCAtMTA5Miw2ICsxMDkyLDcgQEAgdm9pZCBpbnRlbF9mYmNfY2hvb3NlX2NydGMoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAlmb3JfZWFjaF9wbGFuZV9pbl9zdGF0 ZShzdGF0ZSwgcGxhbmUsIHBsYW5lX3N0YXRlLCBpKSB7Cj4gPiAgCQlzdHJ1Y3QgaW50ZWxfcGxh bmVfc3RhdGUgKmludGVsX3BsYW5lX3N0YXRlID0KPiA+ICAJCQl0b19pbnRlbF9wbGFuZV9zdGF0 ZShwbGFuZV9zdGF0ZSk7Cj4gPiArCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqaW50ZWxfY3J0 Y19zdGF0ZTsKPiA+ICAKPiA+ICAJCWlmICghaW50ZWxfcGxhbmVfc3RhdGUtPmJhc2UudmlzaWJs ZSkKPiA+ICAJCQljb250aW51ZTsKPiA+IEBAIC0xMDk5LDE2ICsxMTAwLDEyIEBAIHZvaWQgaW50 ZWxfZmJjX2Nob29zZV9jcnRjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ ICAJCWlmICghaW50ZWxfZmJjX2Nhbl9jaG9vc2UodG9faW50ZWxfY3J0YyhwbGFuZV9zdGF0ZS0+ Y3J0YykpKQo+ID4gIAkJCWNvbnRpbnVlOwo+ID4gIAo+ID4gLQkJZm9yX2VhY2hfY3J0Y19pbl9z dGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaikgewo+ID4gLQkJCXN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICppbnRlbF9jcnRjX3N0YXRlID0KPiA+IC0JCQkJdG9faW50ZWxfY3J0Y19zdGF0 ZShjcnRjX3N0YXRlKTsKPiA+IC0KPiA+IC0JCQlpZiAocGxhbmVfc3RhdGUtPmNydGMgIT0gY3J0 YykKPiA+IC0JCQkJY29udGludWU7Cj4gPiArCQlpbnRlbF9jcnRjX3N0YXRlID0gdG9faW50ZWxf Y3J0Y19zdGF0ZSgKPiA+ICsJCQlkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHN0 YXRlLAo+ID4gKwkJCQkJCQkgICBwbGFuZV9zdGF0ZS0+Y3J0YykpOwo+IAo+IE15IGtub3dsZWRn ZSBvZiBhdG9taWMgYXBpIGlzIG5vdCBnb29kIGVub3VnaCB0byBzYXkgd2hldGhlciB0aGlzIGNh bgo+IHJldHVybiBOVUxMIGF0IHRoaXMgcG9pbnQuCgpJZiB0aGUgcGxhbmUgaXMgcGFydCBvZiB0 aGUgc3RhdGUsIHRoZW4gcGxhbmVfc3RhdGUtPmNydGMgd2lsbCBiZSBwYXJ0Cm9mIHRoZSBzdGF0 ZSBhcyB3ZWxsLgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+CgpKdXN0IHRvIHJlYWZmaXJtIEkgd2FudGVkIHRvIHBvaW50IG91dCB3 aGF0CmRybV9hdG9taWNfc2V0X2NydGNfZm9yX3BsYW5lKCkgZG9lcywgYnV0IGxvb2tzIGxpa2Ug dGhhdCBvbmUgd2FzCndyaXR0ZW4gd2l0aCB0aGUgYXNzdW1wdGlvbiB0aGF0IGl0IGNvdWxkIGZh aWwsIHdoaWNoIGlzIG5vdCBjb3JyZWN0CnNpbmNlIGRybV9hdG9taWNfZ2V0X3BsYW5lX3N0YXRl KCkgd2lsbCBhbHdheXMgYWRkIHRoZSBjdXJyZW50IGNydGMKdG8gdGhlIHN0YXRlLCBhbmQgZHJt X2F0b21pY19zZXRfY3J0Y19mb3JfcGxhbmUoKSB3aWxsIGFsd2F5cyBhZGQgdGhlCm5ldyBjcnRj IHRvIHRoZSBzdGF0ZS4KCmRybV9hdG9taWNfc2V0X2NydGNfZm9yX2Nvbm5lY3RvcigpIGlzIHdy aXR0ZW4gaW4gdGhlIHdheSBJIHdhcwpleHBlY3RpbmcsIHNvIEkgdGhpbmsgSSdsbCBmaXJlIG9m ZiBhIHBhdGNoIGZvcgpkcm1fYXRvbWljX3NldF9jcnRjX2Zvcl9wbGFuZSgpIHRvIGZvbGxvdyB0 aGUgc2FtZSBwYXR0ZXJuLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==