* [PATCH] drm/i915: Add execution priority boosting for mmioflips
@ 2016-11-15 9:22 Chris Wilson
2016-11-15 9:39 ` Tvrtko Ursulin
2016-11-15 9:46 ` ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2016-11-15 9:22 UTC (permalink / raw)
To: intel-gfx
Commit 6b5e90f58c56 ("drm/i915/scheduler: Boost priorities for flips")
added priority boosting for the modern atomic pageflips (and modesets),
but we should do the same for existing users of mmioflips (we don't yet
need to consider csflips as they are not used by execlists and so do not
have any support for a scheduler).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 0be9447cc31f..06d9deea1a6f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12038,6 +12038,7 @@ static void intel_mmio_flip_work_func(struct work_struct *w)
to_intel_framebuffer(crtc->base.primary->fb);
struct drm_i915_gem_object *obj = intel_fb->obj;
+ i915_gem_object_wait_priority(obj, 0, I915_PRIORITY_DISPLAY);
WARN_ON(i915_gem_object_wait(obj, 0, MAX_SCHEDULE_TIMEOUT, NULL) < 0);
intel_pipe_update_start(crtc);
--
2.10.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Add execution priority boosting for mmioflips
2016-11-15 9:22 [PATCH] drm/i915: Add execution priority boosting for mmioflips Chris Wilson
@ 2016-11-15 9:39 ` Tvrtko Ursulin
2016-11-15 9:46 ` ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-11-15 9:39 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 15/11/2016 09:22, Chris Wilson wrote:
> Commit 6b5e90f58c56 ("drm/i915/scheduler: Boost priorities for flips")
> added priority boosting for the modern atomic pageflips (and modesets),
> but we should do the same for existing users of mmioflips (we don't yet
> need to consider csflips as they are not used by execlists and so do not
> have any support for a scheduler).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 0be9447cc31f..06d9deea1a6f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12038,6 +12038,7 @@ static void intel_mmio_flip_work_func(struct work_struct *w)
> to_intel_framebuffer(crtc->base.primary->fb);
> struct drm_i915_gem_object *obj = intel_fb->obj;
>
> + i915_gem_object_wait_priority(obj, 0, I915_PRIORITY_DISPLAY);
> WARN_ON(i915_gem_object_wait(obj, 0, MAX_SCHEDULE_TIMEOUT, NULL) < 0);
>
> intel_pipe_update_start(crtc);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Add execution priority boosting for mmioflips
2016-11-15 9:22 [PATCH] drm/i915: Add execution priority boosting for mmioflips Chris Wilson
2016-11-15 9:39 ` Tvrtko Ursulin
@ 2016-11-15 9:46 ` Patchwork
2016-11-15 10:05 ` Chris Wilson
1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2016-11-15 9:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add execution priority boosting for mmioflips
URL : https://patchwork.freedesktop.org/series/15326/
State : success
== Summary ==
Series 15326v1 drm/i915: Add execution priority boosting for mmioflips
https://patchwork.freedesktop.org/api/1.0/series/15326/revisions/1/mbox/
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40
fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53
fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21
fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-snb-2520m total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
6cdc55e3a3822b1a0faff0124828816384bd04e1 drm-intel-nightly: 2016y-11m-15d-08h-13m-16s UTC integration manifest
1c3b8b5 drm/i915: Add execution priority boosting for mmioflips
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2997/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915: Add execution priority boosting for mmioflips
2016-11-15 9:46 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2016-11-15 10:05 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2016-11-15 10:05 UTC (permalink / raw)
To: intel-gfx
On Tue, Nov 15, 2016 at 09:46:40AM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Add execution priority boosting for mmioflips
> URL : https://patchwork.freedesktop.org/series/15326/
> State : success
>
> == Summary ==
>
> Series 15326v1 drm/i915: Add execution priority boosting for mmioflips
> https://patchwork.freedesktop.org/api/1.0/series/15326/revisions/1/mbox/
>
>
> fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
> fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40
> fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
> fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
> fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
> fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
> fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
> fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53
> fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
> fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
> fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
> fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
> fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21
> fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21
> fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
> fi-snb-2520m total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
> fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
Nice, simple patch. Should expose PI to more tests and so hopefully gain
some coverage from the wider CI.
Thanks for the review,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-15 10:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 9:22 [PATCH] drm/i915: Add execution priority boosting for mmioflips Chris Wilson
2016-11-15 9:39 ` Tvrtko Ursulin
2016-11-15 9:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-15 10:05 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).