From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Protect dev_priv->atomic_cdclk_freq with all the crtc locks Date: Tue, 15 Nov 2016 11:52:43 +0200 Message-ID: <20161115095243.GI31595@intel.com> References: <1479141311-11904-1-git-send-email-ville.syrjala@linux.intel.com> <1479141311-11904-3-git-send-email-ville.syrjala@linux.intel.com> <20161115090810.nrimdqzzoj2st7bn@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC5C86E572 for ; Tue, 15 Nov 2016 09:52:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161115090810.nrimdqzzoj2st7bn@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMTUsIDIwMTYgYXQgMTA6MDg6MTBBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBNb24sIE5vdiAxNCwgMjAxNiBhdCAwNjozNToxMFBNICswMjAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IEEgbW9kZXNldCBvbiBvbmUg cGlwZSBjYW4gdXBkYXRlIGRldl9wcml2LT5hdG9taWNfY2RjbGtfZnJlcSB3aXRob3V0Cj4gPiBh Y3R1YWxseSB0b3VjaGluZyB0aGUgaGFyZHdhcmUsIGluIHdoaWNoIGNhc2Ugd2Ugd29uJ3QgZm9y Y2UgYSBtb2Rlc2V0Cj4gPiBvbiBhbGwgdGhlIHBpcGVzLCBhbmQgdGh1cyB3b24ndCBsb2NrIGFu eSBvZiB0aGUgb3RoZXIgcGlwZXMgZWl0aGVyLgo+ID4gVGhhdCBtZWFucyBhIHBhcmFsbGVsIHBs YW5lIHVwZGF0ZSBvbiBhbm90aGVyIHBpcGUgY291bGQgYmUgbG9va2luZyBhdAo+ID4gYSBzdGFs ZSBkZXZfcHJpdi0+YXRvbWljX2NkY2Rsa19mcmVxIGFuZCB0aHVzIGZhaWwgdG8gbm90aWNlIHdo ZW4gdGhlCj4gPiBwbGFuZSBjb25maWd1cmF0aW9uIGlzIGludmFsaWQsIG9yIHBvdGVudGlhbGx5 IHJlamVjdCBhIHZhbGlkIHVwZGF0ZS4KPiAKPiBJdCdzIGEgYml0IGEgYmlrZXNoZWQsIGJ1dCBl dmVyeXdoZXJlIGVsc2UgaW4gYXRvbWljIHRob3NlIGtpbmRzIG9mIGRhdGEKPiBhcmUgY2FsbGVk IC0+c3RhdGUgb3Igc29tZXRoaW5nIGxpa2UgdGhhdC4gRGl2ZXJnaW5nIGFuZCBnaXZpbmcgaXQg YW4KPiBhdG9taWNfIHByZWZpeCBzZWVtcyBhIGJpdCBmdW5reS4KPiAKPiBNYXliZSB3ZSBuZWVk IGEgZGV2X3ByaXYtPnN0YXRlIHN1YnN0cnVjdCB3aGVyZSB3ZSBjb3VsZCBwdXQgYWxsIHRoZXNl Cj4gZ2xvYmFsIGF0b21pYyBiaXRzIGludG8/CgpZZWFoLCBJJ3ZlIGJlZW4gY29tcGxhaW5pbmcg YWJvdXQgdGhpcyBzdHVmZiBmb3IgcXVpdGUgYSB3aGlsZSBub3cuCkJ1dCBzbyBmYXIgSSB3YXNu J3QgYWJsZSB0byBiYWl0IE1hYXJ0ZW4gaW50byBkb2luZyB0aGUgd29yayA7KQoKPiAtRGFuaWVs Cj4gCj4gPiAKPiA+IFRvIG92ZXJjb21lIHRoaXMgd2UgbXVzdCBwcm90ZWN0IHdyaXRlcyB0byBh dG9taWNfY2RjbGtfZnJlcSB3aXRoCj4gPiBhbGwgdGhlIGNydGMgbG9ja3MsIGFuZCB0aHVzIGZv ciByZWFkcyBhbnkgc2luZ2xlIGNydGMgbG9jayB3aWxsCj4gPiBiZSBzdWZmaWNpZW50IHByb3Rl Y3Rpb24uCj4gPiAKPiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmggICAgICB8ICA5ICsrKysrKystCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIHwgNDEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+IGluZGV4IGMwZjFkZmM3MTE5ZS4u NjZkMjk1MGRjNjU3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gQEAgLTE4 NzQsNyArMTg3NCwxNCBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSB7Cj4gPiAgCj4gPiAgCXVu c2lnbmVkIGludCBmc2JfZnJlcSwgbWVtX2ZyZXEsIGlzX2RkcjM7Cj4gPiAgCXVuc2lnbmVkIGlu dCBza2xfcHJlZmVycmVkX3Zjb19mcmVxOwo+ID4gLQl1bnNpZ25lZCBpbnQgY2RjbGtfZnJlcSwg bWF4X2NkY2xrX2ZyZXEsIGF0b21pY19jZGNsa19mcmVxOwo+ID4gKwl1bnNpZ25lZCBpbnQgY2Rj bGtfZnJlcSwgbWF4X2NkY2xrX2ZyZXE7Cj4gPiArCj4gPiArCS8qCj4gPiArCSAqIEZvciByZWFk aW5nIGhvbGRpbmcgYW55IGNydGMgbG9jayBpcyBzdWZmaWNpZW50LAo+ID4gKwkgKiBmb3Igd3Jp dGluZyBtdXN0IGhvbGQgYWxsIG9mIHRoZW0uCj4gPiArCSAqLwo+ID4gKwl1bnNpZ25lZCBpbnQg YXRvbWljX2NkY2xrX2ZyZXE7Cj4gPiArCj4gPiAgCXVuc2lnbmVkIGludCBtYXhfZG90Y2xrX2Zy ZXE7Cj4gPiAgCXVuc2lnbmVkIGludCByYXdjbGtfZnJlcTsKPiA+ICAJdW5zaWduZWQgaW50IGhw bGxfZnJlcTsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IDcw ZjNmMGI3MDI2My4uZDdhNGJjNjNiMDViIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiA+IEBAIC0xMzk0NiwxMyArMTM5NDYsMzIgQEAgc3RhdGljIGludCBoYXN3 ZWxsX21vZGVfc2V0X3BsYW5lc193b3JrYXJvdW5kKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpz dGF0ZSkKPiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBpbnQgaW50ZWxf bG9ja19hbGxfcGlwZXMoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gK3sKPiA+ ICsJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4gKwo+ID4gKwkvKiBBZGQgYWxsIHBpcGVzIHRv IHRoZSBzdGF0ZSAqLwo+ID4gKwlmb3JfZWFjaF9jcnRjKHN0YXRlLT5kZXYsIGNydGMpIHsKPiA+ ICsJCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiA+ICsKPiA+ICsJCWNydGNf c3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPiA+ICsJCWlm IChJU19FUlIoY3J0Y19zdGF0ZSkpCj4gPiArCQkJcmV0dXJuIFBUUl9FUlIoY3J0Y19zdGF0ZSk7 Cj4gPiArCX0KPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBp bnQgaW50ZWxfbW9kZXNldF9hbGxfcGlwZXMoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRl KQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4gIAlzdHJ1Y3QgZHJtX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPiAgCWludCByZXQgPSAwOwo+ID4gIAo+ID4gLQkvKiBh ZGQgYWxsIGFjdGl2ZSBwaXBlcyB0byB0aGUgc3RhdGUgKi8KPiA+ICsJLyoKPiA+ICsJICogQWRk IGFsbCBwaXBlcyB0byB0aGUgc3RhdGUsIGFuZCBmb3JjZQo+ID4gKwkgKiBhIG1vZGVzZXQgb24g YWxsIHRoZSBhY3RpdmUgb25lcy4KPiA+ICsJICovCj4gPiAgCWZvcl9lYWNoX2NydGMoc3RhdGUt PmRldiwgY3J0Yykgewo+ID4gIAkJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2NydGNfc3Rh dGUoc3RhdGUsIGNydGMpOwo+ID4gIAkJaWYgKElTX0VSUihjcnRjX3N0YXRlKSkKPiA+IEBAIC0x NDAxOCwxMiArMTQwMzcsMjQgQEAgc3RhdGljIGludCBpbnRlbF9tb2Rlc2V0X2NoZWNrcyhzdHJ1 Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgCQlpZiAocmV0IDwgMCkKPiA+ICAJCQly ZXR1cm4gcmV0Owo+ID4gIAo+ID4gKwkJLyoKPiA+ICsJCSAqIFdyaXRlcyB0byBkZXZfcHJpdi0+ YXRvbWljX2NkY2xrX2ZyZXEgbXVzdCBwcm90ZWN0ZWQgYnkKPiA+ICsJCSAqIGhvbGRpbmcgYWxs IHRoZSBjcnRjIGxvY2tzLCBldmVuIGlmIHdlIGRvbid0IGVuZCB1cAo+ID4gKwkJICogdG91Y2hp bmcgdGhlIGhhcmR3YXJlCj4gPiArCQkgKi8KPiA+ICsJCWlmIChpbnRlbF9zdGF0ZS0+Y2RjbGsg IT0gZGV2X3ByaXYtPmF0b21pY19jZGNsa19mcmVxKSB7Cj4gPiArCQkJcmV0ID0gaW50ZWxfbG9j a19hbGxfcGlwZXMoc3RhdGUpOwo+ID4gKwkJCWlmIChyZXQgPCAwKQo+ID4gKwkJCQlyZXR1cm4g cmV0Owo+ID4gKwkJfQo+ID4gKwo+ID4gKwkJLyogQWxsIHBpcGVzIG11c3QgYmUgc3dpdGNoZWQg b2ZmIHdoaWxlIHdlIGNoYW5nZSB0aGUgY2RjbGsuICovCj4gPiAgCQlpZiAoaW50ZWxfc3RhdGUt PmRldl9jZGNsayAhPSBkZXZfcHJpdi0+Y2RjbGtfZnJlcSB8fAo+ID4gLQkJICAgIGludGVsX3N0 YXRlLT5jZGNsa19wbGxfdmNvICE9IGRldl9wcml2LT5jZGNsa19wbGwudmNvKQo+ID4gKwkJICAg IGludGVsX3N0YXRlLT5jZGNsa19wbGxfdmNvICE9IGRldl9wcml2LT5jZGNsa19wbGwudmNvKSB7 Cj4gPiAgCQkJcmV0ID0gaW50ZWxfbW9kZXNldF9hbGxfcGlwZXMoc3RhdGUpOwo+ID4gLQo+ID4g LQkJaWYgKHJldCA8IDApCj4gPiAtCQkJcmV0dXJuIHJldDsKPiA+ICsJCQlpZiAocmV0IDwgMCkK PiA+ICsJCQkJcmV0dXJuIHJldDsKPiA+ICsJCX0KPiA+ICAKPiA+ICAJCURSTV9ERUJVR19LTVMo Ik5ldyBjZGNsayBjYWxjdWxhdGVkIHRvIGJlIGF0b21pYyAldSwgYWN0dWFsICV1XG4iLAo+ID4g IAkJCSAgICAgIGludGVsX3N0YXRlLT5jZGNsaywgaW50ZWxfc3RhdGUtPmRldl9jZGNsayk7Cj4g PiAtLSAKPiA+IDIuNy40Cj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAoK LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==