From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Protect dev_priv->atomic_cdclk_freq with all the crtc locks Date: Tue, 15 Nov 2016 15:41:27 +0200 Message-ID: <20161115134127.GJ31595@intel.com> References: <1479141311-11904-1-git-send-email-ville.syrjala@linux.intel.com> <1479141311-11904-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (unknown [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A01046E59B for ; Tue, 15 Nov 2016 13:43:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMTUsIDIwMTYgYXQgMTE6MTQ6MjlBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTQtMTEtMTYgb20gMTc6MzUgc2NocmVlZiB2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4gPgo+ID4gQSBtb2Rlc2V0IG9uIG9uZSBwaXBlIGNhbiB1cGRhdGUg ZGV2X3ByaXYtPmF0b21pY19jZGNsa19mcmVxIHdpdGhvdXQKPiA+IGFjdHVhbGx5IHRvdWNoaW5n IHRoZSBoYXJkd2FyZSwgaW4gd2hpY2ggY2FzZSB3ZSB3b24ndCBmb3JjZSBhIG1vZGVzZXQKPiA+ IG9uIGFsbCB0aGUgcGlwZXMsIGFuZCB0aHVzIHdvbid0IGxvY2sgYW55IG9mIHRoZSBvdGhlciBw aXBlcyBlaXRoZXIuCj4gPiBUaGF0IG1lYW5zIGEgcGFyYWxsZWwgcGxhbmUgdXBkYXRlIG9uIGFu b3RoZXIgcGlwZSBjb3VsZCBiZSBsb29raW5nIGF0Cj4gPiBhIHN0YWxlIGRldl9wcml2LT5hdG9t aWNfY2RjZGxrX2ZyZXEgYW5kIHRodXMgZmFpbCB0byBub3RpY2Ugd2hlbiB0aGUKPiA+IHBsYW5l IGNvbmZpZ3VyYXRpb24gaXMgaW52YWxpZCwgb3IgcG90ZW50aWFsbHkgcmVqZWN0IGEgdmFsaWQg dXBkYXRlLgo+ID4KPiA+IFRvIG92ZXJjb21lIHRoaXMgd2UgbXVzdCBwcm90ZWN0IHdyaXRlcyB0 byBhdG9taWNfY2RjbGtfZnJlcSB3aXRoCj4gPiBhbGwgdGhlIGNydGMgbG9ja3MsIGFuZCB0aHVz IGZvciByZWFkcyBhbnkgc2luZ2xlIGNydGMgbG9jayB3aWxsCj4gPiBiZSBzdWZmaWNpZW50IHBy b3RlY3Rpb24uCj4gPgo+ID4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3Jz dEBsaW51eC5pbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCAgICAgIHwgIDkgKysrKysrKy0KPiA+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z KC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBpbmRleCBjMGYxZGZjNzExOWUu LjY2ZDI5NTBkYzY1NyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+IEBAIC0x ODc0LDcgKzE4NzQsMTQgQEAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgewo+ID4gIAo+ID4gIAl1 bnNpZ25lZCBpbnQgZnNiX2ZyZXEsIG1lbV9mcmVxLCBpc19kZHIzOwo+ID4gIAl1bnNpZ25lZCBp bnQgc2tsX3ByZWZlcnJlZF92Y29fZnJlcTsKPiA+IC0JdW5zaWduZWQgaW50IGNkY2xrX2ZyZXEs IG1heF9jZGNsa19mcmVxLCBhdG9taWNfY2RjbGtfZnJlcTsKPiA+ICsJdW5zaWduZWQgaW50IGNk Y2xrX2ZyZXEsIG1heF9jZGNsa19mcmVxOwo+ID4gKwo+ID4gKwkvKgo+ID4gKwkgKiBGb3IgcmVh ZGluZyBob2xkaW5nIGFueSBjcnRjIGxvY2sgaXMgc3VmZmljaWVudCwKPiA+ICsJICogZm9yIHdy aXRpbmcgbXVzdCBob2xkIGFsbCBvZiB0aGVtLgo+ID4gKwkgKi8KPiA+ICsJdW5zaWduZWQgaW50 IGF0b21pY19jZGNsa19mcmVxOwo+ID4gKwo+ID4gIAl1bnNpZ25lZCBpbnQgbWF4X2RvdGNsa19m cmVxOwo+ID4gIAl1bnNpZ25lZCBpbnQgcmF3Y2xrX2ZyZXE7Cj4gPiAgCXVuc2lnbmVkIGludCBo cGxsX2ZyZXE7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA3 MGYzZjBiNzAyNjMuLmQ3YTRiYzYzYjA1YiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTM5NDYsMTMgKzEzOTQ2LDMyIEBAIHN0YXRpYyBpbnQgaGFz d2VsbF9tb2RlX3NldF9wbGFuZXNfd29ya2Fyb3VuZChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGUpCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgaW50IGludGVs X2xvY2tfYWxsX3BpcGVzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICt7Cj4g PiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ICsKPiA+ICsJLyogQWRkIGFsbCBwaXBlcyB0 byB0aGUgc3RhdGUgKi8KPiA+ICsJZm9yX2VhY2hfY3J0YyhzdGF0ZS0+ZGV2LCBjcnRjKSB7Cj4g PiArCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPiArCj4gPiArCQljcnRj X3N0YXRlID0gZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gPiArCQlp ZiAoSVNfRVJSKGNydGNfc3RhdGUpKQo+ID4gKwkJCXJldHVybiBQVFJfRVJSKGNydGNfc3RhdGUp Owo+ID4gKwl9Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMg aW50IGludGVsX21vZGVzZXRfYWxsX3BpcGVzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZSkKPiA+ICB7Cj4gPiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ICAJc3RydWN0IGRybV9j cnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ID4gIAlpbnQgcmV0ID0gMDsKPiA+ICAKPiA+IC0JLyog YWRkIGFsbCBhY3RpdmUgcGlwZXMgdG8gdGhlIHN0YXRlICovCj4gPiArCS8qCj4gPiArCSAqIEFk ZCBhbGwgcGlwZXMgdG8gdGhlIHN0YXRlLCBhbmQgZm9yY2UKPiA+ICsJICogYSBtb2Rlc2V0IG9u IGFsbCB0aGUgYWN0aXZlIG9uZXMuCj4gPiArCSAqLwo+ID4gIAlmb3JfZWFjaF9jcnRjKHN0YXRl LT5kZXYsIGNydGMpIHsKPiA+ICAJCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRjX3N0 YXRlKHN0YXRlLCBjcnRjKTsKPiA+ICAJCWlmIChJU19FUlIoY3J0Y19zdGF0ZSkpCj4gPiBAQCAt MTQwMTgsMTIgKzE0MDM3LDI0IEBAIHN0YXRpYyBpbnQgaW50ZWxfbW9kZXNldF9jaGVja3Moc3Ry dWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gIAkJaWYgKHJldCA8IDApCj4gPiAgCQkJ cmV0dXJuIHJldDsKPiA+ICAKPiA+ICsJCS8qCj4gPiArCQkgKiBXcml0ZXMgdG8gZGV2X3ByaXYt PmF0b21pY19jZGNsa19mcmVxIG11c3QgcHJvdGVjdGVkIGJ5Cj4gPiArCQkgKiBob2xkaW5nIGFs bCB0aGUgY3J0YyBsb2NrcywgZXZlbiBpZiB3ZSBkb24ndCBlbmQgdXAKPiA+ICsJCSAqIHRvdWNo aW5nIHRoZSBoYXJkd2FyZQo+ID4gKwkJICovCj4gPiArCQlpZiAoaW50ZWxfc3RhdGUtPmNkY2xr ICE9IGRldl9wcml2LT5hdG9taWNfY2RjbGtfZnJlcSkgewo+ID4gKwkJCXJldCA9IGludGVsX2xv Y2tfYWxsX3BpcGVzKHN0YXRlKTsKPiA+ICsJCQlpZiAocmV0IDwgMCkKPiA+ICsJCQkJcmV0dXJu IHJldDsKPiA+ICsJCX0KPiA+ICsKPiBXb3VsZCBpdCBiZSB0ZXJyaWJsZSB0byBqdXN0IHVzZSBp bnRlbF9tb2Rlc2V0X2FsbF9waXBlcyBoZXJlPyBTaW5jZSB0aGlzIGNhbiBvbmx5IGJlIGRpZmZl cmVudCBpbiB0aGUgYWxsIGNydGMncyBkaXNhYmxlZCBjYXNlCj4gaXQgd29uJ3QgbWF0dGVyIG11 Y2guCgpJcyB0aGVyZSBhbnkgYmVuZWZpdCBpbiBkb2luZyB0aGF0PyBBIGJpdCBjb25mdXNpbmcg SU1PIHRvIGZvcmNlIGEKbW9kZXNldCB3aGVuIHlvdSBkb24ndCBoYXZlIHRvLgoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==