From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Protect dev_priv->atomic_cdclk_freq with all the crtc locks Date: Thu, 17 Nov 2016 17:06:51 +0200 Message-ID: <20161117150651.GX31595@intel.com> References: <1479141311-11904-1-git-send-email-ville.syrjala@linux.intel.com> <1479141311-11904-3-git-send-email-ville.syrjala@linux.intel.com> <20161115134127.GJ31595@intel.com> <9a7aed68-2228-c0f1-2661-ae81daa6155f@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D61BD6E318 for ; Thu, 17 Nov 2016 15:06:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <9a7aed68-2228-c0f1-2661-ae81daa6155f@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMTUsIDIwMTYgYXQgMDI6NTM6MDBQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTUtMTEtMTYgb20gMTQ6NDEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBUdWUsIE5vdiAxNSwgMjAxNiBhdCAxMToxNDoyOUFNICswMTAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBPcCAxNC0xMS0xNiBvbSAxNzozNSBzY2hyZWVmIHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tOgo+ID4+PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4+Pgo+ID4+PiBBIG1vZGVzZXQgb24gb25lIHBp cGUgY2FuIHVwZGF0ZSBkZXZfcHJpdi0+YXRvbWljX2NkY2xrX2ZyZXEgd2l0aG91dAo+ID4+PiBh Y3R1YWxseSB0b3VjaGluZyB0aGUgaGFyZHdhcmUsIGluIHdoaWNoIGNhc2Ugd2Ugd29uJ3QgZm9y Y2UgYSBtb2Rlc2V0Cj4gPj4+IG9uIGFsbCB0aGUgcGlwZXMsIGFuZCB0aHVzIHdvbid0IGxvY2sg YW55IG9mIHRoZSBvdGhlciBwaXBlcyBlaXRoZXIuCj4gPj4+IFRoYXQgbWVhbnMgYSBwYXJhbGxl bCBwbGFuZSB1cGRhdGUgb24gYW5vdGhlciBwaXBlIGNvdWxkIGJlIGxvb2tpbmcgYXQKPiA+Pj4g YSBzdGFsZSBkZXZfcHJpdi0+YXRvbWljX2NkY2Rsa19mcmVxIGFuZCB0aHVzIGZhaWwgdG8gbm90 aWNlIHdoZW4gdGhlCj4gPj4+IHBsYW5lIGNvbmZpZ3VyYXRpb24gaXMgaW52YWxpZCwgb3IgcG90 ZW50aWFsbHkgcmVqZWN0IGEgdmFsaWQgdXBkYXRlLgo+ID4+Pgo+ID4+PiBUbyBvdmVyY29tZSB0 aGlzIHdlIG11c3QgcHJvdGVjdCB3cml0ZXMgdG8gYXRvbWljX2NkY2xrX2ZyZXEgd2l0aAo+ID4+ PiBhbGwgdGhlIGNydGMgbG9ja3MsIGFuZCB0aHVzIGZvciByZWFkcyBhbnkgc2luZ2xlIGNydGMg bG9jayB3aWxsCj4gPj4+IGJlIHN1ZmZpY2llbnQgcHJvdGVjdGlvbi4KPiA+Pj4KPiA+Pj4gQ2M6 IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4g Pj4+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gPj4+IC0tLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aCAgICAgIHwgIDkgKysrKysrKy0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyB8IDQxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4+PiAg MiBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4+Pgo+ ID4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+Pj4gaW5kZXggYzBmMWRmYzcxMTllLi42NmQy OTUwZGM2NTcgMTAwNjQ0Cj4gPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPiA+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4+PiBAQCAt MTg3NCw3ICsxODc0LDE0IEBAIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlIHsKPiA+Pj4gIAo+ID4+ PiAgCXVuc2lnbmVkIGludCBmc2JfZnJlcSwgbWVtX2ZyZXEsIGlzX2RkcjM7Cj4gPj4+ICAJdW5z aWduZWQgaW50IHNrbF9wcmVmZXJyZWRfdmNvX2ZyZXE7Cj4gPj4+IC0JdW5zaWduZWQgaW50IGNk Y2xrX2ZyZXEsIG1heF9jZGNsa19mcmVxLCBhdG9taWNfY2RjbGtfZnJlcTsKPiA+Pj4gKwl1bnNp Z25lZCBpbnQgY2RjbGtfZnJlcSwgbWF4X2NkY2xrX2ZyZXE7Cj4gPj4+ICsKPiA+Pj4gKwkvKgo+ ID4+PiArCSAqIEZvciByZWFkaW5nIGhvbGRpbmcgYW55IGNydGMgbG9jayBpcyBzdWZmaWNpZW50 LAo+ID4+PiArCSAqIGZvciB3cml0aW5nIG11c3QgaG9sZCBhbGwgb2YgdGhlbS4KPiA+Pj4gKwkg Ki8KPiA+Pj4gKwl1bnNpZ25lZCBpbnQgYXRvbWljX2NkY2xrX2ZyZXE7Cj4gPj4+ICsKPiA+Pj4g IAl1bnNpZ25lZCBpbnQgbWF4X2RvdGNsa19mcmVxOwo+ID4+PiAgCXVuc2lnbmVkIGludCByYXdj bGtfZnJlcTsKPiA+Pj4gIAl1bnNpZ25lZCBpbnQgaHBsbF9mcmVxOwo+ID4+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4+IGluZGV4IDcwZjNmMGI3MDI2My4uZDdhNGJjNjNi MDViIDEwMDY0NAo+ID4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4+ IEBAIC0xMzk0NiwxMyArMTM5NDYsMzIgQEAgc3RhdGljIGludCBoYXN3ZWxsX21vZGVfc2V0X3Bs YW5lc193b3JrYXJvdW5kKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+Pj4gIAly ZXR1cm4gMDsKPiA+Pj4gIH0KPiA+Pj4gIAo+ID4+PiArc3RhdGljIGludCBpbnRlbF9sb2NrX2Fs bF9waXBlcyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPj4+ICt7Cj4gPj4+ICsJ c3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4+PiArCj4gPj4+ICsJLyogQWRkIGFsbCBwaXBlcyB0 byB0aGUgc3RhdGUgKi8KPiA+Pj4gKwlmb3JfZWFjaF9jcnRjKHN0YXRlLT5kZXYsIGNydGMpIHsK PiA+Pj4gKwkJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ID4+PiArCj4gPj4+ ICsJCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsK PiA+Pj4gKwkJaWYgKElTX0VSUihjcnRjX3N0YXRlKSkKPiA+Pj4gKwkJCXJldHVybiBQVFJfRVJS KGNydGNfc3RhdGUpOwo+ID4+PiArCX0KPiA+Pj4gKwo+ID4+PiArCXJldHVybiAwOwo+ID4+PiAr fQo+ID4+PiArCj4gPj4+ICBzdGF0aWMgaW50IGludGVsX21vZGVzZXRfYWxsX3BpcGVzKHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+Pj4gIHsKPiA+Pj4gIAlzdHJ1Y3QgZHJtX2Ny dGMgKmNydGM7Cj4gPj4+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ID4+ PiAgCWludCByZXQgPSAwOwo+ID4+PiAgCj4gPj4+IC0JLyogYWRkIGFsbCBhY3RpdmUgcGlwZXMg dG8gdGhlIHN0YXRlICovCj4gPj4+ICsJLyoKPiA+Pj4gKwkgKiBBZGQgYWxsIHBpcGVzIHRvIHRo ZSBzdGF0ZSwgYW5kIGZvcmNlCj4gPj4+ICsJICogYSBtb2Rlc2V0IG9uIGFsbCB0aGUgYWN0aXZl IG9uZXMuCj4gPj4+ICsJICovCj4gPj4+ICAJZm9yX2VhY2hfY3J0YyhzdGF0ZS0+ZGV2LCBjcnRj KSB7Cj4gPj4+ICAJCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRl LCBjcnRjKTsKPiA+Pj4gIAkJaWYgKElTX0VSUihjcnRjX3N0YXRlKSkKPiA+Pj4gQEAgLTE0MDE4 LDEyICsxNDAzNywyNCBAQCBzdGF0aWMgaW50IGludGVsX21vZGVzZXRfY2hlY2tzKHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+Pj4gIAkJaWYgKHJldCA8IDApCj4gPj4+ICAJCQly ZXR1cm4gcmV0Owo+ID4+PiAgCj4gPj4+ICsJCS8qCj4gPj4+ICsJCSAqIFdyaXRlcyB0byBkZXZf cHJpdi0+YXRvbWljX2NkY2xrX2ZyZXEgbXVzdCBwcm90ZWN0ZWQgYnkKPiA+Pj4gKwkJICogaG9s ZGluZyBhbGwgdGhlIGNydGMgbG9ja3MsIGV2ZW4gaWYgd2UgZG9uJ3QgZW5kIHVwCj4gPj4+ICsJ CSAqIHRvdWNoaW5nIHRoZSBoYXJkd2FyZQo+ID4+PiArCQkgKi8KPiA+Pj4gKwkJaWYgKGludGVs X3N0YXRlLT5jZGNsayAhPSBkZXZfcHJpdi0+YXRvbWljX2NkY2xrX2ZyZXEpIHsKPiA+Pj4gKwkJ CXJldCA9IGludGVsX2xvY2tfYWxsX3BpcGVzKHN0YXRlKTsKPiA+Pj4gKwkJCWlmIChyZXQgPCAw KQo+ID4+PiArCQkJCXJldHVybiByZXQ7Cj4gPj4+ICsJCX0KPiA+Pj4gKwo+ID4+IFdvdWxkIGl0 IGJlIHRlcnJpYmxlIHRvIGp1c3QgdXNlIGludGVsX21vZGVzZXRfYWxsX3BpcGVzIGhlcmU/IFNp bmNlIHRoaXMgY2FuIG9ubHkgYmUgZGlmZmVyZW50IGluIHRoZSBhbGwgY3J0YydzIGRpc2FibGVk IGNhc2UKPiA+PiBpdCB3b24ndCBtYXR0ZXIgbXVjaC4KPiA+IElzIHRoZXJlIGFueSBiZW5lZml0 IGluIGRvaW5nIHRoYXQ/IEEgYml0IGNvbmZ1c2luZyBJTU8gdG8gZm9yY2UgYQo+ID4gbW9kZXNl dCB3aGVuIHlvdSBkb24ndCBoYXZlIHRvLgo+ID4KPiBUaGUgY2FzZSB3aGVyZSBhdG9taWMgY2Rj bGsgY2hhbmdlcywgYnV0IGRldl9jZGNsayBzdGF5cyB0aGUgc2FtZSBjYW4gb25seSBoYXBwZW4K PiBpZiB5b3UgY29uZmlndXJlIGEgY3J0YywgYnV0IGFsbCBjcnRjJ3Mgc3RheSAhYWN0aXZlLiBJ biBhbGwgb3RoZXIgY2FzZXMgZGV2X2NkY2xrCj4gd2lsbCBjaGFuZ2UgdG9vLgo+IAo+IGludGVs X21vZGVzZXRfYWxsX3BpcGVzIHdpbGwgb25seSBzZXQgbW9kZV9jaGFuZ2VkIG9uIGFjdGl2ZSBj cnRjJ3MsIGJ1dCBpdCB3aWxsCj4gYWRkIGFsbCBjcnRjJ3MgdG8gdGhlIGF0b21pYyBzdGF0ZSBy ZWdhcmRsZXNzIHRvIG1ha2Ugc3VyZSB0aGUgY2RjbGsgc3RheXMgY29uc2lzdGVudC4KCkkgc3Rp bGwgZG9uJ3Qgc2VlIHdoYXQgdGhlIGJlbmVmaXQgaXMuIElNTyBpdCdzIGp1c3QgY29uZnVzaW5n IHRvIHNheQp0aGF0IHdlJ3JlIGdvaW5nIHRvIGZvcmNlIGEgbW9kZXNldCBvbiBhIGRpc2FibGVk IHBpcGUuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK