From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Protect dev_priv->atomic_cdclk_freq with all the crtc locks Date: Fri, 18 Nov 2016 14:27:04 +0200 Message-ID: <20161118122704.GI31595@intel.com> References: <1479141311-11904-1-git-send-email-ville.syrjala@linux.intel.com> <1479141311-11904-3-git-send-email-ville.syrjala@linux.intel.com> <20161115134127.GJ31595@intel.com> <9a7aed68-2228-c0f1-2661-ae81daa6155f@linux.intel.com> <20161117150651.GX31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9325F6E0F4 for ; Fri, 18 Nov 2016 12:27:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMTgsIDIwMTYgYXQgMTE6MjY6MThBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTctMTEtMTYgb20gMTY6MDYgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBUdWUsIE5vdiAxNSwgMjAxNiBhdCAwMjo1MzowMFBNICswMTAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBPcCAxNS0xMS0xNiBvbSAxNDo0MSBzY2hyZWVmIFZpbGxlIFN5 cmrDpGzDpDoKPiA+Pj4gT24gVHVlLCBOb3YgMTUsIDIwMTYgYXQgMTE6MTQ6MjlBTSArMDEwMCwg TWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+PiBPcCAxNC0xMS0xNiBvbSAxNzozNSBzY2hy ZWVmIHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tOgo+ID4+Pj4+IEZyb206IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4+Pj4KPiA+Pj4+PiBB IG1vZGVzZXQgb24gb25lIHBpcGUgY2FuIHVwZGF0ZSBkZXZfcHJpdi0+YXRvbWljX2NkY2xrX2Zy ZXEgd2l0aG91dAo+ID4+Pj4+IGFjdHVhbGx5IHRvdWNoaW5nIHRoZSBoYXJkd2FyZSwgaW4gd2hp Y2ggY2FzZSB3ZSB3b24ndCBmb3JjZSBhIG1vZGVzZXQKPiA+Pj4+PiBvbiBhbGwgdGhlIHBpcGVz LCBhbmQgdGh1cyB3b24ndCBsb2NrIGFueSBvZiB0aGUgb3RoZXIgcGlwZXMgZWl0aGVyLgo+ID4+ Pj4+IFRoYXQgbWVhbnMgYSBwYXJhbGxlbCBwbGFuZSB1cGRhdGUgb24gYW5vdGhlciBwaXBlIGNv dWxkIGJlIGxvb2tpbmcgYXQKPiA+Pj4+PiBhIHN0YWxlIGRldl9wcml2LT5hdG9taWNfY2RjZGxr X2ZyZXEgYW5kIHRodXMgZmFpbCB0byBub3RpY2Ugd2hlbiB0aGUKPiA+Pj4+PiBwbGFuZSBjb25m aWd1cmF0aW9uIGlzIGludmFsaWQsIG9yIHBvdGVudGlhbGx5IHJlamVjdCBhIHZhbGlkIHVwZGF0 ZS4KPiA+Pj4+Pgo+ID4+Pj4+IFRvIG92ZXJjb21lIHRoaXMgd2UgbXVzdCBwcm90ZWN0IHdyaXRl cyB0byBhdG9taWNfY2RjbGtfZnJlcSB3aXRoCj4gPj4+Pj4gYWxsIHRoZSBjcnRjIGxvY2tzLCBh bmQgdGh1cyBmb3IgcmVhZHMgYW55IHNpbmdsZSBjcnRjIGxvY2sgd2lsbAo+ID4+Pj4+IGJlIHN1 ZmZpY2llbnQgcHJvdGVjdGlvbi4KPiA+Pj4+Pgo+ID4+Pj4+IENjOiBNYWFydGVuIExhbmtob3Jz dCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4+Pj4+IFNpZ25lZC1vZmYt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4+ Pj4gLS0tCj4gPj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8ICA5 ICsrKysrKystCj4gPj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8 IDQxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4+Pj4+ICAyIGZpbGVz IGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gPj4+Pj4KPiA+Pj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+Pj4+PiBpbmRleCBjMGYxZGZjNzExOWUuLjY2ZDI5 NTBkYzY1NyAxMDA2NDQKPiA+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oCj4gPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4+Pj4+ IEBAIC0xODc0LDcgKzE4NzQsMTQgQEAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgewo+ID4+Pj4+ ICAKPiA+Pj4+PiAgCXVuc2lnbmVkIGludCBmc2JfZnJlcSwgbWVtX2ZyZXEsIGlzX2RkcjM7Cj4g Pj4+Pj4gIAl1bnNpZ25lZCBpbnQgc2tsX3ByZWZlcnJlZF92Y29fZnJlcTsKPiA+Pj4+PiAtCXVu c2lnbmVkIGludCBjZGNsa19mcmVxLCBtYXhfY2RjbGtfZnJlcSwgYXRvbWljX2NkY2xrX2ZyZXE7 Cj4gPj4+Pj4gKwl1bnNpZ25lZCBpbnQgY2RjbGtfZnJlcSwgbWF4X2NkY2xrX2ZyZXE7Cj4gPj4+ Pj4gKwo+ID4+Pj4+ICsJLyoKPiA+Pj4+PiArCSAqIEZvciByZWFkaW5nIGhvbGRpbmcgYW55IGNy dGMgbG9jayBpcyBzdWZmaWNpZW50LAo+ID4+Pj4+ICsJICogZm9yIHdyaXRpbmcgbXVzdCBob2xk IGFsbCBvZiB0aGVtLgo+ID4+Pj4+ICsJICovCj4gPj4+Pj4gKwl1bnNpZ25lZCBpbnQgYXRvbWlj X2NkY2xrX2ZyZXE7Cj4gPj4+Pj4gKwo+ID4+Pj4+ICAJdW5zaWduZWQgaW50IG1heF9kb3RjbGtf ZnJlcTsKPiA+Pj4+PiAgCXVuc2lnbmVkIGludCByYXdjbGtfZnJlcTsKPiA+Pj4+PiAgCXVuc2ln bmVkIGludCBocGxsX2ZyZXE7Cj4gPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ID4+Pj4+IGluZGV4IDcwZjNmMGI3MDI2My4uZDdhNGJjNjNiMDViIDEwMDY0NAo+ID4+Pj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+Pj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+Pj4+IEBAIC0xMzk0Niwx MyArMTM5NDYsMzIgQEAgc3RhdGljIGludCBoYXN3ZWxsX21vZGVfc2V0X3BsYW5lc193b3JrYXJv dW5kKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+Pj4+PiAgCXJldHVybiAwOwo+ ID4+Pj4+ICB9Cj4gPj4+Pj4gIAo+ID4+Pj4+ICtzdGF0aWMgaW50IGludGVsX2xvY2tfYWxsX3Bp cGVzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+Pj4+PiArewo+ID4+Pj4+ICsJ c3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4+Pj4+ICsKPiA+Pj4+PiArCS8qIEFkZCBhbGwgcGlw ZXMgdG8gdGhlIHN0YXRlICovCj4gPj4+Pj4gKwlmb3JfZWFjaF9jcnRjKHN0YXRlLT5kZXYsIGNy dGMpIHsKPiA+Pj4+PiArCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPj4+ Pj4gKwo+ID4+Pj4+ICsJCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0 YXRlLCBjcnRjKTsKPiA+Pj4+PiArCQlpZiAoSVNfRVJSKGNydGNfc3RhdGUpKQo+ID4+Pj4+ICsJ CQlyZXR1cm4gUFRSX0VSUihjcnRjX3N0YXRlKTsKPiA+Pj4+PiArCX0KPiA+Pj4+PiArCj4gPj4+ Pj4gKwlyZXR1cm4gMDsKPiA+Pj4+PiArfQo+ID4+Pj4+ICsKPiA+Pj4+PiAgc3RhdGljIGludCBp bnRlbF9tb2Rlc2V0X2FsbF9waXBlcyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4g Pj4+Pj4gIHsKPiA+Pj4+PiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+Pj4+PiAgCXN0cnVj dCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiA+Pj4+PiAgCWludCByZXQgPSAwOwo+ID4+ Pj4+ICAKPiA+Pj4+PiAtCS8qIGFkZCBhbGwgYWN0aXZlIHBpcGVzIHRvIHRoZSBzdGF0ZSAqLwo+ ID4+Pj4+ICsJLyoKPiA+Pj4+PiArCSAqIEFkZCBhbGwgcGlwZXMgdG8gdGhlIHN0YXRlLCBhbmQg Zm9yY2UKPiA+Pj4+PiArCSAqIGEgbW9kZXNldCBvbiBhbGwgdGhlIGFjdGl2ZSBvbmVzLgo+ID4+ Pj4+ICsJICovCj4gPj4+Pj4gIAlmb3JfZWFjaF9jcnRjKHN0YXRlLT5kZXYsIGNydGMpIHsKPiA+ Pj4+PiAgCQljcnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0 Yyk7Cj4gPj4+Pj4gIAkJaWYgKElTX0VSUihjcnRjX3N0YXRlKSkKPiA+Pj4+PiBAQCAtMTQwMTgs MTIgKzE0MDM3LDI0IEBAIHN0YXRpYyBpbnQgaW50ZWxfbW9kZXNldF9jaGVja3Moc3RydWN0IGRy bV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4+Pj4+ICAJCWlmIChyZXQgPCAwKQo+ID4+Pj4+ICAJ CQlyZXR1cm4gcmV0Owo+ID4+Pj4+ICAKPiA+Pj4+PiArCQkvKgo+ID4+Pj4+ICsJCSAqIFdyaXRl cyB0byBkZXZfcHJpdi0+YXRvbWljX2NkY2xrX2ZyZXEgbXVzdCBwcm90ZWN0ZWQgYnkKPiA+Pj4+ PiArCQkgKiBob2xkaW5nIGFsbCB0aGUgY3J0YyBsb2NrcywgZXZlbiBpZiB3ZSBkb24ndCBlbmQg dXAKPiA+Pj4+PiArCQkgKiB0b3VjaGluZyB0aGUgaGFyZHdhcmUKPiA+Pj4+PiArCQkgKi8KPiA+ Pj4+PiArCQlpZiAoaW50ZWxfc3RhdGUtPmNkY2xrICE9IGRldl9wcml2LT5hdG9taWNfY2RjbGtf ZnJlcSkgewo+ID4+Pj4+ICsJCQlyZXQgPSBpbnRlbF9sb2NrX2FsbF9waXBlcyhzdGF0ZSk7Cj4g Pj4+Pj4gKwkJCWlmIChyZXQgPCAwKQo+ID4+Pj4+ICsJCQkJcmV0dXJuIHJldDsKPiA+Pj4+PiAr CQl9Cj4gPj4+Pj4gKwo+ID4+Pj4gV291bGQgaXQgYmUgdGVycmlibGUgdG8ganVzdCB1c2UgaW50 ZWxfbW9kZXNldF9hbGxfcGlwZXMgaGVyZT8gU2luY2UgdGhpcyBjYW4gb25seSBiZSBkaWZmZXJl bnQgaW4gdGhlIGFsbCBjcnRjJ3MgZGlzYWJsZWQgY2FzZQo+ID4+Pj4gaXQgd29uJ3QgbWF0dGVy IG11Y2guCj4gPj4+IElzIHRoZXJlIGFueSBiZW5lZml0IGluIGRvaW5nIHRoYXQ/IEEgYml0IGNv bmZ1c2luZyBJTU8gdG8gZm9yY2UgYQo+ID4+PiBtb2Rlc2V0IHdoZW4geW91IGRvbid0IGhhdmUg dG8uCj4gPj4+Cj4gPj4gVGhlIGNhc2Ugd2hlcmUgYXRvbWljIGNkY2xrIGNoYW5nZXMsIGJ1dCBk ZXZfY2RjbGsgc3RheXMgdGhlIHNhbWUgY2FuIG9ubHkgaGFwcGVuCj4gPj4gaWYgeW91IGNvbmZp Z3VyZSBhIGNydGMsIGJ1dCBhbGwgY3J0YydzIHN0YXkgIWFjdGl2ZS4gSW4gYWxsIG90aGVyIGNh c2VzIGRldl9jZGNsawo+ID4+IHdpbGwgY2hhbmdlIHRvby4KPiA+Pgo+ID4+IGludGVsX21vZGVz ZXRfYWxsX3BpcGVzIHdpbGwgb25seSBzZXQgbW9kZV9jaGFuZ2VkIG9uIGFjdGl2ZSBjcnRjJ3Ms IGJ1dCBpdCB3aWxsCj4gPj4gYWRkIGFsbCBjcnRjJ3MgdG8gdGhlIGF0b21pYyBzdGF0ZSByZWdh cmRsZXNzIHRvIG1ha2Ugc3VyZSB0aGUgY2RjbGsgc3RheXMgY29uc2lzdGVudC4KPiA+IEkgc3Rp bGwgZG9uJ3Qgc2VlIHdoYXQgdGhlIGJlbmVmaXQgaXMuIElNTyBpdCdzIGp1c3QgY29uZnVzaW5n IHRvIHNheQo+ID4gdGhhdCB3ZSdyZSBnb2luZyB0byBmb3JjZSBhIG1vZGVzZXQgb24gYSBkaXNh YmxlZCBwaXBlLgo+ID4KPiBpZiAoIWFjdGl2ZSB8fCBuZWVkc19tb2Rlc2V0KGNydGNfc3RhdGUp KSBjb250aW51ZTsgY3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkPSB0cnVlOyBJdCdzIG5vdCBkb2lu ZyBhIG1vZGVzZXQgb24gYSBkaXNhYmxlZCBwaXBlLCBpdCBvbmx5IG1ha2VzIHN1cmUgaXQncyBw YXJ0IG9mIHRoZSBzdGF0ZS4KCkJ1dCB0aGUgY29kZSB3aWxsIHN0aWxsICpyZWFkKiBpZiAoYmxh aCkgbW9kZXNldF9hbGxfcGlwZXMoKTsKd2hpY2ggaXMgbm9uc2Vuc2UuCgotLSAKVmlsbGUgU3ly asOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK