intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Do not log disabled planes in pipe config
@ 2016-11-18 11:40 Tvrtko Ursulin
  2016-11-18 13:22 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2016-11-18 14:13 ` [PATCH] " Maarten Lankhorst
  0 siblings, 2 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2016-11-18 11:40 UTC (permalink / raw)
  To: Intel-gfx

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

It just says "plane X disabled" which does not seem very useful.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 155910c93896..d35ffb40ca67 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12732,9 +12732,7 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct drm_plane *plane;
-	struct intel_plane *intel_plane;
-	struct intel_plane_state *state;
-	struct drm_framebuffer *fb;
+	bool planes = false;
 
 	DRM_DEBUG_KMS("[CRTC:%d:%s]%s\n",
 		      crtc->base.base.id, crtc->base.name, context);
@@ -12822,19 +12820,19 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
 			      pipe_config->dpll_hw_state.fp1);
 	}
 
-	DRM_DEBUG_KMS("planes on this crtc\n");
 	list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
+		struct intel_plane *intel_plane = to_intel_plane(plane);
+		struct intel_plane_state *state =
+				to_intel_plane_state(plane->state);
+		struct drm_framebuffer *fb = state->base.fb;
 		struct drm_format_name_buf format_name;
-		intel_plane = to_intel_plane(plane);
-		if (intel_plane->pipe != crtc->pipe)
-			continue;
 
-		state = to_intel_plane_state(plane->state);
-		fb = state->base.fb;
-		if (!fb) {
-			DRM_DEBUG_KMS("[PLANE:%d:%s] disabled, scaler_id = %d\n",
-				      plane->base.id, plane->name, state->scaler_id);
+		if (intel_plane->pipe != crtc->pipe || !fb)
 			continue;
+
+		if (!planes) {
+			DRM_DEBUG_KMS("Planes on this crtc:\n");
+			planes = true;
 		}
 
 		DRM_DEBUG_KMS("[PLANE:%d:%s] FB:%d, fb = %ux%u format = %s\n",
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-21 11:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-18 11:40 [PATCH] drm/i915: Do not log disabled planes in pipe config Tvrtko Ursulin
2016-11-18 13:22 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-11-18 14:13 ` [PATCH] " Maarten Lankhorst
2016-11-18 14:19   ` Ville Syrjälä
2016-11-21 10:50     ` Tvrtko Ursulin
2016-11-21 11:15       ` Maarten Lankhorst

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).