From: robert.foss@collabora.com
To: intel-gfx@lists.freedesktop.org,
Gustavo Padovan <gustavo.padovan@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
Marius Vlad <marius.c.vlad@intel.com>,
Eric Engestrom <eric@engestrom.ch>,
Chris Wilson <chris@chris-wilson.co.uk>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>
Subject: [PATCH i-g-t v9 14/21] tests/sw_sync: Add subtest test_sync_expired_merge
Date: Tue, 22 Nov 2016 08:28:32 -0500 [thread overview]
Message-ID: <20161122132839.26250-15-robert.foss@collabora.com> (raw)
In-Reply-To: <20161122132839.26250-1-robert.foss@collabora.com>
From: Rafael Antognolli <rafael.antognolli@intel.com>
This test creates an already expired fence, then creates a merged fence
out of that expired one (passed twice to the merge operation), and
finally closes the merged fence. It shows that if the refcounts are
wrong on the original expired fence, it might get freed while still in
use. Usually a kernel panick will follow.
Signed-off-by: Rafael Antognolli <rafael.antognolli@intel.com>
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/sw_sync.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 265e446..b5ea692 100644
--- a/tests/sw_sync.c
+++ b/tests/sw_sync.c
@@ -598,6 +598,34 @@ static void test_sync_multi_producer_single_consumer(void)
pthread_join(threads[i], NULL);
}
+static void test_sync_expired_merge(void)
+{
+ int iterations = 1 << 20;
+ int timeline;
+ int i;
+ int fence_expired, fence_merged;
+
+ timeline = sw_sync_timeline_create();
+
+ sw_sync_timeline_inc(timeline, 100);
+ fence_expired = sw_sync_fence_create(timeline, 1);
+ igt_assert_f(sync_wait(fence_expired, 0) == 0,
+ "Failure waiting for expired fence\n");
+
+ fence_merged = sync_merge(fence_expired, fence_expired);
+ close(fence_merged);
+
+ for (i = 0; i < iterations; i++) {
+ int fence = sync_merge(fence_expired, fence_expired);
+
+ igt_assert_f(sync_wait(fence, -1) == 0,
+ "Failure waiting on fence\n");
+ close(fence);
+ }
+
+ close(fence_expired);
+}
+
static void test_sync_random_merge(void)
{
int i, size, ret;
@@ -703,6 +731,9 @@ igt_main
igt_subtest("sync_multi_producer_single_consumer")
test_sync_multi_producer_single_consumer();
+ igt_subtest("sync_expired_merge")
+ test_sync_expired_merge();
+
igt_subtest("sync_random_merge")
test_sync_random_merge();
}
--
2.10.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-22 13:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 13:28 [PATCH i-g-t v9 00/21] Implement sw_sync test robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 01/21] lib/sw_sync: Add helper functions for managing synchronization primitives robert.foss
2016-12-05 12:30 ` Tomeu Vizoso
2016-11-22 13:28 ` [PATCH i-g-t v9 02/21] test/sw_sync: Add sw_sync test robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 03/21] tests/sw_sync: Add subtest test_alloc_fence robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 04/21] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 05/21] tests/sw_sync: Add subtest test_alloc_merge_fence robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 06/21] tests/sw_sync: Add subtest test_sync_busy robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 07/21] tests/sw_sync: Add subtest test_sync_merge robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 08/21] tests/sw_sync: Add subtest test_sync_merge_same robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 09/21] tests/sw_sync: Add subtest test_sync_multi_consumer robert.foss
2016-12-05 12:58 ` Tomeu Vizoso
2016-11-22 13:28 ` [PATCH i-g-t v9 10/21] tests/sw_sync: Add subtest test_sync_multi_consumer_producer robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 11/21] tests/sw_sync: Add subtest test_sync_random_merge robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 12/21] tests/sw_sync: Add subtest test_sync_multi_timeline_wait robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 13/21] tests/sw_sync: Add subtest test_sync_multi_producer_single_consumer robert.foss
2016-11-22 13:28 ` robert.foss [this message]
2016-11-22 13:28 ` [PATCH i-g-t v9 15/21] tests/sw_sync: Add subtest test_timeline_closed robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 16/21] tests/sw_sync: Add subtest test_timeline_closed_signaled robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 17/21] lib/sw_sync: Add igt_require_sw_sync to enable skipping on no sw_sync support robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 18/21] tests/sw_sync: Add igt_require check for sw_sync feature robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 19/21] tests/sw_sync: Add subtest test_sync_merge_invalid robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 20/21] tests/sw_sync: Add subtest test_sync_busy_fork robert.foss
2016-11-22 13:28 ` [PATCH i-g-t v9 21/21] tests/sw_sync: Add subtest test_sync_busy_unixsocket robert.foss
2016-12-05 13:24 ` [PATCH i-g-t v9 00/21] Implement sw_sync test Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122132839.26250-15-robert.foss@collabora.com \
--to=robert.foss@collabora.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=eric@engestrom.ch \
--cc=gustavo.padovan@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=marius.c.vlad@intel.com \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox