public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/gen6+: Clear upper data byte during PCODE write
@ 2016-11-24 15:32 Imre Deak
  2016-11-24 15:32 ` [PATCH 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout Imre Deak
                   ` (4 more replies)
  0 siblings, 5 replies; 13+ messages in thread
From: Imre Deak @ 2016-11-24 15:32 UTC (permalink / raw)
  To: intel-gfx

The spec calls for the upper data byte to be cleared before most of the
PCODE write commands, for others like IPS control it doesn't say
anything about this byte. Let's clear it in case it's clobbered somehow,
especially that there are places where we only do a PCODE write without
a preceeding PCODE read.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 29b6653..66c62f3 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7838,6 +7838,7 @@ int sandybridge_pcode_write(struct drm_i915_private *dev_priv,
 	}
 
 	I915_WRITE_FW(GEN6_PCODE_DATA, val);
+	I915_WRITE_FW(GEN6_PCODE_DATA1, 0);
 	I915_WRITE_FW(GEN6_PCODE_MAILBOX, GEN6_PCODE_READY | mbox);
 
 	if (intel_wait_for_register_fw(dev_priv,
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2016-11-28 11:12 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 15:32 [PATCH 1/2] drm/i915/gen6+: Clear upper data byte during PCODE write Imre Deak
2016-11-24 15:32 ` [PATCH 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout Imre Deak
2016-11-25  9:23   ` Chris Wilson
2016-11-25  9:32     ` Chris Wilson
2016-11-25 10:57   ` [PATCH v2 " Imre Deak
2016-11-25 11:00     ` Chris Wilson
2016-11-25 11:30     ` Ville Syrjälä
2016-11-25 11:44       ` Chris Wilson
2016-11-28 11:12         ` Imre Deak
2016-11-24 15:38 ` [PATCH 1/2] drm/i915/gen6+: Clear upper data byte during PCODE write Chris Wilson
2016-11-24 15:47 ` Ville Syrjälä
2016-11-24 17:15 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2016-11-25 11:15 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gen6+: Clear upper data byte during PCODE write (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox