[PATCH 2/2] drm/i915: give gen8_setup_page_directory_pointer or more accurate name

Matthew Auld
2016-12-02T10:30:24Z

The function name gen8_setup_page_directory_pointer is misleading, and only
serves to confuse the reader, it's not setting up a pdp, but
rather encoding a specific pml4e with a given pdp.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 967537798b1f..1ec44f95479e 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -643,10 +643,10 @@ gen8_setup_pdpe(struct i915_hw_ppgtt *ppgtt,
}

static void
-gen8_setup_page_directory_pointer(struct i915_hw_ppgtt *ppgtt,
- struct i915_pml4 *pml4,
- struct i915_page_directory_pointer *pdp,
- int index)
+gen8_setup_pml4e(struct i915_hw_ppgtt *ppgtt,
+ struct i915_pml4 *pml4,
+ struct i915_page_directory_pointer *pdp,
+ int index)
{
gen8_ppgtt_pml4e_t *pagemap = kmap_px(pml4);

@@ -1435,7 +1435,7 @@ static int gen8_alloc_va_range_4lvl(struct i915_address_space *vm,
if (ret)
goto err_out;

- gen8_setup_page_directory_pointer(ppgtt, pml4, pdp, pml4e);
+ gen8_setup_pml4e(ppgtt, pml4, pdp, pml4e);
}

bitmap_or(pml4->used_pml4es, new_pdps, pml4->used_pml4es,
--
2.9.3