From: Jeff McGee <jeff.mcgee@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Drop comment on fwif autogeneration
Date: Mon, 5 Dec 2016 13:37:17 -0800 [thread overview]
Message-ID: <20161205213717.GA27667@jeffdesk> (raw)
In-Reply-To: <1480953869-25267-1-git-send-email-arkadiusz.hiler@intel.com>
Reviewed-by: Jeff McGee <jeff.mcgee@intel.com>
On Mon, Dec 05, 2016 at 05:04:29PM +0100, Arkadiusz Hiler wrote:
> The firmware interface file was initially partially autogenerated, but
> this is no longer the case.
>
> It was never updated automatically, and a lot manual changes were
> introduced since.
>
> From now on any changes to the firmware interface will be managed by
> hand, which gives us flexibility when it comes to structure reuse
> (HuC/GuC) and naming conventions.
>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Jeff Mcgee <jeff.mcgee@intel.com>
> Cc: Sagar A. Kamble <sagar.a.kamble@intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
> drivers/gpu/drm/i915/intel_guc_fwif.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
> index 00ca0df..3202b32 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
> @@ -23,15 +23,6 @@
> #ifndef _INTEL_GUC_FWIF_H
> #define _INTEL_GUC_FWIF_H
>
> -/*
> - * This file is partially autogenerated, although currently with some manual
> - * fixups afterwards. In future, it should be entirely autogenerated, in order
> - * to ensure that the definitions herein remain in sync with those used by the
> - * GuC's own firmware.
> - *
> - * EDITING THIS FILE IS THEREFORE NOT RECOMMENDED - YOUR CHANGES MAY BE LOST.
> - */
> -
> #define GFXCORE_FAMILY_GEN9 12
> #define GFXCORE_FAMILY_UNKNOWN 0x7fffffff
>
> --
> 2.7.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-05 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 16:04 [PATCH] drm/i915/guc: Drop comment on fwif autogeneration Arkadiusz Hiler
2016-12-05 18:59 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-12-06 5:41 ` Arkadiusz Hiler
2016-12-07 7:14 ` Tvrtko Ursulin
2016-12-05 21:37 ` Jeff McGee [this message]
2016-12-05 23:59 ` [PATCH] " Srivatsa, Anusha
2016-12-06 5:37 ` Arkadiusz Hiler
2016-12-06 17:31 ` Srivatsa, Anusha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205213717.GA27667@jeffdesk \
--to=jeff.mcgee@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox