From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Don't assume 60Hz when accounting for DSI pixel overlap
Date: Wed, 14 Dec 2016 18:42:12 +0200 [thread overview]
Message-ID: <20161214164212.GT31595@intel.com> (raw)
In-Reply-To: <20161214162222.GF29871@nuc-i3427.alporthouse.com>
On Wed, Dec 14, 2016 at 04:22:22PM +0000, Chris Wilson wrote:
> On Tue, Dec 13, 2016 at 11:09:17PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Compute the increase in the DSI clock due to pixel overlap mode in
> > a way that's refresh rate agnostic. So far the computation assumed
> > a 60Hz refresh rate. And let's switch to round to closest here as
> > well since we would like to be as close to the target as possible.
> >
> > Also toss in a decent comment explaining what we're actually doing
> > here.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Not totally why being under the target is acceptable?
It's a pixel clock, so closer seems better. At least that's what we do
elsewhere. There are a bunch of other round ups and downs in the DSI
code, and I'm not sure any of those really make sense. Might have to
review them all at some point.
> But the
> conversion from vtotal*60 to clock/htotal looks sound.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-14 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 21:09 [PATCH 1/2] drm/i915: Don't assume 60Hz when accounting for DSI pixel overlap ville.syrjala
2016-12-13 21:09 ` [PATCH 2/2] drm/i915: Dump the pclk and burst_mode_ratio for DSI ville.syrjala
2016-12-14 16:24 ` Chris Wilson
2016-12-14 16:43 ` Ville Syrjälä
2016-12-14 17:14 ` [PATCH 2/2] drm/i915: Dump more configuration information " ville.syrjala
2016-12-16 17:37 ` Chris Wilson
2016-12-21 14:31 ` [PATCH v3 " ville.syrjala
2017-02-14 20:33 ` Ville Syrjälä
2016-12-13 23:45 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Don't assume 60Hz when accounting for DSI pixel overlap Patchwork
2016-12-14 16:22 ` [PATCH 1/2] " Chris Wilson
2016-12-14 16:42 ` Ville Syrjälä [this message]
2016-12-14 17:45 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Don't assume 60Hz when accounting for DSI pixel overlap (rev2) Patchwork
2016-12-21 15:22 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Don't assume 60Hz when accounting for DSI pixel overlap (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214164212.GT31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox