* [PATCH V2] drm/i915: relax uncritical udelay_range() settings
@ 2016-12-16 1:59 Nicholas Mc Guire
2016-12-16 2:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 1 reply; 5+ messages in thread
From: Nicholas Mc Guire @ 2016-12-16 1:59 UTC (permalink / raw)
To: Daniel Vetter
Cc: intel-gfx, linux-kernel, dri-devel, ymohanma, Nicholas Mc Guire
udelay_range(2, 3) is inefficient and as discussions with Jani Nikula
<jani.nikula@linux.intel.com> unnecessary here. This replaces this
tight setting with a relaxed delay of min=20 and max=50. which helps
the hrtimer subsystem optimize timer handling.
Link: http://lkml.org/lkml/2016/12/15/127
Fixes: commit 37ab0810c9b7 ("drm/i915/bxt: DSI enable for BXT")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
V2: use relaxed uslee_range() rather than udelay
fix documentation of changed timings
Problem found by coccinelle:
Patch was compile tested with: x86_64_defconfig (implies CONFIG_DRM_I915)
Patch is against 4.9.0 (localversion-next is next-20161215)
drivers/gpu/drm/i915/intel_dsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 5b72c50..92b96fa 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -379,7 +379,8 @@ static void bxt_dsi_device_ready(struct intel_encoder *encoder)
val &= ~ULPS_STATE_MASK;
val |= (ULPS_STATE_ENTER | DEVICE_READY);
I915_WRITE(MIPI_DEVICE_READY(port), val);
- usleep_range(2, 3);
+ /* at least 2us - relaxed for hrtimer subsystem optimization */
+ usleep_range(10, 50);
/* 3. Exit ULPS */
val = I915_READ(MIPI_DEVICE_READY(port));
--
2.1.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: relax uncritical udelay_range() settings
2016-12-16 1:59 [PATCH V2] drm/i915: relax uncritical udelay_range() settings Nicholas Mc Guire
@ 2016-12-16 2:52 ` Patchwork
2016-12-16 7:29 ` Saarinen, Jani
0 siblings, 1 reply; 5+ messages in thread
From: Patchwork @ 2016-12-16 2:52 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: relax uncritical udelay_range() settings
URL : https://patchwork.freedesktop.org/series/16900/
State : failure
== Summary ==
Series 16900v1 drm/i915: relax uncritical udelay_range() settings
https://patchwork.freedesktop.org/api/1.0/series/16900/revisions/1/mbox/
Test gem_ringfill:
Subgroup basic-default-hang:
pass -> INCOMPLETE (fi-hsw-4770)
Test gem_sync:
Subgroup basic-store-all:
pass -> FAIL (fi-ivb-3520m)
fi-bdw-5557u total:247 pass:233 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:247 pass:208 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:247 pass:222 dwarn:0 dfail:0 fail:0 skip:25
fi-byt-j1900 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:118 pass:109 dwarn:0 dfail:0 fail:0 skip:8
fi-hsw-4770r total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
fi-ilk-650 total:247 pass:195 dwarn:0 dfail:0 fail:0 skip:52
fi-ivb-3520m total:247 pass:225 dwarn:0 dfail:0 fail:1 skip:21
fi-kbl-7500u total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6260u total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:247 pass:227 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:247 pass:224 dwarn:3 dfail:0 fail:0 skip:20
fi-skl-6770hq total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
fi-snb-2600 total:247 pass:215 dwarn:0 dfail:0 fail:0 skip:32
639f10d1159e87cac2f85769dcd081520b904f56 drm-tip: 2016y-12m-15d-17h-57m-41s UTC integration manifest
69bb294 drm/i915: relax uncritical udelay_range() settings
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3304/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915: relax uncritical udelay_range() settings
2016-12-16 2:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-12-16 7:29 ` Saarinen, Jani
2016-12-16 7:47 ` ??? " Nicholas Mc Guire
0 siblings, 1 reply; 5+ messages in thread
From: Saarinen, Jani @ 2016-12-16 7:29 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Nicholas Mc Guire
> == Series Details ==
>
> Series: drm/i915: relax uncritical udelay_range() settings
> URL : https://patchwork.freedesktop.org/series/16900/
> State : failure
>
> == Summary ==
>
> Series 16900v1 drm/i915: relax uncritical udelay_range() settings
> https://patchwork.freedesktop.org/api/1.0/series/16900/revisions/1/mbox/
>
> Test gem_ringfill:
> Subgroup basic-default-hang:
> pass -> INCOMPLETE (fi-hsw-4770)
running: igt/gem_ringfill/basic-default-hang
[117/247] skip: 8, pass: 109 /
Build timed out (after 17 minutes). Marking the build as aborted.
> Test gem_sync:
> Subgroup basic-store-all:
> pass -> FAIL (fi-ivb-3520m)
Err
(gem_sync:9405) CRITICAL: Test assertion failure function store_all, file gem_sync.c:690:
(gem_sync:9405) CRITICAL: Failed assertion: intel_detect_and_clear_missed_interrupts(fd) == 0
(gem_sync:9405) CRITICAL: error: 1 != 0
Subtest basic-store-all failed.
>
> fi-bdw-5557u total:247 pass:233 dwarn:0 dfail:0 fail:0 skip:14
> fi-bsw-n3050 total:247 pass:208 dwarn:0 dfail:0 fail:0 skip:39
> fi-bxt-j4205 total:247 pass:222 dwarn:0 dfail:0 fail:0 skip:25
> fi-byt-j1900 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27
> fi-byt-n2820 total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
> fi-hsw-4770 total:118 pass:109 dwarn:0 dfail:0 fail:0 skip:8
> fi-hsw-4770r total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19
> fi-ilk-650 total:247 pass:195 dwarn:0 dfail:0 fail:0 skip:52
> fi-ivb-3520m total:247 pass:225 dwarn:0 dfail:0 fail:1 skip:21
> fi-kbl-7500u total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21
> fi-skl-6260u total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
> fi-skl-6700hq total:247 pass:227 dwarn:0 dfail:0 fail:0 skip:20
> fi-skl-6700k total:247 pass:224 dwarn:3 dfail:0 fail:0 skip:20
> fi-skl-6770hq total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13
> fi-snb-2520m total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31
> fi-snb-2600 total:247 pass:215 dwarn:0 dfail:0 fail:0 skip:32
>
> 639f10d1159e87cac2f85769dcd081520b904f56 drm-tip: 2016y-12m-15d-17h-
> 57m-41s UTC integration manifest
> 69bb294 drm/i915: relax uncritical udelay_range() settings
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3304/
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ??? Fi.CI.BAT: failure for drm/i915: relax uncritical udelay_range() settings
2016-12-16 7:29 ` Saarinen, Jani
@ 2016-12-16 7:47 ` Nicholas Mc Guire
2016-12-16 9:27 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Nicholas Mc Guire @ 2016-12-16 7:47 UTC (permalink / raw)
To: Saarinen, Jani; +Cc: intel-gfx@lists.freedesktop.org, Nicholas Mc Guire
On Fri, Dec 16, 2016 at 07:29:59AM +0000, Saarinen, Jani wrote:
> > == Series Details ==
> >
> > Series: drm/i915: relax uncritical udelay_range() settings
> > URL : https://patchwork.freedesktop.org/series/16900/
> > State : failure
> >
> > == Summary ==
> >
> > Series 16900v1 drm/i915: relax uncritical udelay_range() settings
> > https://patchwork.freedesktop.org/api/1.0/series/16900/revisions/1/mbox/
> >
> > Test gem_ringfill:
> > Subgroup basic-default-hang:
> > pass -> INCOMPLETE (fi-hsw-4770)
> running: igt/gem_ringfill/basic-default-hang
> [117/247] skip: 8, pass: 109 /
> Build timed out (after 17 minutes). Marking the build as aborted.
>
This might be a conflict caused by the initial patch which was discssed
and then after agreeing that rather than moving to udelay() usleep:range
with som adjustments would be the right way to go.
are both patches queued now ?
I think I caused the problem by changing the subject line of the patch
while adding a V2 - because the original subject line was no longer corrct
(it noted udely) - the V2 patch is marked as "rev 1" in patchwork though.
not quite clear - anyway sorry if I made some sort of a mess here
the patch applies cleanly on next-20161216.
thx!
hofrat
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ??? Fi.CI.BAT: failure for drm/i915: relax uncritical udelay_range() settings
2016-12-16 7:47 ` ??? " Nicholas Mc Guire
@ 2016-12-16 9:27 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2016-12-16 9:27 UTC (permalink / raw)
To: Nicholas Mc Guire, Saarinen, Jani
Cc: intel-gfx@lists.freedesktop.org, Nicholas Mc Guire
On Fri, 16 Dec 2016, Nicholas Mc Guire <der.herr@hofr.at> wrote:
> On Fri, Dec 16, 2016 at 07:29:59AM +0000, Saarinen, Jani wrote:
>> > == Series Details ==
>> >
>> > Series: drm/i915: relax uncritical udelay_range() settings
>> > URL : https://patchwork.freedesktop.org/series/16900/
>> > State : failure
>> >
>> > == Summary ==
>> >
>> > Series 16900v1 drm/i915: relax uncritical udelay_range() settings
>> > https://patchwork.freedesktop.org/api/1.0/series/16900/revisions/1/mbox/
>> >
>> > Test gem_ringfill:
>> > Subgroup basic-default-hang:
>> > pass -> INCOMPLETE (fi-hsw-4770)
>> running: igt/gem_ringfill/basic-default-hang
>> [117/247] skip: 8, pass: 109 /
>> Build timed out (after 17 minutes). Marking the build as aborted.
>>
> This might be a conflict caused by the initial patch which was discssed
> and then after agreeing that rather than moving to udelay() usleep:range
> with som adjustments would be the right way to go.
> are both patches queued now ?
>
> I think I caused the problem by changing the subject line of the patch
> while adding a V2 - because the original subject line was no longer corrct
> (it noted udely) - the V2 patch is marked as "rev 1" in patchwork though.
>
> not quite clear - anyway sorry if I made some sort of a mess here
> the patch applies cleanly on next-20161216.
Nah, some other hickup in CI on a machine that's not affected by your
change.
Pushed to drm-intel-next-queued, thanks for the patch.
BR,
Jani.
>
> thx!
> hofrat
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-16 9:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-16 1:59 [PATCH V2] drm/i915: relax uncritical udelay_range() settings Nicholas Mc Guire
2016-12-16 2:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-12-16 7:29 ` Saarinen, Jani
2016-12-16 7:47 ` ??? " Nicholas Mc Guire
2016-12-16 9:27 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox