From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/i915/guc: Rename _setup() to _load()
Date: Fri, 16 Dec 2016 12:47:26 +0100 [thread overview]
Message-ID: <20161216114726.GD27156@ahiler-desk.igk.intel.com> (raw)
In-Reply-To: <20161215155701.GK29871@nuc-i3427.alporthouse.com>
On Thu, Dec 15, 2016 at 03:57:01PM +0000, Chris Wilson wrote:
> On Thu, Dec 15, 2016 at 04:47:04PM +0100, Arkadiusz Hiler wrote:
> > GuC historically has two "startup" functions called _init() and _setup()
> >
> > Then HuC came with it's _init() and _load().
> >
> > To make naming more consistent this commit renames intel_guc_setup() to
> > intel_guc_load() as it it seams more fitting (it's in intel_guc_loader.c
> > after all).
>
> Or init_hw as that is the initialisation phase it is called from.
> -Chris
Since it's intel_guc_loader.c I somehow prefer _load() here.
But intel_uc_load() which, is introduced with the series and call
intel_guc_load() can be renamed to intel_uc_init_hw()
What do you think?
--
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-16 11:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 15:47 [PATCH 0/5] GuC Scrub vol. 1 Arkadiusz Hiler
2016-12-15 15:47 ` [PATCH 1/5] drm/i915/guc: Rename _setup() to _load() Arkadiusz Hiler
2016-12-15 15:57 ` Chris Wilson
2016-12-16 11:47 ` Arkadiusz Hiler [this message]
2016-12-16 12:47 ` Chris Wilson
2016-12-15 16:22 ` Michal Wajdeczko
2016-12-16 11:43 ` Arkadiusz Hiler
2016-12-15 15:47 ` [PATCH 2/5] drm/i915/guc: Introduce intel_uc_init() Arkadiusz Hiler
2016-12-20 22:00 ` Srivatsa, Anusha
2016-12-27 16:24 ` Arkadiusz Hiler
2016-12-15 15:47 ` [PATCH 3/5] drm/i915/guc: Simplify intel_guc_load() Arkadiusz Hiler
2016-12-15 16:38 ` Michal Wajdeczko
2016-12-16 10:52 ` Arkadiusz Hiler
2016-12-15 22:26 ` Daniele Ceraolo Spurio
2016-12-16 11:16 ` Arkadiusz Hiler
2016-12-16 18:26 ` Daniele Ceraolo Spurio
2016-12-16 15:50 ` Tvrtko Ursulin
2016-12-15 15:47 ` [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init Arkadiusz Hiler
2016-12-23 21:19 ` Daniele Ceraolo Spurio
2016-12-27 16:26 ` Arkadiusz Hiler
2016-12-15 15:47 ` [PATCH 5/5] drm/i915/guc: Simplify guc_fw_path Arkadiusz Hiler
2016-12-16 16:01 ` Tvrtko Ursulin
2016-12-15 17:51 ` ✗ Fi.CI.BAT: failure for GuC Scrub vol. 1 Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216114726.GD27156@ahiler-desk.igk.intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox