From: Michel Thierry <michel.thierry@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 0/9] Execlist based engine-reset
Date: Fri, 16 Dec 2016 12:20:01 -0800 [thread overview]
Message-ID: <20161216202010.7983-1-michel.thierry@intel.com> (raw)
These patches are to add engine reset feature from Gen8. This is also
referred to as Timeout detection and recovery (TDR). This complements to
the full gpu reset feature available in i915 but it only allows to reset a
particular engine instead of all engines thus providing a light weight
engine reset and recovery mechanism.
This implementation is for execlist based submission only hence limited
from Gen8 onwards. For GuC based submission, additional changes can be
added later on.
Timeout detection relies on the existing hangcheck which remains the same,
main changes are to the recovery mechanism. Once we detect a hang on a
particular engine we identify the request that caused the hang, skip the
request and adjust head pointers to allow the execution to proceed
normally. After some cleanup, submissions are restarted to process
remaining work queued to that engine.
If engine reset fails to recover engine correctly then we fallback to full
gpu reset.
v2: ELSP queue request tracking and reset path changes to handle incomplete
requests during reset. Thanks to Chris Wilson for providing these patches.
v3: Let the waiter keep handling the full gpu reset if it already has the
lock; point out that GuC submission needs a different method to restart
workloads after the engine reset completes.
Arun Siluvery (6):
drm/i915: Update i915.reset to handle engine resets
drm/i915/tdr: Modify error handler for per engine hang recovery
drm/i915/tdr: Add support for per engine reset recovery
drm/i915/tdr: Add engine reset count to error state
drm/i915/tdr: Export per-engine reset count info to debugfs
drm/i915/tdr: Enable Engine reset and recovery support
Michel Thierry (2):
drm/i915: Keep i915_handle_error kerneldoc parameters together
drm/i915: Add engine reset count in get-reset-stats ioctl
Mika Kuoppala (1):
drm/i915: Skip reset request if there is one already
drivers/gpu/drm/i915/i915_debugfs.c | 18 +++++++
drivers/gpu/drm/i915/i915_drv.c | 74 +++++++++++++++++++++++++++
drivers/gpu/drm/i915/i915_drv.h | 15 ++++++
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_gem_context.c | 14 +++--
drivers/gpu/drm/i915/i915_gpu_error.c | 3 ++
drivers/gpu/drm/i915/i915_irq.c | 91 ++++++++++++++++++++++++---------
drivers/gpu/drm/i915/i915_params.c | 6 +--
drivers/gpu/drm/i915/i915_params.h | 2 +-
drivers/gpu/drm/i915/i915_pci.c | 5 +-
drivers/gpu/drm/i915/intel_lrc.c | 12 +++++
drivers/gpu/drm/i915/intel_lrc.h | 1 +
drivers/gpu/drm/i915/intel_uncore.c | 61 +++++++++++++++++++---
include/uapi/drm/i915_drm.h | 3 +-
14 files changed, 266 insertions(+), 41 deletions(-)
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2016-12-16 20:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 20:20 Michel Thierry [this message]
2016-12-16 20:20 ` [PATCH 1/9] drm/i915: Keep i915_handle_error kerneldoc parameters together Michel Thierry
2016-12-16 21:40 ` Chris Wilson
2016-12-19 8:22 ` Tvrtko Ursulin
2016-12-16 20:20 ` [PATCH 2/9] drm/i915: Update i915.reset to handle engine resets Michel Thierry
2016-12-16 20:20 ` [PATCH 3/9] drm/i915/tdr: Modify error handler for per engine hang recovery Michel Thierry
2016-12-16 20:20 ` [PATCH 4/9] drm/i915/tdr: Add support for per engine reset recovery Michel Thierry
2016-12-16 20:45 ` Chris Wilson
2016-12-19 5:02 ` Michel Thierry
2016-12-19 9:51 ` Chris Wilson
2017-01-05 23:55 ` Michel Thierry
2016-12-19 14:24 ` Mika Kuoppala
2016-12-19 14:42 ` Chris Wilson
2016-12-16 20:20 ` [PATCH 5/9] drm/i915: Skip reset request if there is one already Michel Thierry
2016-12-16 20:20 ` [PATCH 6/9] drm/i915/tdr: Add engine reset count to error state Michel Thierry
2016-12-16 20:37 ` Chris Wilson
2016-12-16 21:19 ` Michel Thierry
2016-12-19 8:27 ` Tvrtko Ursulin
2016-12-19 18:09 ` Michel Thierry
2016-12-16 20:20 ` [PATCH 7/9] drm/i915/tdr: Export per-engine reset count info to debugfs Michel Thierry
2016-12-16 20:20 ` [PATCH 8/9] drm/i915/tdr: Enable Engine reset and recovery support Michel Thierry
2016-12-16 20:20 ` [RFC 9/9] drm/i915: Add engine reset count in get-reset-stats ioctl Michel Thierry
2016-12-16 20:45 ` ✗ Fi.CI.BAT: warning for Execlist based engine-reset Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216202010.7983-1-michel.thierry@intel.com \
--to=michel.thierry@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox