From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 8/9] drm/i915: Don't populate plane->plane for cursors and sprites
Date: Mon, 19 Dec 2016 20:55:44 +0200 [thread overview]
Message-ID: <20161219185544.GW31595@intel.com> (raw)
In-Reply-To: <20161219182415.GM4944@intel.com>
On Mon, Dec 19, 2016 at 10:24:15AM -0800, Matt Roper wrote:
> On Thu, Dec 15, 2016 at 09:59:51PM +0200, Ville Syrjälä wrote:
> > On Thu, Dec 15, 2016 at 05:50:02PM -0200, Paulo Zanoni wrote:
> > > Em Qui, 2016-12-15 às 21:11 +0200, Ville Syrjälä escreveu:
> > > > On Thu, Dec 15, 2016 at 05:05:05PM -0200, Paulo Zanoni wrote:
> > > > >
> > > > > Em Ter, 2016-11-22 às 18:02 +0200, ville.syrjala@linux.intel.com
> > > > > escreveu:
> > > > > >
> > > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > >
> > > > > > With plane->plane now purely reserved for the primary planes,
> > > > > > let's
> > > > > > not even populate it for cursors and sprites. Let's switch the
> > > > > > type
> > > > > > to enum plane as well since it's no longer being abused for
> > > > > > anything
> > > > > > else.
> > > > >
> > > > > Since it's a primary plane thing, I think it makes more sense to
> > > > > just
> > > > > leave it at struct intel_crtc instead of having a field that's
> > > > > unused
> > > > > and doesn't make sense in some cases.
> > > >
> > > > Primary plane aren't really primary planes on old platforms though.
> > > > That's just a software concept that has no bearing on the hardware.
> > >
> > > Please explain more since that's not my understanding. I just opened
> > > the gen 2 and 3 spec docs and they do contain tons of "primary plane"
> > > references. I know that the hardware is a little more flexible there,
> >
> > Yep. Planes can be moved to any pipe in general.
> >
> > > but as far as I understand we don't even implement that.
> >
> > Not at the moment. But I have plans...
>
> I'm not even sure where to find bspecs for the really old
> platforms...how flexible were those primary planes? Can we drive both
> "primary" planes at the same time on a single CRTC if we're not using
> the second pipe?
There are three "primary" planes, two cursors, and one video overlay.
Any one can be assigned to either pipe more or less freely (some
restrctions do apply). The planes aren't uniform (not even the
"primary" planes) and instead have different capabilities between them.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-19 18:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 16:01 [PATCH v2 0/9] drm/i915: Add a per-pipe plane identifier enum (v2) ville.syrjala
2016-11-22 16:01 ` [PATCH 1/9] drm/i915: Add per-pipe plane identifier ville.syrjala
2016-11-22 16:01 ` [PATCH 2/9] drm/i915: Add crtc->plane_ids_mask ville.syrjala
2016-11-22 16:01 ` [PATCH 3/9] drm/i915: Use enum plane_id in SKL wm code ville.syrjala
2016-11-22 20:27 ` Lyude Paul
2016-11-22 16:01 ` [PATCH 4/9] drm/i915: Use enum plane_id in SKL plane code ville.syrjala
2016-11-22 16:02 ` [PATCH 5/9] drm/i915: Use enum plane_id in VLV/CHV sprite code ville.syrjala
2016-11-22 16:02 ` [PATCH 6/9] drm/i915: Use enum plane_id in VLV/CHV wm code ville.syrjala
2016-11-22 16:02 ` [PATCH 7/9] drm/i915: s/plane/plane_id/ in skl+ plane register defines ville.syrjala
2016-12-15 18:33 ` Paulo Zanoni
2016-11-22 16:02 ` [PATCH 8/9] drm/i915: Don't populate plane->plane for cursors and sprites ville.syrjala
2016-12-15 19:05 ` Paulo Zanoni
2016-12-15 19:11 ` Ville Syrjälä
2016-12-15 19:50 ` Paulo Zanoni
2016-12-15 19:59 ` Ville Syrjälä
2016-12-16 14:07 ` Paulo Zanoni
2016-12-16 14:56 ` Ander Conselvan De Oliveira
2016-12-19 18:24 ` Matt Roper
2016-12-19 18:55 ` Ville Syrjälä [this message]
2016-11-22 16:02 ` [PATCH 9/9] drm/i915: Rename the local 'plane' variable to 'plane_id' in primary plane code ville.syrjala
2016-11-22 16:45 ` ✓ Fi.CI.BAT: success for drm/i915: Add a per-pipe plane identifier enum (rev5) Patchwork
2016-11-23 20:16 ` [PATCH v2 0/9] drm/i915: Add a per-pipe plane identifier enum (v2) Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219185544.GW31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox