From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Move the min_pixclk[] handling to the end of readout Date: Thu, 22 Dec 2016 16:07:24 +0200 Message-ID: <20161222140724.GN31595@intel.com> References: <20161220153902.15621-1-ville.syrjala@linux.intel.com> <5c1c65a3-983f-a5c4-4398-71b8924bc3b2@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E4996E26D for ; Thu, 22 Dec 2016 14:07:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: <5c1c65a3-983f-a5c4-4398-71b8924bc3b2@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBEZWMgMjIsIDIwMTYgYXQgMDI6MTA6MjVQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMjAtMTItMTYgb20gMTY6Mzkgc2NocmVlZiB2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4gPgo+ID4gVHJ5aW5nIHRvIGRldGVybWluZSB0aGUgcGl4ZWwgcmF0 ZSBvZiB0aGUgcGlwZSBjYW4ndCBiZSBkb25lIHVudGlsIHdlCj4gPiBrbm93IHRoZSBjbG9jaywg d2hpY2ggbWVhbnMgaXQgY2FuJ3QgYmUgZG9uZSB1bnRpbCB0aGUgZW5jb2Rlcgo+ID4gLmdldF9j b25maWcoKSBob29rcyBoYXZlIGJlZW4gY2FsbGVkLiBTbyBsZXQncyBtb3ZlIHRoZSBtaW5fcGl4 Y2xrW10KPiA+IHN0dWZmIHRvIHRoZSBlbmQgb2YgaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0 YXRlKCkgd2hlbiB3ZSBhY3R1YWxseQo+ID4gaGF2ZSBnYXRoZXJlZCBhbGwgdGhlIHJlcXVpcmVk IGluZnJvbWF0aW9uLgo+ID4KPiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5r aG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBp bnRlbC5jb20+Cj4gPiBDYzogQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5jb25z ZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPgo+ID4gRml4ZXM6IDU2NTYwMmQ3NTAxYSAoImRy bS9pOTE1OiBEbyBub3QgYWNxdWlyZSBjcnRjIHN0YXRlIHRvIGNoZWNrIGNsb2NrIGR1cmluZyBt b2Rlc2V0LCB2NC4iKQo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyB8IDMyICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+ID4K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IGVmNWRkZTVhYjFj Zi4uZDhlZmZkNGRhMDM0IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+IEBAIC0xNzAzMyw3ICsxNzAzMyw2IEBAIHN0YXRpYyB2b2lkIGludGVsX21vZGVzZXRf cmVhZG91dF9od19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gIAo+ID4gIAlmb3Jf ZWFjaF9pbnRlbF9jcnRjKGRldiwgY3J0Yykgewo+ID4gIAkJc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUgPSBjcnRjLT5jb25maWc7Cj4gPiAtCQlpbnQgcGl4Y2xrID0gMDsKPiA+ ICAKPiA+ICAJCV9fZHJtX2F0b21pY19oZWxwZXJfY3J0Y19kZXN0cm95X3N0YXRlKCZjcnRjX3N0 YXRlLT5iYXNlKTsKPiA+ICAJCW1lbXNldChjcnRjX3N0YXRlLCAwLCBzaXplb2YoKmNydGNfc3Rh dGUpKTsKPiA+IEBAIC0xNzA0NSwyMyArMTcwNDQsOSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rl c2V0X3JlYWRvdXRfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAJCWNydGMt PmJhc2UuZW5hYmxlZCA9IGNydGNfc3RhdGUtPmJhc2UuZW5hYmxlOwo+ID4gIAkJY3J0Yy0+YWN0 aXZlID0gY3J0Y19zdGF0ZS0+YmFzZS5hY3RpdmU7Cj4gPiAgCj4gPiAtCQlpZiAoY3J0Y19zdGF0 ZS0+YmFzZS5hY3RpdmUpIHsKPiA+ICsJCWlmIChjcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkKPiA+ ICAJCQlkZXZfcHJpdi0+YWN0aXZlX2NydGNzIHw9IDEgPDwgY3J0Yy0+cGlwZTsKPiA+ICAKPiA+ IC0JCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5IHx8IElTX0JST0FEV0VMTChkZXZfcHJp dikpCj4gPiAtCQkJCXBpeGNsayA9IGlsa19waXBlX3BpeGVsX3JhdGUoY3J0Y19zdGF0ZSk7Cj4g PiAtCQkJZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhk ZXZfcHJpdikpCj4gPiAtCQkJCXBpeGNsayA9IGNydGNfc3RhdGUtPmJhc2UuYWRqdXN0ZWRfbW9k ZS5jcnRjX2Nsb2NrOwo+ID4gLQkJCWVsc2UKPiA+IC0JCQkJV0FSTl9PTihkZXZfcHJpdi0+ZGlz cGxheS5tb2Rlc2V0X2NhbGNfY2RjbGspOwo+ID4gLQo+ID4gLQkJCS8qIHBpeGVsIHJhdGUgbXVz dG4ndCBleGNlZWQgOTUlIG9mIGNkY2xrIHdpdGggSVBTIG9uIEJEVyAqLwo+ID4gLQkJCWlmIChJ U19CUk9BRFdFTEwoZGV2X3ByaXYpICYmIGNydGNfc3RhdGUtPmlwc19lbmFibGVkKQo+ID4gLQkJ CQlwaXhjbGsgPSBESVZfUk9VTkRfVVAocGl4Y2xrICogMTAwLCA5NSk7Cj4gPiAtCQl9Cj4gPiAt Cj4gPiAtCQlkZXZfcHJpdi0+bWluX3BpeGNsa1tjcnRjLT5waXBlXSA9IHBpeGNsazsKPiA+IC0K PiA+ICAJCXJlYWRvdXRfcGxhbmVfc3RhdGUoY3J0Yyk7Cj4gPiAgCj4gPiAgCQlEUk1fREVCVUdf S01TKCJbQ1JUQzolZDolc10gaHcgc3RhdGUgcmVhZG91dDogJXNcbiIsCj4gPiBAQCAtMTcxMzQs NiArMTcxMTksOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdfc3RhdGUo c3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAJfQo+ID4gIAo+ID4gIAlmb3JfZWFjaF9pbnRl bF9jcnRjKGRldiwgY3J0Yykgewo+ID4gKwkJaW50IHBpeGNsayA9IDA7Cj4gPiArCj4gPiAgCQlj cnRjLT5iYXNlLmh3bW9kZSA9IGNydGMtPmNvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ID4g IAo+ID4gIAkJbWVtc2V0KCZjcnRjLT5iYXNlLm1vZGUsIDAsIHNpemVvZihjcnRjLT5iYXNlLm1v ZGUpKTsKPiA+IEBAIC0xNzE2MSwxMCArMTcxNDgsMjMgQEAgc3RhdGljIHZvaWQgaW50ZWxfbW9k ZXNldF9yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgCQkJICov Cj4gPiAgCQkJY3J0Yy0+YmFzZS5zdGF0ZS0+bW9kZS5wcml2YXRlX2ZsYWdzID0gSTkxNV9NT0RF X0ZMQUdfSU5IRVJJVEVEOwo+ID4gIAo+ID4gKwkJCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49 IDkgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkKPiA+ICsJCQkJcGl4Y2xrID0gaWxrX3BpcGVf cGl4ZWxfcmF0ZShjcnRjLT5jb25maWcpOwo+ID4gKwkJCWVsc2UgaWYgKElTX1ZBTExFWVZJRVco ZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gKwkJCQlwaXhjbGsgPSBj cnRjLT5jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2Nsb2NrOwo+ID4gKwkJCWVsc2UK PiA+ICsJCQkJV0FSTl9PTihkZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2NhbGNfY2RjbGspOwo+ ID4gKwo+ID4gKwkJCS8qIHBpeGVsIHJhdGUgbXVzdG4ndCBleGNlZWQgOTUlIG9mIGNkY2xrIHdp dGggSVBTIG9uIEJEVyAqLwo+ID4gKwkJCWlmIChJU19CUk9BRFdFTEwoZGV2X3ByaXYpICYmIGNy dGMtPmNvbmZpZy0+aXBzX2VuYWJsZWQpCj4gPiArCQkJCXBpeGNsayA9IERJVl9ST1VORF9VUChw aXhjbGsgKiAxMDAsIDk1KTsKPiA+ICsKPiA+ICAJCQlkcm1fY2FsY190aW1lc3RhbXBpbmdfY29u c3RhbnRzKCZjcnRjLT5iYXNlLCAmY3J0Yy0+YmFzZS5od21vZGUpOwo+ID4gIAkJCXVwZGF0ZV9z Y2FubGluZV9vZmZzZXQoY3J0Yyk7Cj4gPiAgCQl9Cj4gPiAgCj4gPiArCQlkZXZfcHJpdi0+bWlu X3BpeGNsa1tjcnRjLT5waXBlXSA9IHBpeGNsazsKPiA+ICsKPiA+ICAJCWludGVsX3BpcGVfY29u ZmlnX3Nhbml0eV9jaGVjayhkZXZfcHJpdiwgY3J0Yy0+Y29uZmlnKTsKPiA+ICAJfQo+ID4gIH0K PiAKPiBMb29rcyBnb29kLiBDb3VsZCB5b3UgZG8gaW50ZWxfY3J0Y19zdGF0ZSA9IHRvX2ludGVs X2NydGNfc3RhdGUoY3J0Yy0+YmFzZS5zdGF0ZSkgYXQgdGhlIHN0YXJ0Cj4gYW5kIGZpeCBhbGwg LT5zdGF0ZSBhbmQgLT5jb25maWcgZGVyZWZlcmVuY2VzIGluIHRoaXMgbG9vcCB0b28/Cj4gVGhp cyBpcyBhIGNsZWFudXAgSSdtIHRyeWluZyB0byBhcHBseSB0byB0aGUgd2hvbGUgZHJpdmVyLiBB dG9taWMgc3RhdGUgc2hvdWxkIGJlCj4gcGFzc2VkIGluIHdoZXJlIHBvc3NpYmxlLCBhbmQgY3J0 Yy0+Y29uZmlnL3N0YXRlIGRlcmVmZXJlbmNlcyBzaG91bGQgYmUgYXZvaWRlZCBhcyBtdWNoIGFz IHdlIGNhbi4KPiBFdmVudHVhbGx5IEkgd2FudCB0byBnZXQgcmlkIG9mIGNydGMtPmNvbmZpZyBh bHRvZ2V0aGVyLiA6KQoKSSBwb3N0ZWQgdGhhdCBhcyBhIGZvbGxvd3VwLgoKPiAKPiBSZXZpZXdl ZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNv bT4KClBhdGNoIHB1c2hlZCB0byBkaW5xLiBUaGFua3MgZm9yIHRoZSByZXZpZXdzLgoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==