From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4 1/2] drm: Wrap the check for atomic_commit implementation Date: Tue, 27 Dec 2016 10:50:16 +0100 Message-ID: <20161227095016.GD19172@dvetter-linux.ger.corp.intel.com> References: <1482531241-19025-1-git-send-email-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7224895C8 for ; Tue, 27 Dec 2016 09:50:21 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id c85so18288948wmi.1 for ; Tue, 27 Dec 2016 01:50:21 -0800 (PST) Content-Disposition: inline In-Reply-To: <1482531241-19025-1-git-send-email-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Ben Skeggs , dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMjMsIDIwMTYgYXQgMDI6MTQ6MDBQTSAtMDgwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBUaGlzIGNoZWNrIGlzIHVzZWZ1bCBmb3IgZHJpdmVycyB0aGF0IGRvIG5v dCBoYXZlIERSSVZFUl9BVE9NSUMgc2V0IGJ1dAo+IGhhdmUgYXRvbWljIG1vZGVzZXR0aW5nIGlu dGVybmFsbHkgaW1wbGVtZW50ZWQuIFdyYXAgdGhlIGNoZWNrIGludG8gYQo+IGZ1bmN0aW9uIHNp bmNlIHRoaXMgaXMgdXNlZCBpbiBtYW55IHBsYWNlcyBhbmQgYXMgYSBib251cywgdGhlIGZ1bmN0 aW9uCj4gbmFtZSBoZWxwcyB0byBkb2N1bWVudCB3aGF0IHRoZSBjaGVjayBpcyBmb3IuCj4gCj4g djI6Cj4gQ2hhbmdlIHJldHVybiB0eXBlIHRvIGJvb2wgKFZpbGxlKQo+IE1vdmUgdGhlIGZ1bmN0 aW9uIGRybV9hdG9taWMuaCAoRGFuaWVsKQo+IEZpeGVkIGNvbW1lbnQgbWFya2VyIGZvciBkb2N1 bWVudGF0aW9uCj4gCj4gdjM6Cj4gSW5jbHVkZWQgZHJtUC5oIHRvIGRlcmVmZXJlbmNlIHN0cnVj dCBkcm1fZGV2aWNlCgpJJ3ZlIHdlbnQgd2l0aCBhIHNsaWdodGx5IGRpZmZlcmVudCBzb2x1dGlv bi4gVGhlIHByb3BlciBvbmUgaXMgdG8gZXh0cmFjdApkcm1fZGV2LmggKHNpbmNlIGRybVAuaCBp cyBob3JyaWJseSBtZXNzeSksIGJ1dCB0aGF0J3MgYSBsb3QgbW9yZSB3b3JrLgotRGFuaWVsCgo+ IAo+IFN1Z2dlc3RlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogQmVuIFNr ZWdncyA8YnNrZWdnc0ByZWRoYXQuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFu ZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX2ZiX2hlbHBlci5jICAgICAgICAgICAgIHwgIDYgKysrLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfY29ubmVjdG9yLmMgfCAgNSArKystLQo+ICBkcml2ZXJz L2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYyAgIHwgIDYgKysrLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZmJjb24uYyAgICAgfCAgMyArKy0KPiAgaW5jbHVk ZS9kcm0vZHJtX2F0b21pYy5oICAgICAgICAgICAgICAgICAgICB8IDEzICsrKysrKysrKysrKysK PiAgNSBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IGluZGV4IDE0NWQ1NWYuLjczMDM0MmMgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZmJfaGVscGVyLmMKPiBAQCAtNDA1LDcgKzQwNSw3IEBAIHN0YXRpYyBpbnQgcmVz dG9yZV9mYmRldl9tb2RlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCj4gIAo+ICAJ ZHJtX3dhcm5fb25fbW9kZXNldF9ub3RfYWxsX2xvY2tlZChkZXYpOwo+ICAKPiAtCWlmIChkZXYt Pm1vZGVfY29uZmlnLmZ1bmNzLT5hdG9taWNfY29tbWl0KQo+ICsJaWYgKGRybV9kcnZfdXNlc19h dG9taWNfbW9kZXNldChkZXYpKQo+ICAJCXJldHVybiByZXN0b3JlX2ZiZGV2X21vZGVfYXRvbWlj KGZiX2hlbHBlcik7Cj4gIAo+ICAJZHJtX2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBkZXYpIHsKPiBA QCAtMTQ0NCw3ICsxNDQ0LDcgQEAgaW50IGRybV9mYl9oZWxwZXJfcGFuX2Rpc3BsYXkoc3RydWN0 IGZiX3Zhcl9zY3JlZW5pbmZvICp2YXIsCj4gIAkJcmV0dXJuIC1FQlVTWTsKPiAgCX0KPiAgCj4g LQlpZiAoZGV2LT5tb2RlX2NvbmZpZy5mdW5jcy0+YXRvbWljX2NvbW1pdCkgewo+ICsJaWYgKGRy bV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChkZXYpKSB7Cj4gIAkJcmV0ID0gcGFuX2Rpc3BsYXlf YXRvbWljKHZhciwgaW5mbyk7Cj4gIAkJZ290byB1bmxvY2s7Cj4gIAl9Cj4gQEAgLTIwNjAsNyAr MjA2MCw3IEBAIHN0YXRpYyBpbnQgZHJtX3BpY2tfY3J0Y3Moc3RydWN0IGRybV9mYl9oZWxwZXIg KmZiX2hlbHBlciwKPiAgCSAqIE5VTEwgd2UgZmFsbGJhY2sgdG8gdGhlIGRlZmF1bHQgZHJtX2F0 b21pY19oZWxwZXJfYmVzdF9lbmNvZGVyKCkKPiAgCSAqIGhlbHBlci4KPiAgCSAqLwo+IC0JaWYg KGZiX2hlbHBlci0+ZGV2LT5tb2RlX2NvbmZpZy5mdW5jcy0+YXRvbWljX2NvbW1pdCAmJgo+ICsJ aWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChmYl9oZWxwZXItPmRldikgJiYKPiAgCSAg ICAhY29ubmVjdG9yX2Z1bmNzLT5iZXN0X2VuY29kZXIpCj4gIAkJZW5jb2RlciA9IGRybV9hdG9t aWNfaGVscGVyX2Jlc3RfZW5jb2Rlcihjb25uZWN0b3IpOwo+ICAJZWxzZQo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Nvbm5lY3Rvci5jIGIvZHJpdmVycy9n cHUvZHJtL25vdXZlYXUvbm91dmVhdV9jb25uZWN0b3IuYwo+IGluZGV4IDk0N2MyMDAuLjk2NmQy MGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9jb25uZWN0 b3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfY29ubmVjdG9yLmMK PiBAQCAtMzMsNiArMzMsNyBAQAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+ Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2VkaWQuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19o ZWxwZXIuaD4KPiArI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljLmg+Cj4gIAo+ICAjaW5jbHVkZSAi bm91dmVhdV9yZWcuaCIKPiAgI2luY2x1ZGUgIm5vdXZlYXVfZHJ2LmgiCj4gQEAgLTc2OSw3ICs3 NzAsNyBAQCBub3V2ZWF1X2Nvbm5lY3Rvcl9zZXRfcHJvcGVydHkoc3RydWN0IGRybV9jb25uZWN0 b3IgKmNvbm5lY3RvciwKPiAgCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciA9IHRvX2RybV9l bmNvZGVyKG52X2VuY29kZXIpOwo+ICAJaW50IHJldDsKPiAgCj4gLQlpZiAoY29ubmVjdG9yLT5k ZXYtPm1vZGVfY29uZmlnLmZ1bmNzLT5hdG9taWNfY29tbWl0KQo+ICsJaWYgKGRybV9kcnZfdXNl c19hdG9taWNfbW9kZXNldChjb25uZWN0b3ItPmRldikpCj4gIAkJcmV0dXJuIGRybV9hdG9taWNf aGVscGVyX2Nvbm5lY3Rvcl9zZXRfcHJvcGVydHkoY29ubmVjdG9yLCBwcm9wZXJ0eSwgdmFsdWUp Owo+ICAKPiAgCXJldCA9IGNvbm5lY3Rvci0+ZnVuY3MtPmF0b21pY19zZXRfcHJvcGVydHkoJm52 X2Nvbm5lY3Rvci0+YmFzZSwKPiBAQCAtMTA3NCw3ICsxMDc1LDcgQEAgbm91dmVhdV9jb25uZWN0 b3JfaGVscGVyX2Z1bmNzID0gewo+ICBzdGF0aWMgaW50Cj4gIG5vdXZlYXVfY29ubmVjdG9yX2Rw bXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwgaW50IG1vZGUpCj4gIHsKPiAtCWlm IChjb25uZWN0b3ItPmRldi0+bW9kZV9jb25maWcuZnVuY3MtPmF0b21pY19jb21taXQpCj4gKwlp ZiAoZHJtX2Rydl91c2VzX2F0b21pY19tb2Rlc2V0KGNvbm5lY3Rvci0+ZGV2KSkKPiAgCQlyZXR1 cm4gZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2RwbXMoY29ubmVjdG9yLCBtb2RlKTsKPiAg CXJldHVybiBkcm1faGVscGVyX2Nvbm5lY3Rvcl9kcG1zKGNvbm5lY3RvciwgbW9kZSk7Cj4gIH0K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kaXNwbGF5LmMg Yi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYwo+IGluZGV4IGM1Y2Y4 ODguLmFkZDM1M2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVh dV9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3Bs YXkuYwo+IEBAIC0xNjIsNyArMTYyLDcgQEAgbm91dmVhdV9kaXNwbGF5X3ZibHN0YW1wKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlLAo+ICAJbGlzdF9mb3JfZWFjaF9l bnRyeShjcnRjLCAmZGV2LT5tb2RlX2NvbmZpZy5jcnRjX2xpc3QsIGhlYWQpIHsKPiAgCQlpZiAo bm91dmVhdV9jcnRjKGNydGMpLT5pbmRleCA9PSBwaXBlKSB7Cj4gIAkJCXN0cnVjdCBkcm1fZGlz cGxheV9tb2RlICptb2RlOwo+IC0JCQlpZiAoZGV2LT5tb2RlX2NvbmZpZy5mdW5jcy0+YXRvbWlj X2NvbW1pdCkKPiArCQkJaWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChkZXYpKQo+ICAJ CQkJbW9kZSA9ICZjcnRjLT5zdGF0ZS0+YWRqdXN0ZWRfbW9kZTsKPiAgCQkJZWxzZQo+ICAJCQkJ bW9kZSA9ICZjcnRjLT5od21vZGU7Cj4gQEAgLTczOCw3ICs3MzgsNyBAQCBub3V2ZWF1X2Rpc3Bs YXlfc3VzcGVuZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBib29sIHJ1bnRpbWUpCj4gIAlzdHJ1 Y3Qgbm91dmVhdV9kaXNwbGF5ICpkaXNwID0gbm91dmVhdV9kaXNwbGF5KGRldik7Cj4gIAlzdHJ1 Y3QgZHJtX2NydGMgKmNydGM7Cj4gIAo+IC0JaWYgKGRldi0+bW9kZV9jb25maWcuZnVuY3MtPmF0 b21pY19jb21taXQpIHsKPiArCWlmIChkcm1fZHJ2X3VzZXNfYXRvbWljX21vZGVzZXQoZGV2KSkg ewo+ICAJCWlmICghcnVudGltZSkgewo+ICAJCQlkaXNwLT5zdXNwZW5kID0gbm91dmVhdV9hdG9t aWNfc3VzcGVuZChkZXYpOwo+ICAJCQlpZiAoSVNfRVJSKGRpc3AtPnN1c3BlbmQpKSB7Cj4gQEAg LTc4NCw3ICs3ODQsNyBAQCBub3V2ZWF1X2Rpc3BsYXlfcmVzdW1lKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIGJvb2wgcnVudGltZSkKPiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiAgCWludCBy ZXQ7Cj4gIAo+IC0JaWYgKGRldi0+bW9kZV9jb25maWcuZnVuY3MtPmF0b21pY19jb21taXQpIHsK PiArCWlmIChkcm1fZHJ2X3VzZXNfYXRvbWljX21vZGVzZXQoZGV2KSkgewo+ICAJCW5vdXZlYXVf ZGlzcGxheV9pbml0KGRldik7Cj4gIAkJaWYgKGRpc3AtPnN1c3BlbmQpIHsKPiAgCQkJZHJtX2F0 b21pY19oZWxwZXJfcmVzdW1lKGRldiwgZGlzcC0+c3VzcGVuZCk7Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9ub3V2ZWF1L25vdXZlYXVfZmJjb24uYyBiL2RyaXZlcnMvZ3B1L2RybS9u b3V2ZWF1L25vdXZlYXVfZmJjb24uYwo+IGluZGV4IDU2MDBmNmMuLjlkZTZhYmIgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9mYmNvbi5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9mYmNvbi5jCj4gQEAgLTQxLDYgKzQxLDcgQEAK PiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Yy5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hl bHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9oZWxwZXIuaD4KPiArI2luY2x1ZGUgPGRy bS9kcm1fYXRvbWljLmg+Cj4gIAo+ICAjaW5jbHVkZSAibm91dmVhdV9kcnYuaCIKPiAgI2luY2x1 ZGUgIm5vdXZlYXVfZ2VtLmgiCj4gQEAgLTUyNCw3ICs1MjUsNyBAQCBub3V2ZWF1X2ZiY29uX2lu aXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlwcmVmZXJyZWRfYnBwID0gMzI7Cj4gIAo+ ICAJLyogZGlzYWJsZSBhbGwgdGhlIHBvc3NpYmxlIG91dHB1dHMvY3J0Y3MgYmVmb3JlIGVudGVy aW5nIEtNUyBtb2RlICovCj4gLQlpZiAoIWRldi0+bW9kZV9jb25maWcuZnVuY3MtPmF0b21pY19j b21taXQpCj4gKwlpZiAoIWRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChkZXYpKQo+ICAJCWRy bV9oZWxwZXJfZGlzYWJsZV91bnVzZWRfZnVuY3Rpb25zKGRldik7Cj4gIAo+ICAJcmV0ID0gZHJt X2ZiX2hlbHBlcl9pbml0aWFsX2NvbmZpZygmZmJjb24tPmhlbHBlciwgcHJlZmVycmVkX2JwcCk7 Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaCBiL2luY2x1ZGUvZHJtL2Ry bV9hdG9taWMuaAo+IGluZGV4IDhjYzdjYTIuLmM4OTRkZGUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVk ZS9kcm0vZHJtX2F0b21pYy5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pYy5oCj4gQEAg LTI5LDYgKzI5LDcgQEAKPiAgI2RlZmluZSBEUk1fQVRPTUlDX0hfCj4gIAo+ICAjaW5jbHVkZSA8 ZHJtL2RybV9jcnRjLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtUC5oPgo+ICAKPiAgLyoqCj4gICAq IHN0cnVjdCBkcm1fY3J0Y19jb21taXQgLSB0cmFjayBtb2Rlc2V0IGNvbW1pdHMgb24gYSBDUlRD Cj4gQEAgLTQxOSw1ICs0MjAsMTcgQEAgZHJtX2F0b21pY19jcnRjX25lZWRzX21vZGVzZXQoY29u c3Qgc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSkKPiAgCSAgICAgICBzdGF0ZS0+Y29ubmVj dG9yc19jaGFuZ2VkOwo+ICB9Cj4gIAo+ICsvKioKPiArICogZHJtX2Rydl91c2VzX2F0b21pY19t b2Rlc2V0IC0gY2hlY2sgaWYgdGhlIGRyaXZlciBpbXBsZW1lbnRzCj4gKyAqIGF0b21pY19jb21t aXQoKQo+ICsgKiBAZGV2OiBEUk0gZGV2aWNlCj4gKyAqCj4gKyAqIFRoaXMgY2hlY2sgaXMgdXNl ZnVsIGlmIGRyaXZlcnMgZG8gbm90IGhhdmUgRFJJVkVSX0FUT01JQyBzZXQgYnV0Cj4gKyAqIGhh dmUgYXRvbWljIG1vZGVzZXR0aW5nIGludGVybmFsbHkgaW1wbGVtZW50ZWQuCj4gKyAqLwo+ICtz dGF0aWMgaW5saW5lIGJvb2wgZHJtX2Rydl91c2VzX2F0b21pY19tb2Rlc2V0KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpCj4gK3sKPiArCXJldHVybiBkZXYtPm1vZGVfY29uZmlnLmZ1bmNzLT5hdG9t aWNfY29tbWl0ICE9IE5VTEw7Cj4gK30KPiAgCj4gICNlbmRpZiAvKiBEUk1fQVRPTUlDX0hfICov Cj4gLS0gCj4gMi43LjQKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK