Re: [PATCH 6/9] drm/i915: Pass the correct plane index to _intel_compute_tile_offset()

Imre Deak
2017-02-02T16:10:01Z

On Wed, Jan 04, 2017 at 08:42:29PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_fill_fb_info() should pass the correct plane index to
> _intel_compute_tile_offset() once we start to care about the AUX
> surface.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

This changes how x/y and offset is calculated already now for planes
with a cpp different than that of plane 0, but the end result remains
the same:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 0ca0dbccc005..5fee5a7ac9a4 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2525,7 +2525,7 @@ intel_fill_fb_info(struct drm_i915_private *dev_priv,
> intel_fb->normal[i].y = y;
>
> offset = _intel_compute_tile_offset(dev_priv, &x, &y,
> - fb, 0, fb->pitches[i],
> + fb, i, fb->pitches[i],
> DRM_ROTATE_0, tile_size);
> offset /= tile_size;
>
> --
> 2.10.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel