From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rob Clark <robdclark@gmail.com>
Cc: Ben Widawsky <ben@bwidawsk.net>,
Intel GFX <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2
Date: Thu, 12 Jan 2017 11:38:20 +0200 [thread overview]
Message-ID: <20170112093820.GQ31595@intel.com> (raw)
In-Reply-To: <CAF6AEGuASt+McKAcjctaWS6Dp0VWfSzD1ktHbowSK_8ua4-R2Q@mail.gmail.com>
On Wed, Jan 11, 2017 at 08:43:16PM -0500, Rob Clark wrote:
> On Wed, Jan 11, 2017 at 7:51 PM, Ben Widawsky <ben@bwidawsk.net> wrote:
> >
> > +struct drm_format_modifier {
> > + /* Bitmask of formats in get_plane format list this info
> > + * applies to. */
> > + uint64_t formats;
>
> re: the uabi, I'd suggest to at least make this 'u32 offset; u32
> formats'.. we can keep the existing implementation in this patch and
> always set 'offset' to zero, and let the first one to hit more than 32
> formats deal with the implementation. (Maybe a strategically placed
> WARN_ON() if you go that route..)
Isn't an implicit offset enough? As in first mask for a specific
modifier is for format indexes 0-63, second mask for the same modifier
is for 64-127, and so on.
The bigger issue is the userspace side I think. If we don't add the
userspace side code to handle this case from the get go, it's going to
be hard to actually start doing it from the kernel side.
>
> Otherwise I guess it is just a couple years until getplane3 ;-)
>
> BR,
> -R
>
> > +
> > + /* This modifier can be used with the format for this plane. */
> > + uint64_t modifier;
> > +};
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-12 9:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 0:51 [PATCH 0/3] GET_PLANE2 w/ i915 implementation Ben Widawsky
2017-01-12 0:51 ` [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2 Ben Widawsky
2017-01-12 1:43 ` [Intel-gfx] " Rob Clark
2017-01-12 9:38 ` Ville Syrjälä [this message]
2017-01-12 14:56 ` Rob Clark
2017-01-12 17:04 ` Daniel Stone
2017-01-12 17:45 ` Ville Syrjälä
2017-01-12 17:50 ` Daniel Stone
2017-01-12 18:11 ` Ville Syrjälä
2017-01-12 19:27 ` Daniel Stone
2017-01-13 9:37 ` [Intel-gfx] " Ville Syrjälä
2017-01-13 9:45 ` Daniel Stone
2017-01-12 10:23 ` [Intel-gfx] " Ville Syrjälä
2023-11-24 15:08 ` Andy Shevchenko
2017-01-25 5:20 ` [PATCH 1/3] [v2] " Ben Widawsky
2017-01-25 15:28 ` Ville Syrjälä
2017-01-26 23:34 ` [PATCH 1/3] [v3] " Ben Widawsky
2017-01-12 0:51 ` [PATCH 2/3] drm/i915: Add format modifiers for Intel Ben Widawsky
2017-01-12 10:51 ` Ville Syrjälä
2017-01-12 18:00 ` Ben Widawsky
2017-01-12 18:32 ` Ville Syrjälä
2017-01-12 18:56 ` Ben Widawsky
2017-01-13 9:35 ` Ville Syrjälä
2017-01-12 0:51 ` [PATCH 3/3] drm/i915: Add support for GET_PLANE2 CCS modifiers Ben Widawsky
2017-01-12 1:01 ` ✗ Fi.CI.BAT: failure for GET_PLANE2 w/ i915 implementation Patchwork
2017-01-12 1:23 ` Ben Widawsky
2017-01-25 6:32 ` ✗ Fi.CI.BAT: failure for GET_PLANE2 w/ i915 implementation (rev2) Patchwork
2017-01-27 1:02 ` ✗ Fi.CI.BAT: failure for GET_PLANE2 w/ i915 implementation (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112093820.GQ31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).