Re: [PATCH 2/5] drm/i915: Ignore bogus plane coordinates on SKL when the plane is not visible

[Matt Roper <matthew.d.roper@intel.com>]

On Tue, Jan 17, 2017 at 02:05:07PM -0800, Matt Roper wrote:
> On Mon, Nov 07, 2016 at 10:20:54PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > When the plane is invisible we may have all sorts of bogus stuff
> > in the coordinates, which we must ignore or else we might fail the
> > plane update. This started to happen on SKL when I moved the plane
> > offset computation to happen in the check phase. Previously we
> > happily ignored it all since we never called the update_plane hook
> > with an invisible plane.
> > 
> > Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
> > Cc: drm-intel-fixes@lists.freedesktop.org
> > Fixes: b63a16f6cd89 ("drm/i915: Compute display surface offset in the plane check hook for SKL+")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Months later, but
> 
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> 
> and
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98258
> Testcase: igt/pm_rpm/legacy-planes
> Testcase: igt/pm_rpm/universal-planes

Your CI results were clean back when you submitted this, and the
functionally identical patch I posted last week also got clean results,
so pushed to dinq.  Thanks for the patch.


Matt

> 
> 
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 40f6f08e0732..e8c40a69bbc4 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -2979,6 +2979,9 @@ int skl_check_plane_surface(struct intel_plane_state *plane_state)
> >  	unsigned int rotation = plane_state->base.rotation;
> >  	int ret;
> >  
> > +	if (!plane_state->base.visible)
> > +		return 0;
> > +
> >  	/* Rotate src coordinates to match rotated GTT view */
> >  	if (drm_rotation_90_or_270(rotation))
> >  		drm_rect_rotate(&plane_state->base.src,
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> (916) 356-2795
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx