From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder Date: Wed, 25 Jan 2017 15:53:46 +0200 Message-ID: <20170125135346.GT31595@intel.com> References: <20170120182205.8141-1-ville.syrjala@linux.intel.com> <20170120182205.8141-5-ville.syrjala@linux.intel.com> <20170124122900.hd5cmzbzll7vkplp@boom> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C9A66E1A9 for ; Wed, 25 Jan 2017 13:53:51 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170124122900.hd5cmzbzll7vkplp@boom> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMjQsIDIwMTcgYXQgMDI6Mjk6MDBQTSArMDIwMCwgRGF2aWQgV2VpbmVoYWxs IHdyb3RlOgo+IE9uIEZyaSwgSmFuIDIwLCAyMDE3IGF0IDA4OjIxOjU1UE0gKzAyMDAsIHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gTGV0J3MgY2xlYW4gdXAg dGhlIG1lc3Mgd2UgaGF2ZSBpbiB0aGUgaWYgbGFkZGVyIHRoYXQgYXNzaWducyB0aGUKPiA+IC5n ZXRfY2RjbGsoKSBob29rcy4gVGhlIGdyb3VwaW5nIG9mIHRoZSBwbGF0Zm9ybXMgYnkgdGhlIGZ1 bmN0aW9uCj4gPiByZXN1bHRzIGluIGEgdGhpbmcgdGhhdCdzIG5vdCByZWFsbHkgbGVnaWJsZSwg c28gbGV0J3MgZG8gaXQgdGhlCj4gPiBvdGhlciB3YXkgYXJvdW5kIGFuZCBvcmRlciB0aGUgaWYg bGFkZGVyIGJ5IHBsYXRmb3JtIGFuZCBkdXBsaWNhdGUKPiA+IHdoYXRldmVyIGFzc2lnbm1lbnRz IHdlIG5lZWQuCj4gPiAKPiA+IFRvIGZ1cnRoZXIgYXZvaWQgY29uZnVzaW9uIHdpdGggdGhlIGZ1 bmN0aW9uIG5hbWVzIGxldCdzIHJlbmFtZQo+ID4gdGhlbSB0byBqdXN0IGZpeGVkXzxmcmVxPl9n ZXRfY2RjbGsoKS4gVGhlIG90aGVyIG9wdGlvbiB3b3VsZAo+ID4gYmUgdG8gZHVwbGljYXRlIHRo ZSBmdW5jdGlvbnMgZW50aXJlbHkgYnV0IGl0IHNlZW1zIHF1aXRlCj4gPiBwb2ludGxlc3MgdG8g ZG8gdGhhdCBzaW5jZSBlYWNoIG9uZSBqdXN0IHJldHVybnMgYSBmaXhlZCB2YWx1ZS4KPiA+IAo+ ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGNv bnNlbHZhbjJAZ21haWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIHwgNDEgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCBiZDBmZGMwNGJj OTIuLjY2OGM2MWFkNDVhNiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPiBAQCAtNzM2NiwyMiArNzM2NiwyMiBAQCBzdGF0aWMgaW50IHZhbGxleXZpZXdfZ2V0 X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJCQkJICAgICAg Q0NLX0RJU1BMQVlfQ0xPQ0tfQ09OVFJPTCk7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBpbnQg aWxrX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiArc3Rh dGljIGludCBmaXhlZF80NTBtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiA+ICB7Cj4gPiAgCXJldHVybiA0NTAwMDA7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0 YXRpYyBpbnQgaTk0NV9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ID4gK3N0YXRpYyBpbnQgZml4ZWRfNDAwbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgewo+ID4gIAlyZXR1cm4gNDAwMDAwOwo+ID4gIH0KPiA+ ICAKPiA+IC1zdGF0aWMgaW50IGk5MTVfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiA+ICtzdGF0aWMgaW50IGZpeGVkXzMzM21oel9nZXRfY2RjbGsoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+ICAJcmV0dXJuIDMzMzMzMzsK PiA+ICB9Cj4gPiAgCj4gPiAtc3RhdGljIGludCBpOXh4X21pc2NfZ2V0X2NkY2xrKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICtzdGF0aWMgaW50IGZpeGVkXzIwMG1oel9n ZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+ICAJ cmV0dXJuIDIwMDAwMDsKPiA+ICB9Cj4gPiBAQCAtNzQzMSw3ICs3NDMxLDcgQEAgc3RhdGljIGlu dCBpOTE1Z21fZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ ICAJfQo+ID4gIH0KPiA+ICAKPiA+IC1zdGF0aWMgaW50IGk4NjVfZ2V0X2NkY2xrKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICtzdGF0aWMgaW50IGZpeGVkXzI2Nm1oel9n ZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+ICAJ cmV0dXJuIDI2NjY2NzsKPiA+ICB9Cj4gCj4gSG93IGFib3V0IHJlb3JkZXJpbmcgdGhpcyBhbmQg dGhlIG9uZSBhYm92ZSB0byBoYXZlIHRoZSBjbG9ja3MgaW4KPiBzdHJpY3RseSBkZXNjZW5kaW5n IG9yZGVyPwoKSXQgZ2V0cyByZW9yZGVyZWQgaW4gdGhlIHBhdGNoIHRoYXQgbW92ZXMgaXQgYWxs IGludG8gYSBuZXcgZmlsZS4KCj4gCj4gPiBAQCAtNzQ3NCw3ICs3NDc0LDcgQEAgc3RhdGljIGlu dCBpODV4X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAg CXJldHVybiAwOwo+ID4gIH0KPiAKPiBTaW1pbGFybHksIG1vdmUgdGhpcyBvbmUgZG93bi4KPiAK PiA+IC1zdGF0aWMgaW50IGk4MzBfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiA+ICtzdGF0aWMgaW50IGZpeGVkXzEzM21oel9nZXRfY2RjbGsoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+ICAJcmV0dXJuIDEzMzMzMzsKPiA+ ICB9Cj4gPiBAQCAtMTYxODAsMzIgKzE2MTgwLDM5IEBAIHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5 X2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJCWRldl9wcml2 LT5kaXNwbGF5LmdldF9jZGNsayA9IGhhc3dlbGxfZ2V0X2NkY2xrOwo+ID4gIAllbHNlIGlmIChJ U19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPiA+ICAJ CWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IHZhbGxleXZpZXdfZ2V0X2NkY2xrOwo+ID4g KwllbHNlIGlmIChJU19HRU42KGRldl9wcml2KSB8fCBJU19JVllCUklER0UoZGV2X3ByaXYpKQo+ ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfNDAwbWh6X2dldF9jZGNs azsKPiA+ICAJZWxzZSBpZiAoSVNfR0VONShkZXZfcHJpdikpCj4gPiAtCQlkZXZfcHJpdi0+ZGlz cGxheS5nZXRfY2RjbGsgPSBpbGtfZ2V0X2NkY2xrOwo+ID4gLQllbHNlIGlmIChJU19JOTQ1Ryhk ZXZfcHJpdikgfHwgSVNfSTk2NUcoZGV2X3ByaXYpIHx8Cj4gPiAtCQkgSVNfR0VONihkZXZfcHJp dikgfHwgSVNfSVZZQlJJREdFKGRldl9wcml2KSkKPiA+IC0JCWRldl9wcml2LT5kaXNwbGF5Lmdl dF9jZGNsayA9IGk5NDVfZ2V0X2NkY2xrOwo+ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gZml4ZWRfNDUwbWh6X2dldF9jZGNsazsKPiA+ICAJZWxzZSBpZiAoSVNfR000NShkZXZf cHJpdikpCj4gPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBnbTQ1X2dldF9jZGNs azsKPiA+ICsJZWxzZSBpZiAoSVNfRzRYKGRldl9wcml2KSkKPiA+ICsJCWRldl9wcml2LT5kaXNw bGF5LmdldF9jZGNsayA9IGczM19nZXRfY2RjbGs7Cj4gPiAgCWVsc2UgaWYgKElTX0k5NjVHTShk ZXZfcHJpdikpCj4gPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTY1Z21fZ2V0 X2NkY2xrOwo+ID4gKwllbHNlIGlmIChJU19JOTY1RyhkZXZfcHJpdikpCj4gPiArCQlkZXZfcHJp di0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF80MDBtaHpfZ2V0X2NkY2xrOwo+ID4gIAllbHNl IGlmIChJU19QSU5FVklFVyhkZXZfcHJpdikpCj4gPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRf Y2RjbGsgPSBwbnZfZ2V0X2NkY2xrOwo+ID4gLQllbHNlIGlmIChJU19HMzMoZGV2X3ByaXYpIHx8 IElTX0c0WChkZXZfcHJpdikpCj4gPiArCWVsc2UgaWYgKElTX0czMyhkZXZfcHJpdikpCj4gPiAg CQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBnMzNfZ2V0X2NkY2xrOwo+ID4gLQllbHNl IGlmIChJU19JOTE1RyhkZXZfcHJpdikpCj4gPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2Rj bGsgPSBpOTE1X2dldF9jZGNsazsKPiA+IC0JZWxzZSBpZiAoSVNfSTk0NUdNKGRldl9wcml2KSB8 fCBJU19JODQ1RyhkZXZfcHJpdikpCj4gPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsg PSBpOXh4X21pc2NfZ2V0X2NkY2xrOwo+ID4gKwllbHNlIGlmIChJU19JOTQ1R00oZGV2X3ByaXYp KQo+ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfMjAwbWh6X2dldF9j ZGNsazsKPiA+ICsJZWxzZSBpZiAoSVNfSTk0NUcoZGV2X3ByaXYpKQo+ID4gKwkJZGV2X3ByaXYt PmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfNDAwbWh6X2dldF9jZGNsazsKPiA+ICAJZWxzZSBp ZiAoSVNfSTkxNUdNKGRldl9wcml2KSkKPiA+ICAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNs ayA9IGk5MTVnbV9nZXRfY2RjbGs7Cj4gPiArCWVsc2UgaWYgKElTX0k5MTVHKGRldl9wcml2KSkK PiA+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzMzM21oel9nZXRfY2Rj bGs7Cj4gPiAgCWVsc2UgaWYgKElTX0k4NjVHKGRldl9wcml2KSkKPiA+IC0JCWRldl9wcml2LT5k aXNwbGF5LmdldF9jZGNsayA9IGk4NjVfZ2V0X2NkY2xrOwo+ID4gKwkJZGV2X3ByaXYtPmRpc3Bs YXkuZ2V0X2NkY2xrID0gZml4ZWRfMjY2bWh6X2dldF9jZGNsazsKPiA+ICAJZWxzZSBpZiAoSVNf STg1WChkZXZfcHJpdikpCj4gPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODV4 X2dldF9jZGNsazsKPiA+ICsJZWxzZSAgaWYgKElTX0k4NDVHKGRldl9wcml2KSkKPiA+ICsJCWRl dl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzIwMG1oel9nZXRfY2RjbGs7Cj4gPiAg CWVsc2UgeyAvKiA4MzAgKi8KPiA+ICAJCVdBUk4oIUlTX0k4MzAoZGV2X3ByaXYpLCAiVW5rbm93 biBwbGF0Zm9ybS4gQXNzdW1pbmcgMTMzIE1IeiBDRENMS1xuIik7Cj4gPiAtCQlkZXZfcHJpdi0+ ZGlzcGxheS5nZXRfY2RjbGsgPSBpODMwX2dldF9jZGNsazsKPiA+ICsJCWRldl9wcml2LT5kaXNw bGF5LmdldF9jZGNsayA9IGZpeGVkXzEzM21oel9nZXRfY2RjbGs7Cj4gPiAgCX0KPiA+ICAKPiA+ ICAJaWYgKElTX0dFTjUoZGV2X3ByaXYpKSB7Cj4gPiAtLSAKPiA+IDIuMTAuMgo+ID4gCj4gPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=