intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.
Date: Thu, 26 Jan 2017 18:39:29 +0200	[thread overview]
Message-ID: <20170126163929.GI31595@intel.com> (raw)
In-Reply-To: <1485446364-19174-1-git-send-email-maarten.lankhorst@linux.intel.com>

On Thu, Jan 26, 2017 at 04:59:21PM +0100, Maarten Lankhorst wrote:
> When writing some testcases for nonblocking modesets. I found out that the
> infinite wait on the old fb was causing issues.
> 
> A nonblocking modeset with a hang on the old fb, followed by a blocking
> update was enough to trigger it.
> 
> For old platforms patch 2 is needed else
> kms_busy.extended-modeset-hang-oldfb-*
> will put the gpu in a bad state when the 90s in swap_state is reached,
> for newer platforms patch 3 will fix this. The display doesn't need to be
> reset when there are no CS flips and no display reset.
> 
> If you have a newer platform, (gen4+) then the display reset can be

g4x+

> simulated with the kms_busy.extended-modeset-hang-oldfb-with-reset-* test.
> 
> Maarten Lankhorst (3):
>   drm/atomic: Bump timeout for waiting for hw_done to 90s in swap_state
>   drm/i915: Set a timeout when waiting for fence on the old fb
>   drm/i915: Skip modeset locking when atomic pageflips are used.
> 
>  drivers/gpu/drm/drm_atomic_helper.c  | 12 ++++++++----
>  drivers/gpu/drm/i915/intel_display.c | 14 +++++++++++++-
>  2 files changed, 21 insertions(+), 5 deletions(-)
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-01-26 16:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 15:59 [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly Maarten Lankhorst
2017-01-26 15:59 ` [PATCH 1/3] drm/atomic: Bump timeout for waiting for hw_done to 90s in swap_state Maarten Lankhorst
2017-01-26 15:59 ` [PATCH 2/3] drm/i915: Set a timeout when waiting for fence on the old fb Maarten Lankhorst
2017-01-26 15:59 ` [PATCH 3/3] drm/i915: Skip modeset locking when atomic pageflips are used Maarten Lankhorst
2017-01-26 16:39 ` Ville Syrjälä [this message]
2017-01-27  9:30 ` [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly Chris Wilson
2017-01-27 14:21   ` Daniel Vetter
2017-01-27 14:31     ` Chris Wilson
2017-01-27 14:58       ` [Intel-gfx] " Daniel Vetter
2017-01-27 15:08         ` Chris Wilson
2017-01-30  8:17           ` Daniel Vetter
2017-01-30 14:42             ` Maarten Lankhorst
2017-01-31  7:46               ` [Intel-gfx] " Daniel Vetter
2017-01-31  9:11                 ` Maarten Lankhorst
2017-01-30 15:25             ` [PATCH] drm/i915: Skip modeset locking when atomic pageflips are used Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170126163929.GI31595@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).