From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/atomic: move waiting for hw_done to a helper Date: Thu, 26 Jan 2017 20:29:15 +0200 Message-ID: <20170126182915.GL31595@intel.com> References: <1483981618-10233-1-git-send-email-maarten.lankhorst@linux.intel.com> <1483981618-10233-2-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1483981618-10233-2-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMDksIDIwMTcgYXQgMDY6MDY6NTZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhpcyB3aWxsIGFsbG93IGk5MTUgdG8gcGVyZm9ybSBhIHdhaXQgb24gcGVu ZGluZyBtb2Rlc2V0IHVzaW5nIHRoZQo+IHNhbWUgY29kZS4KCkkgZG9uJ3QgbGlrZSBjb21taXQg bWVzc2FnZXMgdGhhdCByZWZlciB0byB0aGUgc3ViamVjdCBsaWtlIHRoaXMuIEkKY2FuJ3QgZXZl biBzZWUgdGhlIHN1YmplY3Qgd2hlbiBJJ20gcmVwbHlpbmcgc28gSSBoYXZlIGFwcHJveGltYXRl bHkKemVybyBpZGVhIHdoYXQncyBiZWluZyBzYWlkIGhlcmUuCgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgNTEgKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICBpbmNsdWRlL2RybS9kcm1fYXRvbWljX2hl bHBlci5oICAgICB8ICAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAx NCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4 IDdiNzFhYzQ4YjhhNC4uM2E4YTQ2NTEwYzM2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNf aGVscGVyLmMKPiBAQCAtMTkzNiw2ICsxOTM2LDQxIEBAIHZvaWQgZHJtX2F0b21pY19oZWxwZXJf Y2xlYW51cF9wbGFuZXMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgRVhQT1JUX1NZTUJPTChk cm1fYXRvbWljX2hlbHBlcl9jbGVhbnVwX3BsYW5lcyk7Cj4gIAo+ICAvKioKPiArICogZHJtX2F0 b21pY19oZWxwZXJfd2FpdF9mb3JfaHdfZG9uZSAtIHdhaXQgZm9yIGFsbCBwcmV2aW91cyBodyB1 cGRhdGVzIHRvIGNvbXBsZXRlLgo+ICsgKiBAY3J0YzogY3J0YyB0byB3YWl0IG9uLgo+ICsgKgo+ ICsgKiBUaGlzIGZ1bmN0aW9uIHdhaXRzIGZvciBhbGwgcHJldmlvdXMgaGFyZHdhcmUgdXBkYXRl cyBxdWV1ZWQgb24gQGNydGMKPiArICogdG8gY29tcGxldGUuCj4gKyAqCj4gKyAqIFJldHVybnM6 Cj4gKyAqIDAgb24gc3VjY2VzcywgbmVnYXRpdmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ICsg Ki8KPiAraW50IGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2h3X2RvbmUoc3RydWN0IGRybV9j cnRjICpjcnRjKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfY29tbWl0ICpjb21taXQ7Cj4gKwls b25nIHJldDsKPiArCj4gKwlzcGluX2xvY2soJmNydGMtPmNvbW1pdF9sb2NrKTsKPiArCWNvbW1p dCA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmY3J0Yy0+Y29tbWl0X2xpc3QsCj4gKwkJCXN0 cnVjdCBkcm1fY3J0Y19jb21taXQsIGNvbW1pdF9lbnRyeSk7Cj4gKwlpZiAoY29tbWl0KQo+ICsJ CWRybV9jcnRjX2NvbW1pdF9nZXQoY29tbWl0KTsKPiArCXNwaW5fdW5sb2NrKCZjcnRjLT5jb21t aXRfbG9jayk7Cj4gKwo+ICsJaWYgKCFjb21taXQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJcmV0 ID0gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0KCZjb21taXQtPmh3X2RvbmUsIDEwICogSFop Owo+ICsJZHJtX2NydGNfY29tbWl0X3B1dChjb21taXQpOwo+ICsKPiArCWlmIChyZXQgPT0gMCkK PiArCQlyZXR1cm4gLUVCVVNZOwo+ICsKPiArCXJldHVybiByZXQgPiAwID8gMCA6IHJldDsKPiAr fQo+ICtFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2h3X2RvbmUpOwoK U2VlbXMgc2FuZSBlbm91Z2guIEkgd2FzIHBvbmRlcmluZyBpZiB3ZSBjb3VsZCBzaGFyZSB0aGUg Y29kZSB3aXRoIHRoZQpvdGhlciBod19kb25lIHdhaXQgYXMgd2VsbC4gQnV0IGl0IGdyYWJzIGEg ZGlmZmVyZW50IGNvbW1pdCBmcm9tIHRoZQpsaXN0LCBzbyBub3Qgc3VyZSBpZiB3ZSdkIGVuZCB1 cCB3aXRoIGxlc3MgY29kZSBvciBub3QuCgpIbW0uIG1heWJlIHBhc3MgdGhlIGNvbW1pdCBpbmRl eCBmcm9tIHRoZSBjYWxsZXIgYWxsIHRoZSB3YXkgZnJvbSB0aGUKY2FsbGVyIHRvIHByZWNlZWRp bmdfY29tbWl0KCkgKHdoaWNoIHdvdWxkIG9idmlvdXNseSBuZWVkIGEgcmVuYW1lKT8KCj4gKwo+ ICsvKioKPiAgICogZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZSAtIHN0b3JlIGF0b21pYyBz dGF0ZSBpbnRvIGN1cnJlbnQgc3cgc3RhdGUKPiAgICogQHN0YXRlOiBhdG9taWMgc3RhdGUKPiAg ICogQHN0YWxsOiBzdGFsbCBmb3IgcHJvY2VlZGluZyBjb21taXRzCj4gQEAgLTE5NzYsMjYgKzIw MTEsMTQgQEAgdm9pZCBkcm1fYXRvbWljX2hlbHBlcl9zd2FwX3N0YXRlKHN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZSwKPiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsK PiAgCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ICAJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAq cGxhbmVfc3RhdGU7Cj4gLQlzdHJ1Y3QgZHJtX2NydGNfY29tbWl0ICpjb21taXQ7Cj4gIAo+ICAJ aWYgKHN0YWxsKSB7Cj4gIAkJZm9yX2VhY2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0 Y19zdGF0ZSwgaSkgewo+IC0JCQlzcGluX2xvY2soJmNydGMtPmNvbW1pdF9sb2NrKTsKPiAtCQkJ Y29tbWl0ID0gbGlzdF9maXJzdF9lbnRyeV9vcl9udWxsKCZjcnRjLT5jb21taXRfbGlzdCwKPiAt CQkJCQlzdHJ1Y3QgZHJtX2NydGNfY29tbWl0LCBjb21taXRfZW50cnkpOwo+IC0JCQlpZiAoY29t bWl0KQo+IC0JCQkJZHJtX2NydGNfY29tbWl0X2dldChjb21taXQpOwo+IC0JCQlzcGluX3VubG9j aygmY3J0Yy0+Y29tbWl0X2xvY2spOwo+ICsJCQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl93YWl0 X2Zvcl9od19kb25lKGNydGMpOwo+ICAKPiAtCQkJaWYgKCFjb21taXQpCj4gLQkJCQljb250aW51 ZTsKPiAtCj4gLQkJCXJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91dCgmY29tbWl0LT5o d19kb25lLAo+IC0JCQkJCQkJICAxMCpIWik7Cj4gLQkJCWlmIChyZXQgPT0gMCkKPiArCQkJaWYg KHJldCA8IDApCj4gIAkJCQlEUk1fRVJST1IoIltDUlRDOiVkOiVzXSBod19kb25lIHRpbWVkIG91 dFxuIiwKPiAgCQkJCQkgIGNydGMtPmJhc2UuaWQsIGNydGMtPm5hbWUpOwo+IC0JCQlkcm1fY3J0 Y19jb21taXRfcHV0KGNvbW1pdCk7Cj4gIAkJfQo+ICAJfQo+ICAKPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVs cGVyLmgKPiBpbmRleCA0YjIzNTNkYzM0YmEuLmUxNWQyZmU3YjI3NCAxMDA2NDQKPiAtLS0gYS9p bmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuaAo+IEBAIC03Nyw2ICs3Nyw3IEBAIHZvaWQKPiAgZHJtX2F0b21pY19oZWxw ZXJfZGlzYWJsZV9wbGFuZXNfb25fY3J0YyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRj X3N0YXRlLAo+ICAJCQkJCSBib29sIGF0b21pYyk7Cj4gIAo+ICtpbnQgZHJtX2F0b21pY19oZWxw ZXJfd2FpdF9mb3JfaHdfZG9uZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpOwo+ICB2b2lkIGRybV9h dG9taWNfaGVscGVyX3N3YXBfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ ICAJCQkJICBib29sIHN0YWxsKTsKPiAgCj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=