From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Wait for pending modesets to complete before trying link training Date: Thu, 26 Jan 2017 20:31:58 +0200 Message-ID: <20170126183158.GM31595@intel.com> References: <1483981618-10233-1-git-send-email-maarten.lankhorst@linux.intel.com> <1483981618-10233-3-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1483981618-10233-3-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMDksIDIwMTcgYXQgMDY6MDY6NTdQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gV2UncmUgcHJvdGVjdGVkIGJ5IHRoZSBjb25uZWN0aW9uX211dGV4IGxvY2sg YWdhaW5zdCBibG9ja2luZyBtb2Rlc2V0cywKPiBidXQgbm9uYmxvY2tpbmcgbW9kZXNldHMgYXJl IHBlcmZvcm1lZCB3aXRob3V0IGFueSBsb2NraW5nLiBUaGlzIGlzCj4gY2F1c2luZyBXQVJOIGlu IGRybV93YWl0X2Zvcl92YmxhbmsgYW5kIGluIGdlbmVyYWwgaXQncyBiZXR0ZXIgdG8gd2FpdAo+ IGJlZm9yZSBtb2Rlc2V0IGNvbXBsZXRlcyBiZWZvcmUgdHJ5aW5nIGFueXRoaW5nLgo+IAo+IFNp Z25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5p bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCA1MSAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMzkgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4gaW5kZXggZmIxMjg5NmJhZmVlLi43MTg4MmQ4ODczOTMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMKPiBAQCAtNDA4MCwyNCArNDA4MCwzOCBAQCBpbnRlbF9kcF9jaGVja19s aW5rX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJc3RydWN0IGludGVsX2Vu Y29kZXIgKmludGVsX2VuY29kZXIgPSAmZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApLT5iYXNlOwo+ ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RwX3RvX2RldihpbnRlbF9kcCk7Cj4g IAl1OCBsaW5rX3N0YXR1c1tEUF9MSU5LX1NUQVRVU19TSVpFXTsKPiArCXN0cnVjdCBkcm1fbW9k ZXNldF9hY3F1aXJlX2N0eCBjdHg7Cj4gKwlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICppbnRlbF9j b25uZWN0b3IgPSBpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yOwo+ICsJaW50IHJldDsKPiAr CXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiAgCj4gLQlXQVJOX09OKCFkcm1fbW9kZXNldF9pc19s b2NrZWQoJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCkpOwo+ICsJZHJtX21vZGVz ZXRfYWNxdWlyZV9pbml0KCZjdHgsIDApOwo+ICsKPiArcmV0cnk6Cj4gKwlyZXQgPSBkcm1fbW9k ZXNldF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgsICZjdHgpOwo+ICsJ aWYgKHJldCkKPiArCQlnb3RvIG91dDsKPiAgCj4gIAlpZiAoIWludGVsX2RwX2dldF9saW5rX3N0 YXR1cyhpbnRlbF9kcCwgbGlua19zdGF0dXMpKSB7Cj4gIAkJRFJNX0VSUk9SKCJGYWlsZWQgdG8g Z2V0IGxpbmsgc3RhdHVzXG4iKTsKPiAtCQlyZXR1cm47Cj4gKwkJZ290byBvdXQ7Cj4gIAl9Cj4g IAo+IC0JaWYgKCFpbnRlbF9lbmNvZGVyLT5iYXNlLmNydGMpCj4gLQkJcmV0dXJuOwo+ICsJY3J0 YyA9IGludGVsX2Nvbm5lY3Rvci0+YmFzZS5zdGF0ZS0+Y3J0YzsKPiArCWlmICghY3J0YykKPiAr CQlnb3RvIG91dDsKPiAgCj4gLQlpZiAoIXRvX2ludGVsX2NydGMoaW50ZWxfZW5jb2Rlci0+YmFz ZS5jcnRjKS0+YWN0aXZlKQo+IC0JCXJldHVybjsKPiArCXJldCA9IGRybV9tb2Rlc2V0X2xvY2so JmNydGMtPm11dGV4LCAmY3R4KTsKPiArCWlmIChyZXQpCj4gKwkJZ290byBvdXQ7Cj4gKwo+ICsJ aWYgKCFjcnRjLT5zdGF0ZS0+YWN0aXZlKQo+ICsJCWdvdG8gb3V0Owo+ICAKPiAgCS8qIEZJWE1F OiB3ZSBuZWVkIHRvIHN5bmNocm9uaXplIHRoaXMgc29ydCBvZiBzdHVmZiB3aXRoIGhhcmR3YXJl Cj4gIAkgKiByZWFkb3V0LiBDdXJyZW50bHkgZmFzdCBsaW5rIHRyYWluaW5nIGRvZXNuJ3Qgd29y ayBvbiBib290LXVwLiAqLwo+ICAJaWYgKCFpbnRlbF9kcC0+bGFuZV9jb3VudCkKPiAtCQlyZXR1 cm47Cj4gKwkJZ290byBvdXQ7Cj4gIAo+ICAJLyogaWYgbGluayB0cmFpbmluZyBpcyByZXF1ZXN0 ZWQgd2Ugc2hvdWxkIHBlcmZvcm0gaXQgYWx3YXlzICovCj4gIAlpZiAoKGludGVsX2RwLT5jb21w bGlhbmNlLnRlc3RfdHlwZSA9PSBEUF9URVNUX0xJTktfVFJBSU5JTkcpIHx8Cj4gQEAgLTQxMDUs OCArNDExOSwyNiBAQCBpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwKQo+ICAJCURSTV9ERUJVR19LTVMoIiVzOiBjaGFubmVsIEVRIG5vdCBvaywgcmV0 cmFpbmluZ1xuIiwKPiAgCQkJICAgICAgaW50ZWxfZW5jb2Rlci0+YmFzZS5uYW1lKTsKPiAgCj4g KwkJaWYgKGRybV9hdG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KGNydGMtPnN0YXRlKSkgewo+ICsJ CQkvKiB3YWl0IGZvciBhdG9taWMgbW9kZXNldCB0byBjb21wbGV0ZSAqLwo+ICsJCQlyZXQgPSBk cm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9od19kb25lKGNydGMpOwo+ICsJCQlpZiAocmV0IDwg MCkKPiArCQkJCURSTV9FUlJPUigiV2FpdGluZyBmb3IgaHdfZG9uZSB0aW1lZCBvdXRcbiIpOwoK SSB3b25kZXIgaWYgd2Ugc2hvdWxkIGp1c3Qgc2tpcCB0aGUgaHcgZnJvYmJpbmcgaW4gdGhpcyBj YXNlLiBJIGd1ZXNzIGl0Cm1pZ2h0IHN0aWxsIHJlc3RvcmUgdGhlIGxpbmsgaWYgdGhlIGNvbW1p dCBqdXN0IHNvbWVob3cgZ290IHN0dWNrCnNvbWV3aGVyZSBub24tY3JpdGljYWwuCgo+ICsJCX0K PiArCj4gIAkJaW50ZWxfZHBfcmV0cmFpbl9saW5rKGludGVsX2RwKTsKPiAgCX0KPiArCj4gK291 dDoKPiArCWlmIChyZXQgPT0gLUVERUFETEspIHsKPiArCQlkcm1fbW9kZXNldF9iYWNrb2ZmKCZj dHgpOwo+ICsJCWdvdG8gcmV0cnk7Cj4gKwl9Cj4gKwo+ICsJZHJtX21vZGVzZXRfZHJvcF9sb2Nr cygmY3R4KTsKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiArCWlmIChyZXQp Cj4gKwkJRFJNX0VSUk9SKCJMb2NraW5nIGZhaWxlZCB3aXRoICVpXG4iLCByZXQpOwoKVGhpcyBz ZWVtcyBpbmNvcnJlY3QgaWYgd2UgdGltZWQgb3V0IG9uIHRoZSB3YWl0LiBNYXliZSBqdXN0CmNs ZWFyIHJldCBhZnRlciB0aGUgaHdfZG9uZSB3YWl0PwoKPiAgfQo+ICAKPiAgLyoKPiBAQCAtNDEy NSw3ICs0MTU3LDYgQEAgaW50ZWxfZHBfY2hlY2tfbGlua19zdGF0dXMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCkKPiAgc3RhdGljIGJvb2wKPiAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCkKPiAgewo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGlu dGVsX2RwX3RvX2RldihpbnRlbF9kcCk7Cj4gIAl1OCBzaW5rX2lycV92ZWN0b3IgPSAwOwo+ICAJ dTggb2xkX3NpbmtfY291bnQgPSBpbnRlbF9kcC0+c2lua19jb3VudDsKPiAgCWJvb2wgcmV0Owo+ IEBAIC00MTY0LDkgKzQxOTUsNyBAQCBpbnRlbF9kcF9zaG9ydF9wdWxzZShzdHJ1Y3QgaW50ZWxf ZHAgKmludGVsX2RwKQo+ICAJCQlEUk1fREVCVUdfRFJJVkVSKCJDUCBvciBzaW5rIHNwZWNpZmlj IGlycSB1bmhhbmRsZWRcbiIpOwo+ICAJfQo+ICAKPiAtCWRybV9tb2Rlc2V0X2xvY2soJmRldi0+ bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCwgTlVMTCk7Cj4gIAlpbnRlbF9kcF9jaGVja19s aW5rX3N0YXR1cyhpbnRlbF9kcCk7Cj4gLQlkcm1fbW9kZXNldF91bmxvY2soJmRldi0+bW9kZV9j b25maWcuY29ubmVjdGlvbl9tdXRleCk7Cj4gIAo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPiBAQCAt NDQ5OSw5ICs0NTI4LDcgQEAgaW50ZWxfZHBfbG9uZ19wdWxzZShzdHJ1Y3QgaW50ZWxfY29ubmVj dG9yICppbnRlbF9jb25uZWN0b3IpCj4gIAkJICogY2hlY2sgbGlua3Mgc3RhdHVzLCB0aGVyZSBo YXMgYmVlbiBrbm93biBpc3N1ZXMgb2YKPiAgCQkgKiBsaW5rIGxvc3MgdHJpZ2dlcnJpbmcgbG9u ZyBwdWxzZSEhISEKPiAgCQkgKi8KPiAtCQlkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29u ZmlnLmNvbm5lY3Rpb25fbXV0ZXgsIE5VTEwpOwo+ICAJCWludGVsX2RwX2NoZWNrX2xpbmtfc3Rh dHVzKGludGVsX2RwKTsKPiAtCQlkcm1fbW9kZXNldF91bmxvY2soJmRldi0+bW9kZV9jb25maWcu Y29ubmVjdGlvbl9tdXRleCk7Cj4gIAkJZ290byBvdXQ7Cj4gIAl9Cj4gIAo+IC0tIAo+IDIuNy40 Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBk cmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK