From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Arthur Heymans <arthur@aheymans.xyz>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Get correct display clock on 945gm
Date: Fri, 27 Jan 2017 18:57:19 +0200 [thread overview]
Message-ID: <20170127165719.GH31595@intel.com> (raw)
In-Reply-To: <87vat01mgd.fsf@aheymans.xyz>
On Fri, Jan 27, 2017 at 05:45:06PM +0100, Arthur Heymans wrote:
> Ville Syrjälä <ville.syrjala@linux.intel.com> writes:
>
> > On Fri, Jan 27, 2017 at 03:44:27PM +0100, Arthur Heymans wrote:
> >
> > That indeed is what the docs say.
> >
> > The code is tantalizingly close to the 915gm code now, so maybe
> > we could share it with a simple
> >
> > if (IS_915GM(dev_priv))
> > return 320000;
> > else
> > return 333333;
> >
>
> Agreed but it's the other way around ;)
Indeed. Apparently my brain can't reconcile the fact that the older part
is faster.
>
> > Now if someone could figure out where to dig up the DDR and FSB clocks
> > we could also fix up the 190 vs. 200 MHz case...
> >
> >> + default:
> >> + case GC_DISPLAY_CLOCK_190_200_MHZ:
> >> + return 200000;
> >> + }
> >> + }
> >> +}
> >> +
>
> Hmm that seems to be 915gm specific (always 200 on 945gm). According to
> "Mobile Intel® 915/910 Express Chipset: Datasheet", the only fsb/dram
> combo that has 190MHz is FSB: 533MHz, DDR333. All the other supported
> combos have 200Mhz set by that configuration.
Yeah. Unfortunately I couldn't find a solid source of FSB/DDR clock
information in the spec, apart from the actual strap pins but I can't
see any register that would reflect those. So I guess we'll just leave
it the way it is.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-27 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 14:44 [PATCH] drm/i915: Get correct display clock on 945gm Arthur Heymans
2017-01-27 16:23 ` Ville Syrjälä
2017-01-27 16:45 ` Arthur Heymans
2017-01-27 16:57 ` Ville Syrjälä [this message]
2017-01-27 17:24 ` Arthur Heymans
2017-01-27 19:51 ` Ville Syrjälä
2017-01-30 9:31 ` Daniel Vetter
2017-01-27 20:15 ` kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2017-01-31 23:50 Arthur Heymans
2017-02-07 18:04 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127165719.GH31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=arthur@aheymans.xyz \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).