Re: [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1539 bytes --]

On Mon, Jan 30, 2017 at 11:33:10AM +0200, Mika Westerberg wrote:
> On Mon, Jan 30, 2017 at 09:28:09AM +0100, Rafael J. Wysocki wrote:
> > On Mon, Jan 30, 2017 at 9:18 AM, Thierry Reding
> > <thierry.reding@gmail.com> wrote:
> > > On Sun, Jan 22, 2017 at 05:14:09PM +0100, Hans de Goede wrote:
> > >> On x86 we do not have devicetree to link the PWM controller and
> > >> the display controller together. So someone needs to call
> > >> pwm_add_table() to create the link, so that the i915 driver's
> > >> pwm_get(dev, "pwm_backlight") call returns the lpss' pwm0.
> > >>
> > >> The PWM subsystem does not want to have pwm_add_table() calls
> > >> directly in PWM drivers (this leads to probe ordering issues),
> > >> so lets do it here since the acpi-lpss code is always builtin.
> > >>
> > >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > >> Acked-by: Thierry Reding <thierry.reding@gmail.com>
> > >> ---
> > >> Changes in v2:
> > >> -Set new pwm_lookup module_name field in the table
> > >> ---
> > >>  drivers/acpi/acpi_lpss.c | 13 +++++++++++++
> > >>  1 file changed, 13 insertions(+)
> > >
> > > Rafael, do you mind if I take this through the PWM tree to resolve the
> > > build-time dependency?
> > 
> > No, I don't, please go ahead, unless Mika/Andy see any problems in it.
> 
> No problems from my side - looks good.

I've pulled this into a separate branch that also contains the
prerequisites, so if you ever need this in ACPI, I can provide a stable
branch or tag.

Thanks,
Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx