From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 5/5] drm/i915/glk: Enable pipe CSC
Date: Mon, 30 Jan 2017 18:30:17 +0200 [thread overview]
Message-ID: <20170130163017.GR31595@intel.com> (raw)
In-Reply-To: <1485429865-10687-6-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Thu, Jan 26, 2017 at 01:24:25PM +0200, Ander Conselvan de Oliveira wrote:
> Now that the pre-csc degamma table is set up correctly in Geminilake,
> pipe CSC can be enabled without causing a black screen.
>
> v2: Rebase.
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 +
> drivers/gpu/drm/i915/intel_sprite.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 13d05bc..3eee44a 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3391,6 +3391,7 @@ static void skylake_update_primary_plane(struct drm_plane *plane,
> if (IS_GEMINILAKE(dev_priv)) {
> I915_WRITE(PLANE_COLOR_CTL(pipe, plane_id),
> PLANE_COLOR_PIPE_GAMMA_ENABLE |
> + PLANE_COLOR_PIPE_CSC_ENABLE |
> PLANE_COLOR_PLANE_GAMMA_DISABLE);
> } else {
> plane_ctl |=
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index b16a295..27e0752 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -224,6 +224,7 @@ skl_update_plane(struct drm_plane *drm_plane,
> if (IS_GEMINILAKE(dev_priv)) {
> I915_WRITE(PLANE_COLOR_CTL(pipe, plane_id),
> PLANE_COLOR_PIPE_GAMMA_ENABLE |
> + PLANE_COLOR_PIPE_CSC_ENABLE |
> PLANE_COLOR_PLANE_GAMMA_DISABLE);
> } else {
> plane_ctl |=
> --
> 2.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-30 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 11:24 [PATCH v2 0/5] Geminilake pipe CSC Ander Conselvan de Oliveira
2017-01-26 11:24 ` [PATCH v2 1/5] drm/i915: Disable plane gamma in SKL+ sprite planes Ander Conselvan de Oliveira
2017-01-26 11:24 ` [PATCH v2 2/5] drm/i915/glk: Plane color correction register changes Ander Conselvan de Oliveira
2017-01-26 11:32 ` Ville Syrjälä
2017-01-30 8:38 ` Ander Conselvan De Oliveira
2017-01-26 11:24 ` [PATCH v2 3/5] drm/i915: Split broadwell_load_luts() into smaller functions Ander Conselvan de Oliveira
2017-01-26 13:05 ` Ville Syrjälä
2017-01-26 11:24 ` [PATCH v2 4/5] drm/i915/glk: Program pipe gamma and degamma tables Ander Conselvan de Oliveira
2017-01-26 14:21 ` Ville Syrjälä
2017-01-27 9:01 ` Conselvan De Oliveira, Ander
2017-01-27 9:02 ` [PATCH v3] " Ander Conselvan de Oliveira
2017-01-27 14:04 ` Ville Syrjälä
2017-01-30 8:39 ` Ander Conselvan De Oliveira
2017-01-26 11:24 ` [PATCH v2 5/5] drm/i915/glk: Enable pipe CSC Ander Conselvan de Oliveira
2017-01-30 16:30 ` Ville Syrjälä [this message]
2017-01-26 12:54 ` ✓ Fi.CI.BAT: success for Geminilake " Patchwork
2017-01-27 9:19 ` [PATCH RFC 6/5] drm/i915: Merge BDW pipe gamma and degamma table code Ander Conselvan de Oliveira
2017-01-27 14:07 ` Ville Syrjälä
2017-01-27 9:55 ` ✓ Fi.CI.BAT: success for Geminilake pipe CSC (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130163017.GR31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).