Re: [PATCH i-g-t v3 00/11] tests/kms_atomic_transition add fence testing

Chris Wilson
2017-01-31T10:18:43Z

On Mon, Jan 30, 2017 at 08:58:36PM -0500, Robert Foss wrote:
> This series adds in/out fence testing to kms_atomic_transition test and makes some minor cleanups.
>
> This series is rebased ontop of the dyn_n_planes_v3 series.
>
> This series can be found here:
> https://git.collabora.com/cgit/user/robertfoss/intel-gpu-tools.git/log/?h=fences_$VER
>
>
> Changes since v1:
>
> lib/igt_kms:
> - Added gtk-doc for exported symbols
> - Changed integer casting to avoid potential issues
> - Changed out_fence_ptr type to int64_t*
> - Fixed igt_plane_set_fence_fd comment
>
> tests/:
> - Rework timeout change in commit_display()
> - Extract plane_invalid_params_fence() out plane_invalid_params()
> - Extract crtc_invalid_params_fence() out crtc_invalid_params()
> - Prevent add igt_require_sw_sync to subtests using sw_sync
>
>
> Changes since v2:
> Rebased on upstream/master
>
> lib/igt_kms:
> - Reset plane->fence_fd to -1 during igt_atomic_prepare_plane_commit()
> - Rework out_fencs_ptr to be an int64_t named out_fence
> - Add igt_pipe_request_out_fence()
> tests/:
> - Switch to using igt_pipe_request_out_fence()
> - Close out_fence fd
> - Change out_fence to int64_t in run_transition_test()
> - Added comments noting that two testcases are not invalid
> - Added igt_pipe_get_last_out_fence() that wraps pipe->fence_out

Looks like this this missing the uabi conversion to s32 (int).
-Chris

--
Chris Wilson, Intel Open Source Technology Centre