From: Brian Starkey <brian.starkey@arm.com>
To: Robert Foss <robert.foss@collabora.com>
Cc: Gustavo Padovan <gustavo.padovan@collabora.com>,
intel-gfx@lists.freedesktop.org,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH i-g-t v3 05/11] lib/igt_kms: Added igt_pipe_get_last_out_fence()
Date: Tue, 31 Jan 2017 16:54:12 +0000 [thread overview]
Message-ID: <20170131165412.GL11506@e106950-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170131015847.28628-6-robert.foss@collabora.com>
On Mon, Jan 30, 2017 at 08:58:41PM -0500, Robert Foss wrote:
>Added the igt_pipe_get_last_out_fence() helper function
>that wraps accesses to pipe->fence_out.
>
>Signed-off-by: Robert Foss <robert.foss@collabora.com>
>---
> lib/igt_kms.c | 8 ++++++++
> lib/igt_kms.h | 1 +
> 2 files changed, 9 insertions(+)
>
>diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>index 142658a6..f0e38b75 100644
>--- a/lib/igt_kms.c
>+++ b/lib/igt_kms.c
>@@ -1934,6 +1934,14 @@ static igt_output_t *igt_pipe_get_output(igt_pipe_t *pipe)
> return NULL;
> }
>
>+int igt_pipe_get_last_out_fence(igt_pipe_t *pipe)
>+{
>+ int fd = (int) pipe->out_fence;
>+ pipe->out_fence = -1;
>+
>+ return fd;
If this wasn't the compile error you already found, then "out_fence"
doesn't seem to have been added to igt_pipe_t yet.
-Brian
>+}
>+
> bool igt_pipe_get_property(igt_pipe_t *pipe, const char *name,
> uint32_t *prop_id, uint64_t *value,
> drmModePropertyPtr *prop)
>diff --git a/lib/igt_kms.h b/lib/igt_kms.h
>index 00e0dc68..94ff27bb 100644
>--- a/lib/igt_kms.h
>+++ b/lib/igt_kms.h
>@@ -382,6 +382,7 @@ igt_plane_t *igt_output_get_plane_type(igt_output_t *output, int plane_type);
> igt_output_t *igt_output_from_connector(igt_display_t *display,
> drmModeConnector *connector);
> igt_plane_t *igt_pipe_get_plane_type(igt_pipe_t *pipe, int plane_type);
>+int igt_pipe_get_last_out_fence(igt_pipe_t *pipe);
> bool igt_pipe_get_property(igt_pipe_t *pipe, const char *name,
> uint32_t *prop_id, uint64_t *value,
> drmModePropertyPtr *prop);
>--
>2.11.0.453.g787f75f05
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-31 16:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 1:58 [PATCH i-g-t v3 00/11] tests/kms_atomic_transition add fence testing Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 01/11] tests/kms_atomic_transition: use igt timeout instead of blocking Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 02/11] lib/igt_kms: move igt_kms_get_alt_edid() to the right place Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 03/11] lib/igt_kms: export properties names Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 04/11] tests/kms_atomic: use global atomic properties definitions Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 05/11] lib/igt_kms: Added igt_pipe_get_last_out_fence() Robert Foss
2017-01-31 16:54 ` Brian Starkey [this message]
2017-01-31 1:58 ` [PATCH i-g-t v3 06/11] lib/igt_kms: Add support for the IN_FENCE_FD property Robert Foss
2017-01-31 16:49 ` Brian Starkey
2017-01-31 1:58 ` [PATCH i-g-t v3 07/11] lib/igt_kms: Add support for the OUT_FENCE_PTR property Robert Foss
2017-01-31 16:49 ` Brian Starkey
2017-01-31 22:29 ` Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 08/11] tests/kms_atomic: stress possible fence settings Robert Foss
2017-01-31 16:50 ` Brian Starkey
2017-01-31 22:39 ` Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 09/11] tests/kms_atomic_transition: add fencing parameter to run_transition_tests Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 10/11] tests/kms_atomic_transition: add out_fences tests Robert Foss
2017-01-31 16:52 ` Brian Starkey
2017-02-01 0:27 ` Robert Foss
2017-01-31 1:58 ` [PATCH i-g-t v3 11/11] tests/kms_atomic_transition: add in_fences tests Robert Foss
2017-01-31 16:52 ` Brian Starkey
2017-02-01 1:11 ` Robert Foss
2017-01-31 10:18 ` [PATCH i-g-t v3 00/11] tests/kms_atomic_transition add fence testing Chris Wilson
2017-01-31 15:54 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131165412.GL11506@e106950-lin.cambridge.arm.com \
--to=brian.starkey@arm.com \
--cc=gustavo.padovan@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert.foss@collabora.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox