From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm/i915: Wait for pending modesets to complete before trying link training Date: Thu, 9 Feb 2017 14:34:14 +0200 Message-ID: <20170209123414.GV31595@intel.com> References: <1483981618-10233-1-git-send-email-maarten.lankhorst@linux.intel.com> <1483981618-10233-3-git-send-email-maarten.lankhorst@linux.intel.com> <20170126183158.GM31595@intel.com> <8bfdef6d-0971-25d9-67ab-720103d8ad72@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <8bfdef6d-0971-25d9-67ab-720103d8ad72@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMDksIDIwMTcgYXQgMTI6Mjc6MTJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMjYtMDEtMTcgb20gMTk6MzEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBNb24sIEphbiAwOSwgMjAxNyBhdCAwNjowNjo1N1BNICswMTAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBXZSdyZSBwcm90ZWN0ZWQgYnkgdGhlIGNvbm5lY3Rpb25fbXV0 ZXggbG9jayBhZ2FpbnN0IGJsb2NraW5nIG1vZGVzZXRzLAo+ID4+IGJ1dCBub25ibG9ja2luZyBt b2Rlc2V0cyBhcmUgcGVyZm9ybWVkIHdpdGhvdXQgYW55IGxvY2tpbmcuIFRoaXMgaXMKPiA+PiBj YXVzaW5nIFdBUk4gaW4gZHJtX3dhaXRfZm9yX3ZibGFuayBhbmQgaW4gZ2VuZXJhbCBpdCdzIGJl dHRlciB0byB3YWl0Cj4gPj4gYmVmb3JlIG1vZGVzZXQgY29tcGxldGVzIGJlZm9yZSB0cnlpbmcg YW55dGhpbmcuCj4gPj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFh cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyksIDEyIGRl bGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPj4gaW5kZXggZmIx Mjg5NmJhZmVlLi43MTg4MmQ4ODczOTMgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPiA+PiBAQCAtNDA4MCwyNCArNDA4MCwzOCBAQCBpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1 cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4+ICAJc3RydWN0IGludGVsX2VuY29kZXIg KmludGVsX2VuY29kZXIgPSAmZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApLT5iYXNlOwo+ID4+ICAJ c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RwX3RvX2RldihpbnRlbF9kcCk7Cj4gPj4g IAl1OCBsaW5rX3N0YXR1c1tEUF9MSU5LX1NUQVRVU19TSVpFXTsKPiA+PiArCXN0cnVjdCBkcm1f bW9kZXNldF9hY3F1aXJlX2N0eCBjdHg7Cj4gPj4gKwlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpp bnRlbF9jb25uZWN0b3IgPSBpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yOwo+ID4+ICsJaW50 IHJldDsKPiA+PiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+PiAgCj4gPj4gLQlXQVJOX09O KCFkcm1fbW9kZXNldF9pc19sb2NrZWQoJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRl eCkpOwo+ID4+ICsJZHJtX21vZGVzZXRfYWNxdWlyZV9pbml0KCZjdHgsIDApOwo+ID4+ICsKPiA+ PiArcmV0cnk6Cj4gPj4gKwlyZXQgPSBkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29uZmln LmNvbm5lY3Rpb25fbXV0ZXgsICZjdHgpOwo+ID4+ICsJaWYgKHJldCkKPiA+PiArCQlnb3RvIG91 dDsKPiA+PiAgCj4gPj4gIAlpZiAoIWludGVsX2RwX2dldF9saW5rX3N0YXR1cyhpbnRlbF9kcCwg bGlua19zdGF0dXMpKSB7Cj4gPj4gIAkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gZ2V0IGxpbmsgc3Rh dHVzXG4iKTsKPiA+PiAtCQlyZXR1cm47Cj4gPj4gKwkJZ290byBvdXQ7Cj4gPj4gIAl9Cj4gPj4g IAo+ID4+IC0JaWYgKCFpbnRlbF9lbmNvZGVyLT5iYXNlLmNydGMpCj4gPj4gLQkJcmV0dXJuOwo+ ID4+ICsJY3J0YyA9IGludGVsX2Nvbm5lY3Rvci0+YmFzZS5zdGF0ZS0+Y3J0YzsKPiA+PiArCWlm ICghY3J0YykKPiA+PiArCQlnb3RvIG91dDsKPiA+PiAgCj4gPj4gLQlpZiAoIXRvX2ludGVsX2Ny dGMoaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKS0+YWN0aXZlKQo+ID4+IC0JCXJldHVybjsKPiA+ PiArCXJldCA9IGRybV9tb2Rlc2V0X2xvY2soJmNydGMtPm11dGV4LCAmY3R4KTsKPiA+PiArCWlm IChyZXQpCj4gPj4gKwkJZ290byBvdXQ7Cj4gPj4gKwo+ID4+ICsJaWYgKCFjcnRjLT5zdGF0ZS0+ YWN0aXZlKQo+ID4+ICsJCWdvdG8gb3V0Owo+ID4+ICAKPiA+PiAgCS8qIEZJWE1FOiB3ZSBuZWVk IHRvIHN5bmNocm9uaXplIHRoaXMgc29ydCBvZiBzdHVmZiB3aXRoIGhhcmR3YXJlCj4gPj4gIAkg KiByZWFkb3V0LiBDdXJyZW50bHkgZmFzdCBsaW5rIHRyYWluaW5nIGRvZXNuJ3Qgd29yayBvbiBi b290LXVwLiAqLwo+ID4+ICAJaWYgKCFpbnRlbF9kcC0+bGFuZV9jb3VudCkKPiA+PiAtCQlyZXR1 cm47Cj4gPj4gKwkJZ290byBvdXQ7Cj4gPj4gIAo+ID4+ICAJLyogaWYgbGluayB0cmFpbmluZyBp cyByZXF1ZXN0ZWQgd2Ugc2hvdWxkIHBlcmZvcm0gaXQgYWx3YXlzICovCj4gPj4gIAlpZiAoKGlu dGVsX2RwLT5jb21wbGlhbmNlLnRlc3RfdHlwZSA9PSBEUF9URVNUX0xJTktfVFJBSU5JTkcpIHx8 Cj4gPj4gQEAgLTQxMDUsOCArNDExOSwyNiBAQCBpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhz dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4+ICAJCURSTV9ERUJVR19LTVMoIiVzOiBjaGFu bmVsIEVRIG5vdCBvaywgcmV0cmFpbmluZ1xuIiwKPiA+PiAgCQkJICAgICAgaW50ZWxfZW5jb2Rl ci0+YmFzZS5uYW1lKTsKPiA+PiAgCj4gPj4gKwkJaWYgKGRybV9hdG9taWNfY3J0Y19uZWVkc19t b2Rlc2V0KGNydGMtPnN0YXRlKSkgewo+ID4+ICsJCQkvKiB3YWl0IGZvciBhdG9taWMgbW9kZXNl dCB0byBjb21wbGV0ZSAqLwo+ID4+ICsJCQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zv cl9od19kb25lKGNydGMpOwo+ID4+ICsJCQlpZiAocmV0IDwgMCkKPiA+PiArCQkJCURSTV9FUlJP UigiV2FpdGluZyBmb3IgaHdfZG9uZSB0aW1lZCBvdXRcbiIpOwo+ID4gSSB3b25kZXIgaWYgd2Ug c2hvdWxkIGp1c3Qgc2tpcCB0aGUgaHcgZnJvYmJpbmcgaW4gdGhpcyBjYXNlLiBJIGd1ZXNzIGl0 Cj4gPiBtaWdodCBzdGlsbCByZXN0b3JlIHRoZSBsaW5rIGlmIHRoZSBjb21taXQganVzdCBzb21l aG93IGdvdCBzdHVjawo+ID4gc29tZXdoZXJlIG5vbi1jcml0aWNhbC4KPiBIbSwgIHdlIGNvdWxk IGNoZWNrIGlmIHRoZSBsaW5rIHRyYWluaW5nIGlzIHN0aWxsIHJlcXVpcmVkIGFmdGVyIHRoZSB3 YWl0Lgo+IE1heWJlIGV2ZW4gZG8gdGhlIHdhaXQgdW5sb2NrZWQsIHNpbmNlIGl0IG1pZ2h0IHRh a2UgYW4gYXJiaXRyYXJ5IGFtb3VudCBvZiB0aW1lCj4gYW5kIHRoZW4gcmV0cnk/CgpJJ20gbm90 IHN1cmUgdGhlcmUncyBtdWNoIHBvaW50IGluIHRyeWluZyB0byBtYWtlIHRoaXMgZmFuY3kuIExp bmsKcHJvYmxlbXMgc2hvdWxkIG5vdCBoYXBwZW4gd2l0aCBhbnkgcmVndWxhcml0eS4KCgo+ID4+ ICsJCX0KPiA+PiArCj4gPj4gIAkJaW50ZWxfZHBfcmV0cmFpbl9saW5rKGludGVsX2RwKTsKPiA+ PiAgCX0KPiA+PiArCj4gPj4gK291dDoKPiA+PiArCWlmIChyZXQgPT0gLUVERUFETEspIHsKPiA+ PiArCQlkcm1fbW9kZXNldF9iYWNrb2ZmKCZjdHgpOwo+ID4+ICsJCWdvdG8gcmV0cnk7Cj4gPj4g Kwl9Cj4gPj4gKwo+ID4+ICsJZHJtX21vZGVzZXRfZHJvcF9sb2NrcygmY3R4KTsKPiA+PiArCWRy bV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiA+PiArCWlmIChyZXQpCj4gPj4gKwkJRFJN X0VSUk9SKCJMb2NraW5nIGZhaWxlZCB3aXRoICVpXG4iLCByZXQpOwo+ID4gVGhpcyBzZWVtcyBp bmNvcnJlY3QgaWYgd2UgdGltZWQgb3V0IG9uIHRoZSB3YWl0LiBNYXliZSBqdXN0Cj4gPiBjbGVh ciByZXQgYWZ0ZXIgdGhlIGh3X2RvbmUgd2FpdD8KPiA+Cj4gPj4gIH0KPiA+PiAgCj4gPj4gIC8q Cj4gPj4gQEAgLTQxMjUsNyArNDE1Nyw2IEBAIGludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPj4gIHN0YXRpYyBib29sCj4gPj4gIGludGVsX2Rw X3Nob3J0X3B1bHNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPj4gIHsKPiA+PiAtCXN0 cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kcF90b19kZXYoaW50ZWxfZHApOwo+ID4+ICAJ dTggc2lua19pcnFfdmVjdG9yID0gMDsKPiA+PiAgCXU4IG9sZF9zaW5rX2NvdW50ID0gaW50ZWxf ZHAtPnNpbmtfY291bnQ7Cj4gPj4gIAlib29sIHJldDsKPiA+PiBAQCAtNDE2NCw5ICs0MTk1LDcg QEAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+PiAg CQkJRFJNX0RFQlVHX0RSSVZFUigiQ1Agb3Igc2luayBzcGVjaWZpYyBpcnEgdW5oYW5kbGVkXG4i KTsKPiA+PiAgCX0KPiA+PiAgCj4gPj4gLQlkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29u ZmlnLmNvbm5lY3Rpb25fbXV0ZXgsIE5VTEwpOwo+ID4+ICAJaW50ZWxfZHBfY2hlY2tfbGlua19z dGF0dXMoaW50ZWxfZHApOwo+ID4+IC0JZHJtX21vZGVzZXRfdW5sb2NrKCZkZXYtPm1vZGVfY29u ZmlnLmNvbm5lY3Rpb25fbXV0ZXgpOwo+ID4+ICAKPiA+PiAgCXJldHVybiB0cnVlOwo+ID4+ICB9 Cj4gPj4gQEAgLTQ0OTksOSArNDUyOCw3IEBAIGludGVsX2RwX2xvbmdfcHVsc2Uoc3RydWN0IGlu dGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yKQo+ID4+ICAJCSAqIGNoZWNrIGxpbmtzIHN0 YXR1cywgdGhlcmUgaGFzIGJlZW4ga25vd24gaXNzdWVzIG9mCj4gPj4gIAkJICogbGluayBsb3Nz IHRyaWdnZXJyaW5nIGxvbmcgcHVsc2UhISEhCj4gPj4gIAkJICovCj4gPj4gLQkJZHJtX21vZGVz ZXRfbG9jaygmZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4LCBOVUxMKTsKPiA+PiAg CQlpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhpbnRlbF9kcCk7Cj4gPj4gLQkJZHJtX21vZGVz ZXRfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpOwo+ID4+ICAJCWdv dG8gb3V0Owo+ID4+ICAJfQo+ID4+ICAKPiA+PiAtLSAKPiA+PiAyLjcuNAo+ID4+Cj4gPj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+PiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4gPj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cj4gCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK