From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ander Conselvan De Oliveira <conselvan2@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit()
Date: Fri, 10 Feb 2017 18:51:17 +0200 [thread overview]
Message-ID: <20170210165117.GF31595@intel.com> (raw)
In-Reply-To: <1486646135.3165.2.camel@gmail.com>
On Thu, Feb 09, 2017 at 03:15:35PM +0200, Ander Conselvan De Oliveira wrote:
> On Wed, 2017-02-08 at 19:53 +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Replace the VLV/CHV check with a HAS_GMCH_DISPLAY check
>
> in
Fixed, and pushed to dinq. Thanks for the review.
>
> > intel_fb_pitch_limit(), because it's shorter.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index f6259c949da2..d4e84244862f 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -14346,8 +14346,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private
> > *dev_priv,
> > * pixels and 32K bytes."
> > */
> > return min(8192 * cpp, 32768);
> > - } else if (gen >= 5 && !IS_VALLEYVIEW(dev_priv) &&
> > - !IS_CHERRYVIEW(dev_priv)) {
> > + } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> > return 32*1024;
> > } else if (gen >= 4) {
> > if (fb_modifier == I915_FORMAT_MOD_X_TILED)
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-02-10 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 17:53 [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit() ville.syrjala
2017-02-09 7:59 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-09 13:15 ` [PATCH] " Ander Conselvan De Oliveira
2017-02-10 16:51 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210165117.GF31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox