* [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit()
@ 2017-02-08 17:53 ville.syrjala
2017-02-09 7:59 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-09 13:15 ` [PATCH] " Ander Conselvan De Oliveira
0 siblings, 2 replies; 4+ messages in thread
From: ville.syrjala @ 2017-02-08 17:53 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Replace the VLV/CHV check with a HAS_GMCH_DISPLAY check
intel_fb_pitch_limit(), because it's shorter.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index f6259c949da2..d4e84244862f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14346,8 +14346,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
* pixels and 32K bytes."
*/
return min(8192 * cpp, 32768);
- } else if (gen >= 5 && !IS_VALLEYVIEW(dev_priv) &&
- !IS_CHERRYVIEW(dev_priv)) {
+ } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
return 32*1024;
} else if (gen >= 4) {
if (fb_modifier == I915_FORMAT_MOD_X_TILED)
--
2.10.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Simplify platform checks in intel_fb_pitch_limit()
2017-02-08 17:53 [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit() ville.syrjala
@ 2017-02-09 7:59 ` Patchwork
2017-02-09 13:15 ` [PATCH] " Ander Conselvan De Oliveira
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-02-09 7:59 UTC (permalink / raw)
To: ville.syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Simplify platform checks in intel_fb_pitch_limit()
URL : https://patchwork.freedesktop.org/series/19330/
State : success
== Summary ==
Series 19330v1 drm/i915: Simplify platform checks in intel_fb_pitch_limit()
https://patchwork.freedesktop.org/api/1.0/series/19330/revisions/1/mbox/
Test gem_exec_fence:
Subgroup await-hang-default:
incomplete -> PASS (fi-hsw-4770)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
incomplete -> PASS (fi-ilk-650)
fi-bdw-5557u total:252 pass:238 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:252 pass:213 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:252 pass:230 dwarn:0 dfail:0 fail:0 skip:22
fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12
fi-byt-j1900 total:252 pass:225 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19
fi-hsw-4770r total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19
fi-ilk-650 total:252 pass:199 dwarn:0 dfail:0 fail:0 skip:53
fi-ivb-3520m total:252 pass:231 dwarn:0 dfail:0 fail:0 skip:21
fi-ivb-3770 total:252 pass:231 dwarn:0 dfail:0 fail:0 skip:21
fi-kbl-7500u total:252 pass:229 dwarn:0 dfail:0 fail:2 skip:21
fi-skl-6260u total:252 pass:239 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:252 pass:232 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:252 pass:227 dwarn:4 dfail:0 fail:0 skip:21
fi-skl-6770hq total:252 pass:239 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31
fi-snb-2600 total:252 pass:220 dwarn:0 dfail:0 fail:0 skip:32
2699547830db3e698485f452e29278c09f084397 drm-tip: 2017y-02m-08d-18h-25m-45s UTC integration manifest
9d54d19 drm/i915: Simplify platform checks in intel_fb_pitch_limit()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3742/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit()
2017-02-08 17:53 [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit() ville.syrjala
2017-02-09 7:59 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-02-09 13:15 ` Ander Conselvan De Oliveira
2017-02-10 16:51 ` Ville Syrjälä
1 sibling, 1 reply; 4+ messages in thread
From: Ander Conselvan De Oliveira @ 2017-02-09 13:15 UTC (permalink / raw)
To: ville.syrjala, intel-gfx
On Wed, 2017-02-08 at 19:53 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Replace the VLV/CHV check with a HAS_GMCH_DISPLAY check
in
> intel_fb_pitch_limit(), because it's shorter.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index f6259c949da2..d4e84244862f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14346,8 +14346,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private
> *dev_priv,
> * pixels and 32K bytes."
> */
> return min(8192 * cpp, 32768);
> - } else if (gen >= 5 && !IS_VALLEYVIEW(dev_priv) &&
> - !IS_CHERRYVIEW(dev_priv)) {
> + } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> return 32*1024;
> } else if (gen >= 4) {
> if (fb_modifier == I915_FORMAT_MOD_X_TILED)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit()
2017-02-09 13:15 ` [PATCH] " Ander Conselvan De Oliveira
@ 2017-02-10 16:51 ` Ville Syrjälä
0 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2017-02-10 16:51 UTC (permalink / raw)
To: Ander Conselvan De Oliveira; +Cc: intel-gfx
On Thu, Feb 09, 2017 at 03:15:35PM +0200, Ander Conselvan De Oliveira wrote:
> On Wed, 2017-02-08 at 19:53 +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Replace the VLV/CHV check with a HAS_GMCH_DISPLAY check
>
> in
Fixed, and pushed to dinq. Thanks for the review.
>
> > intel_fb_pitch_limit(), because it's shorter.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index f6259c949da2..d4e84244862f 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -14346,8 +14346,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private
> > *dev_priv,
> > * pixels and 32K bytes."
> > */
> > return min(8192 * cpp, 32768);
> > - } else if (gen >= 5 && !IS_VALLEYVIEW(dev_priv) &&
> > - !IS_CHERRYVIEW(dev_priv)) {
> > + } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> > return 32*1024;
> > } else if (gen >= 4) {
> > if (fb_modifier == I915_FORMAT_MOD_X_TILED)
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-10 16:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-08 17:53 [PATCH] drm/i915: Simplify platform checks in intel_fb_pitch_limit() ville.syrjala
2017-02-09 7:59 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-09 13:15 ` [PATCH] " Ander Conselvan De Oliveira
2017-02-10 16:51 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox