From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/3] drm/i915: Move common engine and ring
 code into intel_engine_cs
Date: Wed, 15 Feb 2017 16:18:55 +0200
Message-ID: <20170215141855.GY31595@intel.com>
References: <20170215140553.28751-1-tvrtko.ursulin@linux.intel.com>
 <20170215140553.28751-3-tvrtko.ursulin@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C17F76E944
 for <Intel-gfx@lists.freedesktop.org>; Wed, 15 Feb 2017 14:18:59 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20170215140553.28751-3-tvrtko.ursulin@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tursulin@ursulin.net>
Cc: Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBGZWIgMTUsIDIwMTcgYXQgMDI6MDU6NTJQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g
d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K
PiAKPiBUaGlzIGxlYXZlcyB0aGUgcmluZ2J1ZmYgc3VibWlzc2lvbiBjb2RlIGluIGludGVsX3Jp
bmdidWZmZXIuYwo+IAo+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJz
dWxpbkBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu
ZV9jcy5jICB8IDgzNCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCA4MzQgLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCA4MzQgaW5zZXJ0aW9ucygrKSwgODM0
IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4g
aW5kZXggNTM4ZDg0NWQ3MjUxLi5hZmFlZGMzYWRjMmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9lbmdpbmVfY3MuYwo+IEBAIC01MjUsNiArNTI1LDg0MCBAQCB2b2lkIGludGVsX2Vu
Z2luZV9nZXRfaW5zdGRvbmUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAJfQo+
ICB9Cj4gIAo+ICtzdGF0aWMgaW50IHdhX2FkZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYsCj4gKwkJICBpOTE1X3JlZ190IGFkZHIsCj4gKwkJICBjb25zdCB1MzIgbWFzaywgY29u
c3QgdTMyIHZhbCkKPiArewo+ICsJY29uc3QgdTMyIGlkeCA9IGRldl9wcml2LT53b3JrYXJvdW5k
cy5jb3VudDsKPiArCj4gKwlpZiAoV0FSTl9PTihpZHggPj0gSTkxNV9NQVhfV0FfUkVHUykpCj4g
KwkJcmV0dXJuIC1FTk9TUEM7Cj4gKwo+ICsJZGV2X3ByaXYtPndvcmthcm91bmRzLnJlZ1tpZHhd
LmFkZHIgPSBhZGRyOwo+ICsJZGV2X3ByaXYtPndvcmthcm91bmRzLnJlZ1tpZHhdLnZhbHVlID0g
dmFsOwo+ICsJZGV2X3ByaXYtPndvcmthcm91bmRzLnJlZ1tpZHhdLm1hc2sgPSBtYXNrOwo+ICsK
PiArCWRldl9wcml2LT53b3JrYXJvdW5kcy5jb3VudCsrOwo+ICsKPiArCXJldHVybiAwOwo+ICt9
Cj4gKwo+ICsjZGVmaW5lIFdBX1JFRyhhZGRyLCBtYXNrLCB2YWwpIGRvIHsgXAo+ICsJCWNvbnN0
IGludCByID0gd2FfYWRkKGRldl9wcml2LCAoYWRkciksIChtYXNrKSwgKHZhbCkpOyBcCj4gKwkJ
aWYgKHIpIFwKPiArCQkJcmV0dXJuIHI7IFwKPiArCX0gd2hpbGUgKDApCj4gKwo+ICsjZGVmaW5l
IFdBX1NFVF9CSVRfTUFTS0VEKGFkZHIsIG1hc2spIFwKPiArCVdBX1JFRyhhZGRyLCAobWFzayks
IF9NQVNLRURfQklUX0VOQUJMRShtYXNrKSkKPiArCj4gKyNkZWZpbmUgV0FfQ0xSX0JJVF9NQVNL
RUQoYWRkciwgbWFzaykgXAo+ICsJV0FfUkVHKGFkZHIsIChtYXNrKSwgX01BU0tFRF9CSVRfRElT
QUJMRShtYXNrKSkKPiArCj4gKyNkZWZpbmUgV0FfU0VUX0ZJRUxEX01BU0tFRChhZGRyLCBtYXNr
LCB2YWx1ZSkgXAo+ICsJV0FfUkVHKGFkZHIsIG1hc2ssIF9NQVNLRURfRklFTEQobWFzaywgdmFs
dWUpKQo+ICsKPiArI2RlZmluZSBXQV9TRVRfQklUKGFkZHIsIG1hc2spIFdBX1JFRyhhZGRyLCBt
YXNrLCBJOTE1X1JFQUQoYWRkcikgfCAobWFzaykpCj4gKyNkZWZpbmUgV0FfQ0xSX0JJVChhZGRy
LCBtYXNrKSBXQV9SRUcoYWRkciwgbWFzaywgSTkxNV9SRUFEKGFkZHIpICYgfihtYXNrKSkKPiAr
Cj4gKyNkZWZpbmUgV0FfV1JJVEUoYWRkciwgdmFsKSBXQV9SRUcoYWRkciwgMHhmZmZmZmZmZiwg
dmFsKQo+ICsKPiArc3RhdGljIGludCB3YV9yaW5nX3doaXRlbGlzdF9yZWcoc3RydWN0IGludGVs
X2VuZ2luZV9jcyAqZW5naW5lLAo+ICsJCQkJIGk5MTVfcmVnX3QgcmVnKQo+ICt7Cj4gKwlzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7Cj4gKwlzdHJ1Y3Qg
aTkxNV93b3JrYXJvdW5kcyAqd2EgPSAmZGV2X3ByaXYtPndvcmthcm91bmRzOwo+ICsJY29uc3Qg
dWludDMyX3QgaW5kZXggPSB3YS0+aHdfd2hpdGVsaXN0X2NvdW50W2VuZ2luZS0+aWRdOwo+ICsK
PiArCWlmIChXQVJOX09OKGluZGV4ID49IFJJTkdfTUFYX05PTlBSSVZfU0xPVFMpKQo+ICsJCXJl
dHVybiAtRUlOVkFMOwo+ICsKPiArCVdBX1dSSVRFKFJJTkdfRk9SQ0VfVE9fTk9OUFJJVihlbmdp
bmUtPm1taW9fYmFzZSwgaW5kZXgpLAo+ICsJCSBpOTE1X21taW9fcmVnX29mZnNldChyZWcpKTsK
PiArCXdhLT5od193aGl0ZWxpc3RfY291bnRbZW5naW5lLT5pZF0rKzsKPiArCj4gKwlyZXR1cm4g
MDsKPiArfQo+ICsKPiArc3RhdGljIGludCBnZW44X2luaXRfd29ya2Fyb3VuZHMoc3RydWN0IGlu
dGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7Cj4gKwo+ICsJV0FfU0VUX0JJVF9NQVNLRUQoSU5TVFBN
LCBJTlNUUE1fRk9SQ0VfT1JERVJJTkcpOwo+ICsKPiArCS8qIFdhRGlzYWJsZUFzeW5jRmxpcFBl
cmZNb2RlOmJkdyxjaHYgKi8KPiArCVdBX1NFVF9CSVRfTUFTS0VEKE1JX01PREUsIEFTWU5DX0ZM
SVBfUEVSRl9ESVNBQkxFKTsKPiArCj4gKwkvKiBXYURpc2FibGVQYXJ0aWFsSW5zdFNob290ZG93
bjpiZHcsY2h2ICovCj4gKwlXQV9TRVRfQklUX01BU0tFRChHRU44X1JPV19DSElDS0VOLAo+ICsJ
CQkgIFBBUlRJQUxfSU5TVFJVQ1RJT05fU0hPT1RET1dOX0RJU0FCTEUpOwo+ICsKPiArCS8qIFVz
ZSBGb3JjZSBOb24tQ29oZXJlbnQgd2hlbmV2ZXIgZXhlY3V0aW5nIGEgM0QgY29udGV4dC4gVGhp
cyBpcyBhCj4gKwkgKiB3b3JrYXJvdW5kIGZvciBmb3IgYSBwb3NzaWJsZSBoYW5nIGluIHRoZSB1
bmxpa2VseSBldmVudCBhIFRMQgo+ICsJICogaW52YWxpZGF0aW9uIG9jY3VycyBkdXJpbmcgYSBQ
U0QgZmx1c2guCj4gKwkgKi8KPiArCS8qIFdhRm9yY2VFbmFibGVOb25Db2hlcmVudDpiZHcsY2h2
ICovCj4gKwkvKiBXYUhkY0Rpc2FibGVGZXRjaFdoZW5NYXNrZWQ6YmR3LGNodiAqLwo+ICsJV0Ff
U0VUX0JJVF9NQVNLRUQoSERDX0NISUNLRU4wLAo+ICsJCQkgIEhEQ19ET05PVF9GRVRDSF9NRU1f
V0hFTl9NQVNLRUQgfAo+ICsJCQkgIEhEQ19GT1JDRV9OT05fQ09IRVJFTlQpOwo+ICsKPiArCS8q
IEZyb20gdGhlIEhhc3dlbGwgUFJNLCBDb21tYW5kIFJlZmVyZW5jZTogUmVnaXN0ZXJzLCBDQUNI
RV9NT0RFXzA6Cj4gKwkgKiAiVGhlIEhpZXJhcmNoaWNhbCBaIFJBVyBTdGFsbCBPcHRpbWl6YXRp
b24gYWxsb3dzIG5vbi1vdmVybGFwcGluZwo+ICsJICogIHBvbHlnb25zIGluIHRoZSBzYW1lIDh4
NCBwaXhlbC9zYW1wbGUgYXJlYSB0byBiZSBwcm9jZXNzZWQgd2l0aG91dAo+ICsJICogIHN0YWxs
aW5nIHdhaXRpbmcgZm9yIHRoZSBlYXJsaWVyIG9uZXMgdG8gd3JpdGUgdG8gSGllcmFyY2hpY2Fs
IFoKPiArCSAqICBidWZmZXIuIgo+ICsJICoKPiArCSAqIFRoaXMgb3B0aW1pemF0aW9uIGlzIG9m
ZiBieSBkZWZhdWx0IGZvciBCRFcgYW5kIENIVjsgdHVybiBpdCBvbi4KPiArCSAqLwo+ICsJV0Ff
Q0xSX0JJVF9NQVNLRUQoQ0FDSEVfTU9ERV8wX0dFTjcsIEhJWl9SQVdfU1RBTExfT1BUX0RJU0FC
TEUpOwo+ICsKPiArCS8qIFdhNHg0U1RDT3B0aW1pemF0aW9uRGlzYWJsZTpiZHcsY2h2ICovCj4g
KwlXQV9TRVRfQklUX01BU0tFRChDQUNIRV9NT0RFXzEsIEdFTjhfNHg0X1NUQ19PUFRJTUlaQVRJ
T05fRElTQUJMRSk7Cj4gKwo+ICsJLyoKPiArCSAqIEJTcGVjIHJlY29tbWVuZHMgOHg0IHdoZW4g
TVNBQSBpcyB1c2VkLAo+ICsJICogaG93ZXZlciBpbiBwcmFjdGljZSAxNng0IHNlZW1zIGZhc3Rl
c3QuCj4gKwkgKgo+ICsJICogTm90ZSB0aGF0IFBTL1dNIHRocmVhZCBjb3VudHMgZGVwZW5kIG9u
IHRoZSBXSVogaGFzaGluZwo+ICsJICogZGlzYWJsZSBiaXQsIHdoaWNoIHdlIGRvbid0IHRvdWNo
IGhlcmUsIGJ1dCBpdCdzIGdvb2QKPiArCSAqIHRvIGtlZXAgaW4gbWluZCAoc2VlIDNEU1RBVEVf
UFMgYW5kIDNEU1RBVEVfV00pLgo+ICsJICovCj4gKwlXQV9TRVRfRklFTERfTUFTS0VEKEdFTjdf
R1RfTU9ERSwKPiArCQkJICAgIEdFTjZfV0laX0hBU0hJTkdfTUFTSywKPiArCQkJICAgIEdFTjZf
V0laX0hBU0hJTkdfMTZ4NCk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBp
bnQgYmR3X2luaXRfd29ya2Fyb3VuZHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+
ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7
Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXJldCA9IGdlbjhfaW5pdF93b3JrYXJvdW5kcyhlbmdpbmUp
Owo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCS8qIFdhRGlzYWJsZVRocmVh
ZFN0YWxsRG9wQ2xvY2tHYXRpbmc6YmR3IChwcmUtcHJvZHVjdGlvbikgKi8KCkhtbS4gV2Ugc3Rp
bGwgaGF2ZSBwcmUtcHJvZCB3b3JrYXJvdW5kcyBmb3IgQkRXPwoKQW55IHZvbHVudGVlcnMgdG8g
Z28gdGhyb3VnaCBpdCBhbGwgYW5kIGNsZWFuIHRoaW5ncyB1cD8gT3IgbWF5YmUKc29tZW9uZSBh
bHJlYWR5IGRpZCBhbmQgdGhlIHBhdGNoZXMgYXJlIGluIHNvbWUga2luZCBvZiBhIGxpbWJvPwoK
LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4Cg==